Skip to content

Commit 48a9af1

Browse files
authored
Merge pull request webpack#6183 from ooflorent/resolver_deprecations
Do not use deprecated features of enhanced-resolve
2 parents 411ec0f + 202e399 commit 48a9af1

3 files changed

Lines changed: 9 additions & 9 deletions

File tree

lib/ContextModuleFactory.js

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -77,14 +77,14 @@ module.exports = class ContextModuleFactory extends Tapable {
7777

7878
asyncLib.parallel([
7979
callback => {
80-
contextResolver.resolve({}, context, resource, (err, result) => {
80+
contextResolver.resolve({}, context, resource, {}, (err, result) => {
8181
if(err) return callback(err);
8282
callback(null, result);
8383
});
8484
},
8585
callback => {
8686
asyncLib.map(loaders, (loader, callback) => {
87-
loaderResolver.resolve({}, context, loader, (err, result) => {
87+
loaderResolver.resolve({}, context, loader, {}, (err, result) => {
8888
if(err) return callback(err);
8989
callback(null, result);
9090
});

lib/NormalModuleFactory.js

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -160,7 +160,7 @@ class NormalModuleFactory extends Tapable {
160160
});
161161
}
162162

163-
normalResolver.resolve(contextInfo, context, resource, (err, resource, resourceResolveData) => {
163+
normalResolver.resolve(contextInfo, context, resource, {}, (err, resource, resourceResolveData) => {
164164
if(err) return callback(err);
165165
callback(null, {
166166
resourceResolveData,
@@ -302,9 +302,9 @@ class NormalModuleFactory extends Tapable {
302302
resolveRequestArray(contextInfo, context, array, resolver, callback) {
303303
if(array.length === 0) return callback(null, []);
304304
asyncLib.map(array, (item, callback) => {
305-
resolver.resolve(contextInfo, context, item.loader, (err, result) => {
305+
resolver.resolve(contextInfo, context, item.loader, {}, (err, result) => {
306306
if(err && /^[^/]*$/.test(item.loader) && !/-loader$/.test(item.loader)) {
307-
return resolver.resolve(contextInfo, context, item.loader + "-loader", err2 => {
307+
return resolver.resolve(contextInfo, context, item.loader + "-loader", {}, err2 => {
308308
if(!err2) {
309309
err.message = err.message + "\n" +
310310
"BREAKING CHANGE: It's no longer allowed to omit the '-loader' suffix when using loaders.\n" +

test/statsCases/resolve-plugin-context/ResolvePackageFromRootPlugin.js

Lines changed: 4 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -25,22 +25,22 @@ module.exports = class ResolvePackageFromRootPlugin {
2525
return callback(null, originalResolved)
2626
}
2727

28-
resolver.doResolve("resolve", {
28+
resolver.doResolve(resolver.hooks.resolve, {
2929
context: {},
3030
path: originalResolved.context.issuer,
3131
request: originalResolved.context.issuer
32-
}, `resolve issuer of ${originalResolved.path}`, (err, issuer) => {
32+
}, `resolve issuer of ${originalResolved.path}`, {}, (err, issuer) => {
3333
if (err) {
3434
return callback(null, originalResolved);
3535
}
3636

3737
const moduleRequestPath = originalResolved.path.replace(replaceNodeModuleRegex, "");
3838

39-
resolver.doResolve("resolve", {
39+
resolver.doResolve(resolver.hooks.resolve, {
4040
context: {},
4141
path: this.rootPath,
4242
request: moduleRequestPath
43-
}, `resolve ${moduleRequestPath} in ${this.rootPath}`, (err, resolvedInParentContext) => {
43+
}, `resolve ${moduleRequestPath} in ${this.rootPath}`, {}, (err, resolvedInParentContext) => {
4444
if (err) {
4545
return callback(null, originalResolved);
4646
}

0 commit comments

Comments
 (0)