refactor(WarnCaseSensitiveModulesPlugin): Using Map in moduleWithoutCase

willmendesneto · sokra · commit 462194c9b1fe · 2017-02-08T09:49:11.000+01:00
diff --git a/lib/WarnCaseSensitiveModulesPlugin.js b/lib/WarnCaseSensitiveModulesPlugin.js
@@ -10,18 +10,20 @@ class WarnCaseSensitiveModulesPlugin {
 	apply(compiler) {
 		compiler.plugin("compilation", compilation => {
 			compilation.plugin("seal", function() {
-				const moduleWithoutCase = {};
+				const moduleWithoutCase = new Map();
 				this.modules.forEach(module => {
-					const ident = module.identifier().toLowerCase();
-					if(moduleWithoutCase[`$${ident}`]) {
-						moduleWithoutCase[`$${ident}`].push(module);
+					const identifier = module.identifier().toLowerCase();
+					const moduleInstance = moduleWithoutCase.get(`$${identifier}`)
+					if(moduleInstance) {
+						moduleWithoutCase.set(`$${identifier}`, moduleInstance.push(module));
 					} else {
-						moduleWithoutCase[`$${ident}`] = [module];
+						moduleWithoutCase.set(`$${identifier}`, [module]);
 					}
-				}, this);
+				});
 				Object.keys(moduleWithoutCase).forEach(key => {
-					if(moduleWithoutCase[key].length > 1)
-						this.warnings.push(new CaseSensitiveModulesWarning(moduleWithoutCase[key]));
+					const moduleInstance = moduleWithoutCase.get(key);
+					if(moduleInstance.length > 1)
+						this.warnings.push(new CaseSensitiveModulesWarning(moduleInstance));
 				}, this);
 			});
 		});
