Function name cannot contain -

Kurt Harriger · Kurt Harriger · commit 45a9f0d4923d · 2014-08-03T10:32:56.000-06:00
When output.library contains a - the generated function name is not
valid.  Replace - with _ to create valid function name.
diff --git a/lib/JsonpHotUpdateChunkTemplatePlugin.js b/lib/JsonpHotUpdateChunkTemplatePlugin.js
@@ -10,7 +10,7 @@ module.exports = JsonpHotUpdateChunkTemplatePlugin;
 
 JsonpHotUpdateChunkTemplatePlugin.prototype.apply = function(hotUpdateChunkTemplate) {
 	hotUpdateChunkTemplate.plugin("render", function(modulesSource, modules, hash, id) {
-		var jsonpFunction = this.outputOptions.hotUpdateFunction || ("webpackHotUpdate" + (this.outputOptions.library || ""));
+		var jsonpFunction = this.outputOptions.hotUpdateFunction || ("webpackHotUpdate" + (this.outputOptions.library || "").replace('-','_'));
 		var source = new ConcatSource();
 		source.add(jsonpFunction + "(" + JSON.stringify(id) + ",");
 		source.add(modulesSource);
diff --git a/lib/JsonpMainTemplatePlugin.js b/lib/JsonpMainTemplatePlugin.js
@@ -114,7 +114,7 @@ JsonpMainTemplatePlugin.prototype.apply = function(mainTemplate) {
 	mainTemplate.plugin("hot-bootstrap", function(source, chunk, hash) {
 		var hotUpdateChunkFilename = this.outputOptions.hotUpdateChunkFilename;
 		var hotUpdateMainFilename = this.outputOptions.hotUpdateMainFilename;
-		var hotUpdateFunction = this.outputOptions.hotUpdateFunction || ("webpackHotUpdate" + (this.outputOptions.library || ""));
+		var hotUpdateFunction = this.outputOptions.hotUpdateFunction || ("webpackHotUpdate" + (this.outputOptions.library || "").replace('-','_'));
 		var currentHotUpdateChunkFilename = JSON.stringify(hotUpdateChunkFilename)
 			.replace(Template.REGEXP_HASH, "\" + " + this.renderCurrentHashCode(hash) + " + \"")
 			.replace(Template.REGEXP_ID, "\" + chunkId + \"");
