Merge pull request webpack#1913 from ianks/master

sokra · sokra · commit 37d2b1a94da1 · 2016-01-26T19:29:11.000+01:00
Use better error message for when given multiple args for CommonChunks Plugin
diff --git a/lib/optimize/CommonsChunkPlugin.js b/lib/optimize/CommonsChunkPlugin.js
@@ -5,8 +5,21 @@
 var nextIdent = 0;
 
 function CommonsChunkPlugin(options) {
-	if(arguments.length > 1)
-		throw new Error("CommonsChunkPlugin only takes one argument (pass an options object)");
+	if(arguments.length > 1) {
+		throw new Error("Deprecation notice: CommonsChunkPlugin now only takes a single argument. Either an options " +
+				"object *or* the name of the chunk.\n" +
+				"Example: if your old code looked like this:\n" +
+				"    new webpack.optimize.CommonsChunkPlugin('vendor', 'vendor.bundle.js')\n\n" +
+				"You would change it to:\n" +
+				"    new webpack.optimize.CommonsChunkPlugin({ name: 'vendor', filename: 'vendor.bundle.js' })\n\n" +
+				"The available options are:\n" +
+				"    name: string\n" +
+				"    names: string[]\n" +
+				"    filename: string\n" +
+				"    minChunks: number\n" +
+				"    async: boolean\n" +
+				"    minSize: number\n");
+	}
 	if(Array.isArray(options) || typeof options === "string") {
 		options = {
 			name: options
