updated plugin calls to options object

sokra · sokra · commit 33d954229bc8 · 2015-10-31T16:31:10.000+01:00
diff --git a/examples/move-to-parent/webpack.config.js b/examples/move-to-parent/webpack.config.js
@@ -14,15 +14,26 @@ module.exports = {
 	},
 	plugins: [
 		// check for common modules in children of pageA and move them to the parent
-		new CommonsChunkPlugin("pageA", null, false),
-		
+		new CommonsChunkPlugin({
+			name: "pageA",
+			children: true
+		}),
+
 		// the same for pageB but move them if at least 3 children share the module
-		new CommonsChunkPlugin("pageB", null, false, 3),
-		
+		new CommonsChunkPlugin({
+			name: "pageB",
+			children: true,
+			minChunks: 3
+		}),
+
 		// the same for pageC and pageD but with a custom logic for moving
-		new CommonsChunkPlugin(["pageC", "pageD"], null, false, function(module, count) {
-			// move only module "b"
-			return /b\.js$/.test(module.identifier());
+		new CommonsChunkPlugin({
+			names: ["pageC", "pageD"],
+			children: true,
+			minChunks: function(module, count) {
+				// move only module "b"
+				return /b\.js$/.test(module.identifier());
+			}
 		})
 	]
 }
diff --git a/examples/multiple-commons-chunks/webpack.config.js b/examples/multiple-commons-chunks/webpack.config.js
@@ -14,8 +14,18 @@ module.exports = {
 		filename: "[name].js"
 	},
 	plugins: [
-		new CommonsChunkPlugin("admin-commons.js", ["adminPageA", "adminPageB"]),
-		new CommonsChunkPlugin("commons.js", ["pageA", "pageB", "admin-commons.js"], 2),
-		new CommonsChunkPlugin("c-commons.js", ["pageC", "adminPageC"]),
+		new CommonsChunkPlugin({
+			name: "admin-commons.js",
+			chunks: ["adminPageA", "adminPageB"]
+		}),
+		new CommonsChunkPlugin({
+			name: "commons.js",
+			chunks: ["pageA", "pageB", "admin-commons.js"],
+			minChunks: 2
+		}),
+		new CommonsChunkPlugin({
+			name: "c-commons.js",
+			chunks: ["pageC", "adminPageC"]
+		}),
 	]
-}
+}
diff --git a/examples/multiple-entry-points-commons-chunk-css-bundle/webpack.config.js b/examples/multiple-entry-points-commons-chunk-css-bundle/webpack.config.js
@@ -21,7 +21,11 @@ module.exports = {
 		]
 	},
 	plugins: [
-		new CommonsChunkPlugin("commons", "commons.js", ["A", "B"]),
+		new CommonsChunkPlugin({
+			name: "commons",
+			filename: "commons.js",
+			chunks: ["A", "B"]
+		}),
 		new ExtractTextPlugin("[name].css"),
 	]
 };
diff --git a/test/Errors.test.js b/test/Errors.test.js
@@ -101,8 +101,16 @@ describe("Errors", function() {
 				filename: "[name].js"
 			},
 			plugins: [
-				new webpack.optimize.CommonsChunkPlugin("a", "a.js", Infinity),
-				new webpack.optimize.CommonsChunkPlugin("b", "b.js", Infinity)
+				new webpack.optimize.CommonsChunkPlugin({
+					name: "a",
+					filename: "a.js",
+					minChunks: Infinity
+				}),
+				new webpack.optimize.CommonsChunkPlugin({
+					name: "b",
+					filename: "b.js",
+					minChunks: Infinity
+				})
 			]
 		}, function(errors, warnings) {
 			errors.length.should.be.eql(1);
diff --git a/test/configCases/plugins/banner-plugin/webpack.config.js b/test/configCases/plugins/banner-plugin/webpack.config.js
@@ -12,7 +12,8 @@ module.exports = {
 		filename: "[name].js"
 	},
 	plugins: [
-		new webpack.BannerPlugin("A test value", {
+		new webpack.BannerPlugin({
+			banner: "A test value",
 			exclude: ["vendors.js"]
 		})
 	]

Original file line number	Diff line number	Diff line change
`@@ -21,7 +21,11 @@ module.exports = {`
`21`	`21`	`]`
`22`	`22`	`},`
`23`	`23`	`plugins: [`
`24`		`- new CommonsChunkPlugin("commons", "commons.js", ["A", "B"]),`
	`24`	`+ new CommonsChunkPlugin({`
	`25`	`+ name: "commons",`
	`26`	`+ filename: "commons.js",`
	`27`	`+ chunks: ["A", "B"]`
	`28`	`+ }),`
`25`	`29`	`new ExtractTextPlugin("[name].css"),`
`26`	`30`	`]`
`27`	`31`	`};`