First stab at SourceMapDevToolPlugin excludeChunks option

sebastienbarre · sebastienbarre · commit 31ee49b95c28 · 2015-03-17T14:53:14.000-04:00
diff --git a/lib/SourceMapDevToolPlugin.js b/lib/SourceMapDevToolPlugin.js
@@ -22,6 +22,7 @@ function SourceMapDevToolPlugin(options, sourceMappingURLComment, moduleFilename
 		this.moduleFilenameTemplate = options.moduleFilenameTemplate || "webpack:///[resourcePath]";
 		this.fallbackModuleFilenameTemplate = options.fallbackModuleFilenameTemplate || "webpack:///[resourcePath]?[hash]";
 		this.cheapMode = options.cheapMode;
+		this.excludeChunks = options.excludeChunks;
 	}
 }
 module.exports = SourceMapDevToolPlugin;
@@ -32,6 +33,7 @@ SourceMapDevToolPlugin.prototype.apply = function(compiler) {
 	var fallbackModuleFilenameTemplate = this.fallbackModuleFilenameTemplate;
 	var requestShortener = new RequestShortener(compiler.context);
 	var cheapMode = this.cheapMode;
+	var excludeChunks = this.excludeChunks;
 	compiler.plugin("compilation", function(compilation) {
 		if(cheapMode) {
 			compilation.moduleTemplate.plugin("module", function(source, module) {
@@ -48,6 +50,9 @@ SourceMapDevToolPlugin.prototype.apply = function(compiler) {
 			var allModuleFilenames = [];
 			var tasks = [];
 			chunks.forEach(function(chunk) {
+				if (excludeChunks && excludeChunks.indexOf(chunk.name) !== -1) {
+					return;
+				}
 				chunk.files.slice().map(function(file) {
 					var asset = this.assets[file];
 					if(asset.__SourceMapDevTool_Data) {
diff --git a/test/configCases/source-map/exclude-chunks-source-map/index.js b/test/configCases/source-map/exclude-chunks-source-map/index.js
@@ -0,0 +1,15 @@
+it("should include test.js in SourceMap for bundle0 chunk", function() {
+	var fs = require("fs");
+	var source = fs.readFileSync(__filename + ".map", "utf-8");
+	var map = JSON.parse(source);
+	map.sources.should.containEql("webpack:///./test.js");
+});
+
+it("should not produce a SourceMap for vendors chunk", function() {
+	var fs = require("fs"),
+			path = require("path"),
+			assert = require("assert");
+	fs.existsSync(path.join(__dirname, "vendors.js.map")).should.be.false;
+});
+
+require.include("./test.js");
diff --git a/test/configCases/source-map/exclude-chunks-source-map/test.js b/test/configCases/source-map/exclude-chunks-source-map/test.js
@@ -0,0 +1,3 @@
+var foo = {};
+
+module.exports = foo;
diff --git a/test/configCases/source-map/exclude-chunks-source-map/vendors.js b/test/configCases/source-map/exclude-chunks-source-map/vendors.js
@@ -0,0 +1,3 @@
+var bar = {};
+
+module.exports = bar;
diff --git a/test/configCases/source-map/exclude-chunks-source-map/webpack.config.js b/test/configCases/source-map/exclude-chunks-source-map/webpack.config.js
@@ -0,0 +1,20 @@
+var webpack = require("../../../../");
+module.exports = {
+	node: {
+		__dirname: false,
+		__filename: false
+	},
+	entry: {
+		bundle0: ["./index.js"],
+		vendors: ["./vendors.js"]
+	},
+	output: {
+		filename: "[name].js"
+	},
+	plugins: [
+		new webpack.SourceMapDevToolPlugin({
+			filename: "[file].map",
+			excludeChunks: ["vendors"]
+		})
+	]
+};

Original file line number	Diff line number	Diff line change
`@@ -0,0 +1,3 @@`
	`1`	`+var foo = {};`
	`2`	`+`
	`3`	`+module.exports = foo;`
Original file line number	Diff line number	Diff line change
`@@ -0,0 +1,3 @@`
	`1`	`+var bar = {};`
	`2`	`+`
	`3`	`+module.exports = bar;`