Skip to content

Commit 2dd0ba9

Browse files
committed
fixed wrong this within modules fixes webpack#97
1 parent b85bc53 commit 2dd0ba9

2 files changed

Lines changed: 5 additions & 5 deletions

File tree

lib/MainTemplate.js

Lines changed: 4 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -95,13 +95,13 @@ MainTemplate.prototype.renderRequireContent = function(hash, chunk) {
9595
"};",
9696
"",
9797
"// Execute the module function",
98-
"modules[moduleId].call(null, module, module.exports, " + this.renderRequireFunctionForModule(hash, chunk, "moduleId") + ");",
98+
"modules[moduleId].call(module.exports, module, module.exports, " + this.renderRequireFunctionForModule(hash, chunk, "moduleId") + ");",
9999
"",
100100
"// Flag the module as loaded",
101101
"module.loaded = true;",
102102
"",
103103
"// Return the exports of the module",
104-
"return module.exports;",
104+
"return module.exports;"
105105
];
106106
};
107107

@@ -155,8 +155,8 @@ MainTemplate.prototype.renderInitModules = function(hash, chunk, moduleTemplate,
155155
};
156156

157157
MainTemplate.prototype.renderAddModule = function(hash, chunk, varModuleId, varModule) {
158-
return ["modules[" + varModuleId + "] = " + varModule + ";"]
159-
}
158+
return ["modules[" + varModuleId + "] = " + varModule + ";"];
159+
};
160160

161161
MainTemplate.prototype.updateHash = function(hash) {
162162
hash.update("maintemplate");

lib/NormalModule.js

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -106,7 +106,7 @@ NormalModule.prototype.source = function(dependencyTemplates, outputOptions, req
106106
if(varNames.length == 0) return;
107107

108108
varStartCode += "/* WEBPACK VAR INJECTION */(function(require, " + varNames.join(", ") + ") {";
109-
varEndCode = "}(require, " + varExpressions.map(function(e) {return e.source()}).join(", ") + "))" + varEndCode;
109+
varEndCode = "}.call(exports, require, " + varExpressions.map(function(e) {return e.source()}).join(", ") + "))" + varEndCode;
110110

111111
varNames.length = 0;
112112
varExpressions.length = 0;

0 commit comments

Comments
 (0)