refactor(ES6): upgrade CommonsChunkPlugin to ES6

shubheksha · shubheksha · commit 29bf3e72f34c · 2017-01-10T17:18:36.000+05:30
diff --git a/lib/optimize/CommonsChunkPlugin.js b/lib/optimize/CommonsChunkPlugin.js
@@ -47,7 +47,7 @@ class CommonsChunkPlugin {
 		const minSize = this.minSize;
 		const ident = this.ident;
 		compiler.plugin("this-compilation", (compilation) => {
-			compilation.plugin(["optimize-chunks", "optimize-extracted-chunks"], function(chunks) {
+			compilation.plugin(["optimize-chunks", "optimize-extracted-chunks"], (chunks) => {
 				// only optimize once
 				if(compilation[ident]) return;
 				compilation[ident] = true;
@@ -57,11 +57,11 @@ class CommonsChunkPlugin {
 					commonChunks = chunks;
 				} else if(Array.isArray(chunkNames) || typeof chunkNames === "string") {
 					commonChunks = [].concat(chunkNames).map((chunkName) => {
-						let chunk = chunks.filter(function(chunk) {
+						let chunk = chunks.filter((chunk) => {
 							return chunk.name === chunkName;
 						})[0];
 						if(!chunk) {
-							chunk = this.addChunk(chunkName);
+							chunk = compilation.addChunk(chunkName);
 						}
 						return chunk;
 					}, this);
@@ -91,8 +91,9 @@ class CommonsChunkPlugin {
 							return chunk.hasRuntime();
 						});
 					}
+					let asyncChunk;
 					if(asyncOption) {
-						var asyncChunk = this.addChunk(typeof asyncOption === "string" ? asyncOption : undefined);
+						asyncChunk = compilation.addChunk(typeof asyncOption === "string" ? asyncOption : undefined);
 						asyncChunk.chunkReason = "async commons chunk";
 						asyncChunk.extraAsync = true;
 						asyncChunk.addParent(commonChunk);
@@ -103,8 +104,8 @@ class CommonsChunkPlugin {
 					if(minChunks !== Infinity) {
 						const commonModulesCount = [];
 						const commonModules = [];
-						usedChunks.forEach(function(chunk) {
-							chunk.modules.forEach(function(module) {
+						usedChunks.forEach((chunk) => {
+							chunk.modules.forEach((module) => {
 								const idx = commonModules.indexOf(module);
 								if(idx < 0) {
 									commonModules.push(module);
@@ -156,7 +157,7 @@ class CommonsChunkPlugin {
 							});
 						});
 						asyncChunk.origins = reallyUsedChunks.map((chunk) => {
-							return chunk.origins.map(function(origin) {
+							return chunk.origins.map((origin) => {
 								const newOrigin = Object.create(origin);
 								newOrigin.reasons = (origin.reasons || []).slice();
 								newOrigin.reasons.push("async commons");
