Merge pull request webpack#4021 from shubheksha/refactor-test-JsonpHotUpdateChunkTemplatePlugin

sokra · web-flow · commit 1e8f92aa6130 · 2017-02-03T14:02:48.000+01:00
refactor(ES6): JsonpHotUpdateChunkTemplatePlugin.test.js
diff --git a/test/JsonpHotUpdateChunkTemplatePlugin.test.js b/test/JsonpHotUpdateChunkTemplatePlugin.test.js
@@ -1,67 +1,56 @@
-var should = require("should");
-var sinon = require("sinon");
-var ConcatSource = require("webpack-sources").ConcatSource;
-var JsonpHotUpdateChunkTemplatePlugin = require("../lib/JsonpHotUpdateChunkTemplatePlugin");
-var applyPluginWithOptions = require("./helpers/applyPluginWithOptions");
+"use strict";
 
-describe("JsonpHotUpdateChunkTemplatePlugin", function() {
-	var handlerContext;
+const should = require("should");
+const sinon = require("sinon");
+const ConcatSource = require("webpack-sources").ConcatSource;
+const JsonpHotUpdateChunkTemplatePlugin = require("../lib/JsonpHotUpdateChunkTemplatePlugin");
+const applyPluginWithOptions = require("./helpers/applyPluginWithOptions");
 
-	beforeEach(function() {
+describe("JsonpHotUpdateChunkTemplatePlugin", () => {
+	let handlerContext;
+
+	beforeEach(() =>
 		handlerContext = {
 			outputOptions: {
 				hotUpdateFunction: "Foo",
 				library: "Bar"
 			}
-		};
-	});
+		});
 
-	it("has apply function", function() {
-		(new JsonpHotUpdateChunkTemplatePlugin()).apply.should.be.a.Function();
-	});
+	it("has apply function", () => (new JsonpHotUpdateChunkTemplatePlugin()).apply.should.be.a.Function());
 
-	describe("when applied", function() {
-		var eventBindings, eventBinding;
+	describe("when applied", () => {
+		let eventBindings, eventBinding;
 
-		beforeEach(function() {
-			eventBindings = applyPluginWithOptions(JsonpHotUpdateChunkTemplatePlugin);
-		});
+		beforeEach(() => eventBindings = applyPluginWithOptions(JsonpHotUpdateChunkTemplatePlugin));
 
-		it("binds two event handlers", function() {
-			eventBindings.length.should.be.exactly(2);
-		});
+		it("binds two event handlers", () => eventBindings.length.should.be.exactly(2));
 
-		describe("render handler", function() {
-			beforeEach(function() {
-				eventBinding = eventBindings[0];
-			});
+		describe("render handler", () => {
+			beforeEach(() => eventBinding = eventBindings[0]);
 
-			it("binds to render event", function() {
-				eventBinding.name.should.be.exactly("render");
-			});
+			it("binds to render event", () => eventBinding.name.should.be.exactly("render"));
 
-			it("creates source wrapper with export", function() {
-				var source = eventBinding.handler.call(handlerContext, "moduleSource()", [], [], {}, 100);
+			it("creates source wrapper with export", () => {
+				const source = eventBinding.handler.call(handlerContext, "moduleSource()", [], [], {}, 100);
 				source.should.be.instanceof(ConcatSource);
 				source.source().should.be.exactly("Foo(100,moduleSource())");
 			});
 		});
 
-		describe("hash handler", function() {
-			var hashMock;
+		describe("hash handler", () => {
+			let hashMock;
 
-			beforeEach(function() {
+			beforeEach(() => {
 				eventBinding = eventBindings[1];
 				hashMock = {
 					update: sinon.spy()
 				};
 			});
 
-			it("binds to hash event", function() {
-				eventBinding.name.should.be.exactly("hash");
-			});
+			it("binds to hash event", () => eventBinding.name.should.be.exactly("hash"));
 
-			it("updates hash object", function() {
+			it("updates hash object", () => {
 				eventBinding.handler.call(handlerContext, hashMock);
 				hashMock.update.callCount.should.be.exactly(4);
 				sinon.assert.calledWith(hashMock.update, "JsonpHotUpdateChunkTemplatePlugin");
