really fixed the bug

sokra · sokra · commit 1726325ef23e · 2013-07-05T14:56:16.000+02:00
diff --git a/lib/HotModuleReplacementPlugin.js b/lib/HotModuleReplacementPlugin.js
@@ -54,18 +54,14 @@ HotModuleReplacementPlugin.prototype.apply = function(compiler) {
 			if(!records) return;
 			if(!records.hash) return;
 			var preHash = records.preHash;
-			if(!preHash) {
-				records.preHash = this.hash;
-				return;
-			}
+			if(!preHash) preHash = "x";
 			if(preHash === this.hash) {
-				if(records.prepreHash)
-					this.modifyHash(records.prepreHash);
+				this.modifyHash(records.prepreHash);
 				return;
 			}
-			records.prepreHash = preHash;
+			records.prepreHash = records.hash || "x";
 			records.preHash = this.hash;
-			this.modifyHash(preHash);
+			this.modifyHash(records.prepreHash);
 		});
 		compilation.plugin("additional-chunk-assets", function() {
 			var records = this.records;
diff --git a/package.json b/package.json
@@ -1,6 +1,6 @@
 {
 	"name": "webpack",
-	"version": "0.11.0-beta10",
+	"version": "0.11.0-beta11",
 	"author": "Tobias Koppers @sokra",
 	"description": "Packs CommonJs/AMD/Labeled Modules for the browser. Allows to split your codebase into multiple bundles, which can be loaded on demand. Support loaders to preprocess files, i.e. json, jade, coffee, css, less, ... and your custom stuff.",
 	"dependencies": {
diff --git a/test/HotModuleReplacementPlugin.test.js b/test/HotModuleReplacementPlugin.test.js
@@ -0,0 +1,55 @@
+var should = require("should");
+var path = require("path");
+var fs = require("fs");
+
+var webpack = require("../");
+
+describe("HotModuleReplacementPlugin", function() {
+	it("should not have circular hashes but equal if unmodified", function(done) {
+		var entryFile = path.join(__dirname, "js", "entry.js");
+		var recordsFile = path.join(__dirname, "js", "records.json");
+		try { fs.unlinkFileSync(recordsFile); } catch(e) {}
+		var compiler = webpack({
+			entry: entryFile,
+			recordsPath: recordsFile,
+			output: {
+				path: path.join(__dirname, "js")
+			},
+			hot: true
+		});
+		fs.writeFileSync(entryFile, "1", "utf-8");
+		compiler.run(function(err, stats) {
+			if(err) throw err;
+			var oldHash1 = stats.toJson().hash;
+			compiler.run(function(err, stats) {
+				if(err) throw err;
+				var lastHash1 = stats.toJson().hash;
+				lastHash1.should.be.eql(oldHash1);
+				fs.writeFileSync(entryFile, "2", "utf-8");
+				compiler.run(function(err, stats) {
+					if(err) throw err;
+					var lastHash2 = stats.toJson().hash;
+					fs.writeFileSync(entryFile, "1", "utf-8");
+					compiler.run(function(err, stats) {
+						if(err) throw err;
+						var currentHash1 = stats.toJson().hash;
+						currentHash1.should.not.be.eql(lastHash1);
+						fs.writeFileSync(entryFile, "2", "utf-8");
+						compiler.run(function(err, stats) {
+							if(err) throw err;
+							var currentHash2 = stats.toJson().hash;
+							compiler.run(function(err, stats) {
+								if(err) throw err;
+								stats.toJson().hash.should.be.eql(currentHash2);
+								currentHash2.should.not.be.eql(lastHash2);
+								currentHash1.should.not.be.eql(currentHash2);
+								lastHash1.should.not.be.eql(lastHash2);
+								done();
+							});
+						});
+					});
+				});
+			});
+		});
+	});
+});

Original file line number	Diff line number	Diff line change
`@@ -1,6 +1,6 @@`
`1`	`1`	`{`
`2`	`2`	`"name": "webpack",`
`3`		`- "version": "0.11.0-beta10",`
	`3`	`+ "version": "0.11.0-beta11",`
`4`	`4`	`"author": "Tobias Koppers @sokra",`
`5`	`5`	`"description": "Packs CommonJs/AMD/Labeled Modules for the browser. Allows to split your codebase into multiple bundles, which can be loaded on demand. Support loaders to preprocess files, i.e. json, jade, coffee, css, less, ... and your custom stuff.",`
`6`	`6`	`"dependencies": {`