Merge pull request webpack#2497 from achicu/achicu/fix_error_memory_leak

sokra · web-flow · commit 119af18c0c63 · 2016-08-17T13:06:34.000+02:00
Fixing memory leak causing node go out of memory
diff --git a/lib/Compilation.js b/lib/Compilation.js
@@ -319,6 +319,12 @@ Compilation.prototype.addModuleDependencies = function(module, dependencies, bai
 
 		});
 	}, function(err) {
+		// In V8, the Error objects keep a reference to the functions on the stack. These warnings &
+		// errors are created inside closures that keep a reference to the Compilation, so errors are
+		// leaking the Compilation object. Setting _this to null workarounds the following issue in V8.
+		// https://bugs.chromium.org/p/chromium/issues/detail?id=612191
+		_this = null;
+
 		if(err) {
 			return callback(err);
 		}
