assign correct records and cache to child compilations

sokra · sokra · commit 101850c5a90d · 2017-05-04T13:05:03.000+02:00
This is a breaking change because plugins or loader could rely on this incorrect behavior When using child compilations plugins and loaders should use a unique compiler name or use a consistent order fixes webpack#2777
diff --git a/lib/Compilation.js b/lib/Compilation.js
@@ -80,6 +80,7 @@ class Compilation extends Tapable {
 		this.children = [];
 		this.dependencyFactories = new Map();
 		this.dependencyTemplates = new Map();
+		this.childrenCounters = {};
 	}
 
 	getStats() {
@@ -1218,8 +1219,10 @@ class Compilation extends Tapable {
 		return this.mainTemplate.applyPluginsWaterfall("asset-path", filename, data);
 	}
 
-	createChildCompiler(name, outputOptions) {
-		return this.compiler.createChildCompiler(this, name, outputOptions);
+	createChildCompiler(name, outputOptions, plugins) {
+		var idx = (this.childrenCounters[name] || 0);
+		this.childrenCounters[name] = idx + 1;
+		return this.compiler.createChildCompiler(this, name, idx, outputOptions, plugins);
 	}
 
 	checkConstraints() {
diff --git a/lib/Compiler.js b/lib/Compiler.js
@@ -10,6 +10,8 @@ var Stats = require("./Stats");
 var NormalModuleFactory = require("./NormalModuleFactory");
 var ContextModuleFactory = require("./ContextModuleFactory");
 
+var makePathsRelative = require("./util/identifier").makePathsRelative;
+
 function Watching(compiler, watchOptions, handler) {
 	this.startTime = null;
 	this.invalid = false;
@@ -407,7 +409,7 @@ Compiler.prototype.readRecords = function readRecords(callback) {
 	});
 };
 
-Compiler.prototype.createChildCompiler = function(compilation, compilerName, outputOptions, plugins) {
+Compiler.prototype.createChildCompiler = function(compilation, compilerName, compilerIndex, outputOptions, plugins) {
 	var childCompiler = new Compiler();
 	if(Array.isArray(plugins)) {
 		plugins.forEach(plugin => childCompiler.apply(plugin));
@@ -423,8 +425,23 @@ Compiler.prototype.createChildCompiler = function(compilation, compilerName, out
 	childCompiler.resolvers = this.resolvers;
 	childCompiler.fileTimestamps = this.fileTimestamps;
 	childCompiler.contextTimestamps = this.contextTimestamps;
-	if(!this.records[compilerName]) this.records[compilerName] = [];
-	this.records[compilerName].push(childCompiler.records = {});
+
+	var relativeCompilerName = makePathsRelative(this.context, compilerName);
+	if(!this.records[relativeCompilerName]) this.records[relativeCompilerName] = [];
+	if(this.records[relativeCompilerName][compilerIndex])
+		childCompiler.records = this.records[relativeCompilerName][compilerIndex];
+	else
+		this.records[relativeCompilerName].push(childCompiler.records = {});
+
+	if(this.cache) {
+		if(!this.cache.children) this.cache.children = {};
+		if(!this.cache.children[compilerName]) this.cache.children[compilerName] = [];
+		if(this.cache.children[compilerName][compilerIndex])
+			childCompiler.cache = this.cache.children[compilerName][compilerIndex];
+		else
+			this.cache.children[compilerName].push(childCompiler.cache = {});
+	}
+
 	childCompiler.options = Object.create(this.options);
 	childCompiler.options.output = Object.create(childCompiler.options.output);
 	for(name in outputOptions) {

Original file line number	Diff line number	Diff line change
`@@ -80,6 +80,7 @@ class Compilation extends Tapable {`
`80`	`80`	`this.children = [];`
`81`	`81`	`this.dependencyFactories = new Map();`
`82`	`82`	`this.dependencyTemplates = new Map();`
	`83`	`+ this.childrenCounters = {};`
`83`	`84`	`}`
`84`	`85`
`85`	`86`	`getStats() {`
`@@ -1218,8 +1219,10 @@ class Compilation extends Tapable {`
`1218`	`1219`	`return this.mainTemplate.applyPluginsWaterfall("asset-path", filename, data);`
`1219`	`1220`	`}`
`1220`	`1221`
`1221`		`- createChildCompiler(name, outputOptions) {`
`1222`		`- return this.compiler.createChildCompiler(this, name, outputOptions);`
	`1222`	`+ createChildCompiler(name, outputOptions, plugins) {`
	`1223`	`+ var idx = (this.childrenCounters[name] \|\| 0);`
	`1224`	`+ this.childrenCounters[name] = idx + 1;`
	`1225`	`+ return this.compiler.createChildCompiler(this, name, idx, outputOptions, plugins);`
`1223`	`1226`	`}`
`1224`	`1227`
`1225`	`1228`	`checkConstraints() {`