Skip to content

Commit 0c78ca7

Browse files
committed
ContextReplacementPlugin should remove critical dependency warnings
1 parent 711a382 commit 0c78ca7

4 files changed

Lines changed: 10 additions & 9 deletions

File tree

lib/ContextReplacementPlugin.js

Lines changed: 10 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -52,6 +52,11 @@ ContextReplacementPlugin.prototype.apply = function(compiler) {
5252
result.regExp = newContentRegExp;
5353
if(typeof newContentCallback === "function") {
5454
newContentCallback(result);
55+
} else {
56+
result.dependencies.forEach(function(d) {
57+
if(d.critical)
58+
d.critical = false;
59+
});
5560
}
5661
}
5762
return callback(null, result);
@@ -73,6 +78,11 @@ ContextReplacementPlugin.prototype.apply = function(compiler) {
7378
if(result.resource !== origResource) {
7479
result.resource = path.resolve(origResource, result.resource);
7580
}
81+
} else {
82+
result.dependencies.forEach(function(d) {
83+
if(d.critical)
84+
d.critical = false;
85+
});
7686
}
7787
}
7888
return callback(null, result);

test/configCases/context-replacement/a/warnings.js

Lines changed: 0 additions & 3 deletions
This file was deleted.

test/configCases/context-replacement/b/warnings.js

Lines changed: 0 additions & 3 deletions
This file was deleted.

test/configCases/context-replacement/c/warnings.js

Lines changed: 0 additions & 3 deletions
This file was deleted.

0 commit comments

Comments
 (0)