rename state param to data

brockallen · brockallen · commit ff230bff6815 · 2016-03-25T17:50:36.000-04:00
diff --git a/src/OidcClientService.js b/src/OidcClientService.js
@@ -19,7 +19,7 @@ export default class OidcClientService {
         return this._settings;
     }
     
-    createSigninRequest({response_type, scope, redirect_uri, state}={}) {
+    createSigninRequest({response_type, scope, redirect_uri, data}={}) {
         Log.info("OidcClientService.createSigninRequest");
         
         let client_id = this._settings.client_id;
@@ -35,7 +35,7 @@ export default class OidcClientService {
                 redirect_uri,
                 response_type,
                 scope,
-                state});
+                data});
         }, err => {
             Log.error("Failed to create signin request", err);
             throw new Error("Failed to create signin request");
@@ -48,7 +48,7 @@ export default class OidcClientService {
         
     }
     
-    createSignoutRequest({id_token_hint, state, post_logout_redirect_uri}={}){
+    createSignoutRequest({id_token_hint, data, post_logout_redirect_uri}={}){
         Log.info("OidcClientService.createSignoutRequest");
         
         post_logout_redirect_uri = post_logout_redirect_uri || this._settings.post_logout_redirect_uri;
@@ -59,7 +59,7 @@ export default class OidcClientService {
             return new SignoutRequest({url,
                 id_token_hint,
                 post_logout_redirect_uri,
-                state});
+                data});
         }, err => {
             Log.error("Failed to create signout request", err);
             throw new Error("Failed to create signout request");
diff --git a/src/SigninRequest.js b/src/SigninRequest.js
@@ -3,7 +3,7 @@ import UrlUtility from './UrlUtility';
 import State from './State';
 
 export default class SigninRequest {
-    constructor({url, client_id, redirect_uri, response_type, scope, state}) {
+    constructor({url, client_id, redirect_uri, response_type, scope, data}) {
         
         if (!url){
             Log.error("No url passed to SigninRequest");
@@ -31,7 +31,7 @@ export default class SigninRequest {
         this._redirect_uri = redirect_uri;
         this._response_type = response_type;
         this._scope = scope;
-        this._state = new State({nonce:this.isOidc, data:state});
+        this._state = new State({nonce:this.isOidc, data});
     }
     
     get state(){
diff --git a/src/SignoutRequest.js b/src/SignoutRequest.js
@@ -3,7 +3,7 @@ import UrlUtility from './UrlUtility';
 import State from './State';
 
 export default class SignoutRequest {
-    constructor({url, id_token_hint, post_logout_redirect_uri, state}) {
+    constructor({url, id_token_hint, post_logout_redirect_uri, data}) {
         if (!url) {
             Log.error("No url passed to SignoutRequest");
             throw new Error("url");
@@ -13,7 +13,7 @@ export default class SignoutRequest {
         this._id_token_hint = id_token_hint;
         this._post_logout_redirect_uri = post_logout_redirect_uri;
 
-        this._state = new State({data:state});
+        this._state = new State({data});
     }
 
     get state(){
diff --git a/test/OidcClientService.spec.js b/test/OidcClientService.spec.js
@@ -62,7 +62,7 @@ describe("OidcClientService", function() {
             stubMetadataService.getAuthorizationEndpointResult = Promise.resolve("http://sts/authorize");
 
             var p = subject.createSigninRequest({
-                state: 'foo',
+                data: 'foo',
                 response_type: 'bar',
                 scope: 'baz',
                 redirect_uri: 'quux'
@@ -115,7 +115,7 @@ describe("OidcClientService", function() {
             stubMetadataService.getEndSessionEndpointResult = Promise.resolve("http://sts/signout");
 
             var p = subject.createSignoutRequest({
-                state: 'foo',
+                data: 'foo',
                 post_logout_redirect_uri: "bar",
                 id_token_hint: "baz"
             });
diff --git a/test/SigninRequest.spec.js b/test/SigninRequest.spec.js
@@ -16,7 +16,7 @@ describe("SigninRequest", function() {
             redirect_uri: "http://app", 
             response_type: "id_token", 
             scope: "openid", 
-            state: {data: "test"}
+            data: {data: "test"}
         };
         subject = new SigninRequest(settings);
     });
diff --git a/test/SignoutRequest.spec.js b/test/SignoutRequest.spec.js
@@ -15,7 +15,7 @@ describe("SignoutRequest", function() {
             url: "http://sts/signout",
             id_token_hint: "hint",
             post_logout_redirect_uri: "loggedout",
-            state: { data: "test" }
+            data: { data: "test" }
         };
         subject = new SignoutRequest(settings);
     });
