leet ctor defaults

brockallen · brockallen · commit 3b20360cc930 · 2016-03-23T18:05:06.000-04:00
diff --git a/src/AuthorizationResultParser.js b/src/AuthorizationResultParser.js
@@ -3,8 +3,8 @@ import Window from './Window';
 
 export default class AuthorizationResultParser {
     
-    constructor(window){
-        this._window = window || Window;
+    constructor(window = Window){
+        this._window = window;
     }
     
     parseResult(value) {
diff --git a/src/JsonService.js b/src/JsonService.js
@@ -2,8 +2,8 @@ import Log from './Log';
 import XMLHttpRequestFactory from './XMLHttpRequestFactory';
 
 export default class JsonService {
-    constructor(httpRequestFactory) {
-        this._httpRequestFactory = httpRequestFactory || XMLHttpRequestFactory;
+    constructor(httpRequestFactory = XMLHttpRequestFactory) {
+        this._httpRequestFactory = httpRequestFactory;
     }
     
     getJson(url, token) {
diff --git a/src/Log.js b/src/Log.js
@@ -16,7 +16,6 @@ export default class Log {
     static get enabled(){
         return enabled;
     }
-    
     static set enabled(value){
         enabled = !!value;
     }
diff --git a/src/MetadataService.js b/src/MetadataService.js
@@ -2,14 +2,14 @@ import JsonService from './JsonService';
 import Log from './Log';
 
 export default class MetadataService {
-    constructor(settings, jsonService) {
+    constructor(settings, jsonService = new JsonService()) {
         
         if (!settings){
             throw new Error("settings");
         }
         
         this._settings = settings;
-        this._jsonService = jsonService || new JsonService();
+        this._jsonService = jsonService;
     }
 
     getMetadata() {
diff --git a/src/OidcClientService.js b/src/OidcClientService.js
@@ -1,5 +1,6 @@
 import Log from './Log';
 import OidcClientSettings from './OidcClientSettings';
+import SigninRequest from './SigninRequest';
 
 export default class OidcClientService {
     constructor(settings) {
@@ -14,13 +15,20 @@ export default class OidcClientService {
         return this._settings;
     }
     
-    createSigninRequest(){
+    createSigninRequest() {
+        Log.info("createSigninRequest");
+        
+        //reSigninRequest.create(this._settings);
     }
     
     processSigninResponse(){
+        Log.info("processSigninResponse");
+        
     }
     
     createSignoutRequest(){
+        Log.info("createSignoutRequest");
+        
     }
     
 //     OidcClient.prototype.createTokenRequestAsync = function () {
diff --git a/src/XMLHttpRequestFactory.js b/src/XMLHttpRequestFactory.js
@@ -1,8 +1,8 @@
 import Window from './Window';
 
 export default class XMLHttpRequestFactory {
-    constructor(window){
-        this._window = window || Window;
+    constructor(window = Window){
+        this._window = window;
     }
     
     create() {

Original file line number	Diff line number	Diff line change
`@@ -3,8 +3,8 @@ import Window from './Window';`
`3`	`3`
`4`	`4`	`export default class AuthorizationResultParser {`
`5`	`5`
`6`		`- constructor(window){`
`7`		`- this._window = window \|\| Window;`
	`6`	`+ constructor(window = Window){`
	`7`	`+ this._window = window;`
`8`	`8`	`}`
`9`	`9`
`10`	`10`	`parseResult(value) {`
Original file line number	Diff line number	Diff line change
`@@ -2,8 +2,8 @@ import Log from './Log';`
`2`	`2`	`import XMLHttpRequestFactory from './XMLHttpRequestFactory';`
`3`	`3`
`4`	`4`	`export default class JsonService {`
`5`		`- constructor(httpRequestFactory) {`
`6`		`- this._httpRequestFactory = httpRequestFactory \|\| XMLHttpRequestFactory;`
	`5`	`+ constructor(httpRequestFactory = XMLHttpRequestFactory) {`
	`6`	`+ this._httpRequestFactory = httpRequestFactory;`
`7`	`7`	`}`
`8`	`8`
`9`	`9`	`getJson(url, token) {`
Original file line number	Diff line number	Diff line change
`@@ -16,7 +16,6 @@ export default class Log {`
`16`	`16`	`static get enabled(){`
`17`	`17`	`return enabled;`
`18`	`18`	`}`
`19`		`-`
`20`	`19`	`static set enabled(value){`
`21`	`20`	`enabled = !!value;`
`22`	`21`	`}`
Original file line number	Diff line number	Diff line change
`@@ -2,14 +2,14 @@ import JsonService from './JsonService';`
`2`	`2`	`import Log from './Log';`
`3`	`3`
`4`	`4`	`export default class MetadataService {`
`5`		`- constructor(settings, jsonService) {`
	`5`	`+ constructor(settings, jsonService = new JsonService()) {`
`6`	`6`
`7`	`7`	`if (!settings){`
`8`	`8`	`throw new Error("settings");`
`9`	`9`	`}`
`10`	`10`
`11`	`11`	`this._settings = settings;`
`12`		`- this._jsonService = jsonService \|\| new JsonService();`
	`12`	`+ this._jsonService = jsonService;`
`13`	`13`	`}`
`14`	`14`
`15`	`15`	`getMetadata() {`
Original file line number	Diff line number	Diff line change
`@@ -1,5 +1,6 @@`
`1`	`1`	`import Log from './Log';`
`2`	`2`	`import OidcClientSettings from './OidcClientSettings';`
	`3`	`+import SigninRequest from './SigninRequest';`
`3`	`4`
`4`	`5`	`export default class OidcClientService {`
`5`	`6`	`constructor(settings) {`
`@@ -14,13 +15,20 @@ export default class OidcClientService {`
`14`	`15`	`return this._settings;`
`15`	`16`	`}`
`16`	`17`
`17`		`- createSigninRequest(){`
	`18`	`+ createSigninRequest() {`
	`19`	`+ Log.info("createSigninRequest");`
	`20`	`+`
	`21`	`+ //reSigninRequest.create(this._settings);`
`18`	`22`	`}`
`19`	`23`
`20`	`24`	`processSigninResponse(){`
	`25`	`+ Log.info("processSigninResponse");`
	`26`	`+`
`21`	`27`	`}`
`22`	`28`
`23`	`29`	`createSignoutRequest(){`
	`30`	`+ Log.info("createSignoutRequest");`
	`31`	`+`
`24`	`32`	`}`
`25`	`33`
`26`	`34`	`// OidcClient.prototype.createTokenRequestAsync = function () {`
Original file line number	Diff line number	Diff line change
`@@ -1,8 +1,8 @@`
`1`	`1`	`import Window from './Window';`
`2`	`2`
`3`	`3`	`export default class XMLHttpRequestFactory {`
`4`		`- constructor(window){`
`5`		`- this._window = window \|\| Window;`
	`4`	`+ constructor(window = Window){`
	`5`	`+ this._window = window;`
`6`	`6`	`}`
`7`	`7`
`8`	`8`	`create() {`