Add an API to pass an Object Literal for the write converter

FagnerMartinsBrack · FagnerMartinsBrack · commit a5640d48ac9b · 2015-10-17T15:32:52.000-03:00
When calling "Cookies.withConverter", you can pass either a function to
use as the read converter, or an Object Literal with the properties
"read" and "write".
diff --git a/src/js.cookie.js b/src/js.cookie.js
@@ -55,8 +55,12 @@
 					}
 				} catch (e) {}
 
-				value = encodeURIComponent(String(value));
-				value = value.replace(/%(23|24|26|2B|3A|3C|3E|3D|2F|3F|40|5B|5D|5E|60|7B|7D|7C)/g, decodeURIComponent);
+				if (!converter.write) {
+					value = encodeURIComponent(String(value))
+						.replace(/%(23|24|26|2B|3A|3C|3E|3D|2F|3F|40|5B|5D|5E|60|7B|7D|7C)/g, decodeURIComponent);
+				} else {
+					value = converter.write(value, key);
+				}
 
 				key = encodeURIComponent(String(key));
 				key = key.replace(/%(23|24|26|2B|5E|60|7C)/g, decodeURIComponent);
@@ -94,7 +98,9 @@
 				}
 
 				try {
-					cookie = converter && converter(cookie, name) || cookie.replace(rdecode, decodeURIComponent);
+					cookie = converter.read ?
+						converter.read(cookie, name) : converter(cookie, name) ||
+						cookie.replace(rdecode, decodeURIComponent);
 
 					if (this.json) {
 						try {
@@ -135,5 +141,5 @@
 		return api;
 	}
 
-	return init();
+	return init(function () {});
 }));
diff --git a/test/tests.js b/test/tests.js
@@ -279,6 +279,28 @@ QUnit.test('should be able to conditionally decode a single malformed cookie', f
 	assert.strictEqual(document.cookie, '', 'should remove everything');
 });
 
+// github.com/js-cookie/js-cookie/issues/70
+QUnit.test('should be able to create a write decoder', function (assert) {
+	assert.expect(1);
+	Cookies.withConverter({
+		write: function (value) {
+			return value.replace('+', '%2B');
+		}
+	}).set('c', '+');
+	assert.strictEqual(document.cookie, 'c=%2B', 'should call the write converter');
+});
+
+QUnit.test('should be able to use read and write decoder', function (assert) {
+	assert.expect(1);
+	document.cookie = 'c=%2B';
+	var cookies = Cookies.withConverter({
+		read: function (value) {
+			return value.replace('%2B', '+');
+		}
+	});
+	assert.strictEqual(cookies.get('c'), '+', 'should call the read converter');
+});
+
 QUnit.module('JSON handling', lifecycle);
 
 QUnit.test('Number', function (assert) {
