Skip to content

Commit 9b5607e

Browse files
Contribution guidelines enhancement
Closes js-cookiegh-181
1 parent 60c1126 commit 9b5607e

File tree

2 files changed

+55
-20
lines changed

2 files changed

+55
-20
lines changed

CONTRIBUTING.md

Lines changed: 53 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,53 @@
1+
##Issues
2+
3+
- Report issues or feature requests on [GitHub Issues](https://github.com/carhartl/jquery-cookie/issues).
4+
- If reporting a bug, please add a [simplified example](http://sscce.org/).
5+
6+
##Pull requests
7+
- Create a new topic branch for every separate change you make.
8+
- Create a test case if you are fixing a bug or implementing an important feature.
9+
- Make sure the build runs successfully.
10+
11+
## Development
12+
13+
###Tools
14+
We use the following tools for development:
15+
16+
- [Qunit](http://qunitjs.com/) for tests.
17+
- [NodeJS](http://nodejs.org/download/) required to run grunt and the test server only.
18+
- [Grunt](http://gruntjs.com/getting-started) for task management.
19+
20+
###Getting started
21+
Install [NodeJS](http://nodejs.org/).
22+
Install globally grunt-cli using the following command:
23+
24+
$ npm install -g grunt-cli
25+
26+
Browse to the project root directory and install the dev dependencies:
27+
28+
$ npm install -d
29+
30+
To execute the build and tests run the following command in the root of the project:
31+
32+
$ grunt
33+
34+
You should see a green message in the console:
35+
36+
Done, without errors.
37+
38+
###Tests
39+
You can also run the tests in the browser.
40+
Start a test server from the project root:
41+
42+
$ node test/server.js
43+
44+
Open the following URL in a browser:
45+
46+
$ open http://0.0.0.0:8124/test/index.html
47+
48+
_Note: we recommend cleaning all the browser cookies before running the tests, that can avoid false positive failures._
49+
50+
###Automatic build
51+
You can build automatically after a file change using the following command:
52+
53+
$ grunt watch

README.md

Lines changed: 2 additions & 20 deletions
Original file line numberDiff line numberDiff line change
@@ -96,26 +96,8 @@ Define the domain where the cookie is valid. Default: domain of page where the c
9696

9797
If true, the cookie transmission requires a secure protocol (https). Default: `false`.
9898

99-
## Tests
100-
101-
Requires Node. Startup server:
102-
103-
$ node test/server.js
104-
105-
Open in browser:
106-
107-
$ open http://0.0.0.0:8124/test/index.html
108-
109-
For quick *non cross-browser* testing use grunt, install grunt CLI and project dependencies as outlined in this guide: <http://gruntjs.com/getting-started>, then run:
110-
111-
$ grunt
112-
113-
## Development
114-
115-
- Source hosted at [GitHub](https://github.com/carhartl/jquery-cookie)
116-
- Report issues, questions, feature requests on [GitHub Issues](https://github.com/carhartl/jquery-cookie/issues)
117-
118-
Pull requests are very welcome! Make sure your patches are well tested. Please create a topic branch for every separate change you make.
99+
##Wanna help?
100+
Check out the [Contributing Guidelines](CONTRIBUTING.md)
119101

120102
## Authors
121103

0 commit comments

Comments
 (0)