Commit 50b0b08
committed
This test is unnecessary
It was initially created to confirm "removeCookie" was returning "false"
in the case it couldn't be able to remove the cookie. But the only thing
it is doing is to stub the API and force returning false, there is no
real value on this test.
If you change the boolean return of "removeCookie", 2 tests fail anyway,
"removeCookie: when cookie does not exist" and "removeCookie: when
sucessfully deleted". All evidences points out this test is really
unnecessary and non-deterministic.
Also, this test relies in internal behavior for stubbing, future code
changes might require the modification of an unrelated test, which is
not ideal.1 parent 8b6ebc4 commit 50b0b08
1 file changed
+0
-20
lines changed| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
288 | 288 | | |
289 | 289 | | |
290 | 290 | | |
291 | | - | |
292 | | - | |
293 | | - | |
294 | | - | |
295 | | - | |
296 | | - | |
297 | | - | |
298 | | - | |
299 | | - | |
300 | | - | |
301 | | - | |
302 | | - | |
303 | | - | |
304 | | - | |
305 | | - | |
306 | | - | |
307 | | - | |
308 | | - | |
309 | | - | |
310 | | - | |
311 | 291 | | |
312 | 292 | | |
313 | 293 | | |
| |||
0 commit comments