File tree Expand file tree Collapse file tree 1 file changed +7
-7
lines changed
Expand file tree Collapse file tree 1 file changed +7
-7
lines changed Original file line number Diff line number Diff line change @@ -41,15 +41,15 @@ When reviewing code, here are some things we look for and also things we avoid:
4141
4242### Workflow
4343
44- * Authors should request review from riot-web team by default (if someone on the
45- team is clearly the expert in an area, a direct review request to them may be
46- more appropriate)
44+ * Authors should request review from the riot-web team by default (if someone on
45+ the team is clearly the expert in an area, a direct review request to them may
46+ be more appropriate)
4747* Reviewers should remove the team review request and request review from
4848 themselves when starting a review to avoid double review
49- * Authors should link to other layers of their PR in their PR before requesting
50- review. Reviewers might be coming from different places and could miss other
51- required PRs.
52- * Avoid force pushing to a PR after first round of review
49+ * If there are multiple related PRs authors should reference each of the PRs in
50+ the others before requesting review. Reviewers might start reviewing from
51+ different places and could miss other required PRs.
52+ * Avoid force pushing to a PR after the first round of review
5353* Use the GitHub default of merge commits when landing (avoid alternate options
5454 like squash or rebase)
5555* PR author merges after review (assuming they have write access)
You can’t perform that action at this time.
0 commit comments