Don't set tags on notifications

dbkr · bwindels · commit d0fcf3c95203 · 2018-10-19T16:47:16.000+02:00
They are to suppress notifications that don't want to be shown in addition to each other. This makes no sense for our notifications: they're each for independent messages. Also settings tags on notifications makes electron crash on windows when you close the notif, as per element-hq#7512
diff --git a/src/vector/platform/ElectronPlatform.js b/src/vector/platform/ElectronPlatform.js
@@ -143,7 +143,6 @@ export default class ElectronPlatform extends VectorBasePlatform {
             {
                 body: msg,
                 icon: avatarUrl,
-                tag: 'vector',
                 silent: true, // we play our own sounds
             },
         );
@@ -169,11 +168,6 @@ export default class ElectronPlatform extends VectorBasePlatform {
     }
 
     clearNotification(notif: Notification) {
-        // This crashes on windows under certain circumstances: can't find any
-        // workaround other than not closing notifs.
-        // https://github.com/electron/electron/issues/15251
-        // https://github.com/vector-im/riot-web/issues/7512
-        if (window.process.platform === 'win32') return;
         notif.close();
     }
 

Original file line number	Diff line number	Diff line change
`@@ -143,7 +143,6 @@ export default class ElectronPlatform extends VectorBasePlatform {`
`143`	`143`	`{`
`144`	`144`	`body: msg,`
`145`	`145`	`icon: avatarUrl,`
`146`		`- tag: 'vector',`
`147`	`146`	`silent: true, // we play our own sounds`
`148`	`147`	`},`
`149`	`148`	`);`
`@@ -169,11 +168,6 @@ export default class ElectronPlatform extends VectorBasePlatform {`
`169`	`168`	`}`
`170`	`169`
`171`	`170`	`clearNotification(notif: Notification) {`
`172`		`- // This crashes on windows under certain circumstances: can't find any`
`173`		`- // workaround other than not closing notifs.`
`174`		`- // https://github.com/electron/electron/issues/15251`
`175`		`- // https://github.com/vector-im/riot-web/issues/7512`
`176`		`- if (window.process.platform === 'win32') return;`
`177`	`171`	`notif.close();`
`178`	`172`	`}`
`179`	`173`