Skip to content

Commit 7232c01

Browse files
committed
Fix args in the release wrapper script
It was assuming the version was always $1 which meant there was no way to pass options (eg. -x to skip changelog generation) through to the underlying release script without breaking the wrapper script.
1 parent 864057e commit 7232c01

File tree

1 file changed

+10
-1
lines changed

1 file changed

+10
-1
lines changed

release.sh

Lines changed: 10 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -7,6 +7,15 @@
77

88
set -e
99

10+
orig_args=$@
11+
12+
# chomp any args starting with '-' as these need to go
13+
# through to the rleease script and otherwise we'll get
14+
# confused about what the version arg is.
15+
while [[ "$1" == -* ]]; do
16+
shift
17+
done
18+
1019
cd `dirname $0`
1120

1221
for i in matrix-js-sdk matrix-react-sdk
@@ -38,4 +47,4 @@ git commit package.json -m "$tag"
3847

3948
cd ..
4049

41-
exec ./node_modules/matrix-js-sdk/release.sh -z "$@"
50+
exec ./node_modules/matrix-js-sdk/release.sh -z "$orig_args"

0 commit comments

Comments
 (0)