Stop electron crashing

dbkr · dbkr · commit 231ca253f206 · 2018-10-18T18:31:06.000+01:00
Workaround temporarily by not closing notifs on win32 as per comment. Fixes element-hq#7512
diff --git a/src/vector/platform/ElectronPlatform.js b/src/vector/platform/ElectronPlatform.js
@@ -169,6 +169,11 @@ export default class ElectronPlatform extends VectorBasePlatform {
     }
 
     clearNotification(notif: Notification) {
+        // This crashes on windows under certain circumstances: can't find any
+        // workaround othet than not closing notifs.
+        // https://github.com/electron/electron/issues/15251
+        // https://github.com/vector-im/riot-web/issues/7512
+        if (window.process.platform === 'win32') return;
         notif.close();
     }
 

Original file line number	Diff line number	Diff line change
`@@ -169,6 +169,11 @@ export default class ElectronPlatform extends VectorBasePlatform {`
`169`	`169`	`}`
`170`	`170`
`171`	`171`	`clearNotification(notif: Notification) {`
	`172`	`+ // This crashes on windows under certain circumstances: can't find any`
	`173`	`+ // workaround othet than not closing notifs.`
	`174`	`+ // https://github.com/electron/electron/issues/15251`
	`175`	`+ // https://github.com/vector-im/riot-web/issues/7512`
	`176`	`+ if (window.process.platform === 'win32') return;`
`172`	`177`	`notif.close();`
`173`	`178`	`}`
`174`	`179`