Fixed a bug came out when solving issue commandlineparser#49.

gsscoder · gsscoder · commit 525d474547b7 · 2013-02-07T08:55:53.000+01:00
diff --git a/CommandLine.sln b/CommandLine.sln
@@ -1,6 +1,6 @@
 ﻿
-Microsoft Visual Studio Solution File, Format Version 12.00
-# Visual Studio 2012
+Microsoft Visual Studio Solution File, Format Version 11.00
+# Visual Studio 2010
 Project("{FAE04EC0-301F-11D3-BF4B-00C04F79EFBC}") = "CommandLine", "src\libcmdline\CommandLine.csproj", "{5DEA2811-2FFA-4959-830B-CAD3ACACABEB}"
 EndProject
 Project("{FAE04EC0-301F-11D3-BF4B-00C04F79EFBC}") = "CommandLine.Tests", "src\tests\CommandLine.Tests.csproj", "{86E1AC34-ED2D-4E42-8B95-65208FEA36C2}"
diff --git a/CommandLine.sln.DotSettings.user b/CommandLine.sln.DotSettings.user
diff --git a/README.md b/README.md
@@ -1,4 +1,4 @@
-Command Line Parser Library 1.9.4.209 beta for CLR.
+Command Line Parser Library 1.9.4.215 beta for CLR.
 ===
 The Command Line Parser Library offers to CLR applications a clean and concise API for manipulating command line arguments and related tasks defining switches, options and verb commands. It allows you to display an help screen with an high degree of customization and a simple way to report syntax errors to the end user. Everything that is boring and repetitive to be programmed stands up on library shoulders, letting developers concentrate on core logic.
 __The search for the command line parser for your application is over, with this library you got a solid parsing API constantly updated since 2005.__
diff --git a/Rakefile.rb b/Rakefile.rb
@@ -1,6 +1,6 @@
 PRODUCT = "Command Line Parser Library"
 DESCRIPTION = "Command Line Parser Library allows CLR applications to define a syntax for parsing command line arguments."
-VERSION = "1.9.4.209"
+VERSION = "1.9.4.215"
 INF_VERSION = VERSION + "-beta"
 COPYRIGHT = "Copyright (c) 2005 - 2013 Giacomo Stelluti Scala"
 LICENSE_URL = "https://raw.github.com/gsscoder/commandline/master/doc/LICENSE"
@@ -79,7 +79,7 @@ def invoke_runtime(cmd)
   a.version = a.file_version = VERSION
   a.copyright = COPYRIGHT
   a.custom_attributes :AssemblyInformationalVersion => INF_VERSION, :NeutralResourcesLanguage => "en-US"
-  a.output_file = "src/CommonAssemblyInfo.cs"
+  a.output_file = "src/SharedAssemblyInfo.cs"
   a.namespaces "System.Runtime.CompilerServices", "System.Resources"
 end
 
diff --git a/doc/ChangeLog b/doc/ChangeLog
@@ -1,3 +1,9 @@
+2013-02-06  Giacomo Stelluti Scala  <gsscoder@gmail.com>
+
+  * Solved an issue came out when solving https://github.com/gsscoder/commandline/issues/49
+      (see VerbsFixture.cs#172).
+  * Version incremented to 1.9.4.215 beta.
+
 2013-02-02  Giacomo Stelluti Scala  <gsscoder@gmail.com>
 
   * ParsingErrorsHandler delegate replaced by Action<HelpText>.
diff --git a/doc/README b/doc/README
@@ -3,8 +3,8 @@ Command Line Parser Library
 Project Author/Coordinator: Giacomo Stelluti Scala
 Main Contributor(s): Steven Evans, Kevin Moore, Dan Nemec (nemec), Alexander Fast (mizipzor)
 --------------------------------------------------------------------------------------------
-Version 1.9.4.209 beta (*1)
-Latest Update: 02-02-2013
+Version 1.9.4.215 beta (*1)
+Latest Update: 2013-02-06
 
 Git home:
 https://github.com/gsscoder/commandline
diff --git a/nuget/CommandLine.nuspec b/nuget/CommandLine.nuspec
@@ -1,7 +1,7 @@
 <?xml version="1.0"?>
 <package xmlns="http://schemas.microsoft.com/packaging/2011/08/nuspec.xsd">
   <metadata>
-    <version>1.9.4.209-beta</version>
+    <version>1.9.4.215-beta</version>
     <authors>Giacomo Stelluti Scala</authors>
     <owners>Giacomo Stelluti Scala</owners>
     <licenseUrl>https://github.com/gsscoder/commandline/blob/master/doc/LICENSE</licenseUrl>
diff --git a/src/SharedAssemblyInfo.cs b/src/SharedAssemblyInfo.cs
@@ -4,8 +4,8 @@
 using System.Runtime.InteropServices;
 [assembly: AssemblyProduct("Command Line Parser Library")]
 [assembly: AssemblyCopyright("Copyright (c) 2005 - 2013 Giacomo Stelluti Scala")]
-[assembly: AssemblyVersion("1.9.4.209")]
-[assembly: AssemblyFileVersion("1.9.4.209")]
+[assembly: AssemblyVersion("1.9.4.215")]
+[assembly: AssemblyFileVersion("1.9.4.215")]
 
-[assembly: AssemblyInformationalVersion("1.9.4.209-beta")]
+[assembly: AssemblyInformationalVersion("1.9.4.215-beta")]
 [assembly: NeutralResourcesLanguage("en-US")]
diff --git a/src/demo/CommandLine.Demo.csproj b/src/demo/CommandLine.Demo.csproj
@@ -34,14 +34,14 @@
     <Reference Include="System" />
   </ItemGroup>
   <ItemGroup>
+    <Compile Include="..\SharedAssemblyInfo.cs">
+      <Link>Properties\SharedAssemblyInfo.cs</Link>
+    </Compile>
     <Compile Include="Program.cs" />
     <Compile Include="Properties\AssemblyInfo.cs" />
     <Compile Include="Program.Options.cs">
       <DependentUpon>Program.cs</DependentUpon>
     </Compile>
-    <Compile Include="..\CommonAssemblyInfo.cs">
-      <Link>Properties\CommonAssemblyInfo.cs</Link>
-    </Compile>
   </ItemGroup>
   <ItemGroup>
     <ProjectReference Include="..\libcmdline\CommandLine.csproj">
diff --git a/src/libcmdline/CommandLine.csproj b/src/libcmdline/CommandLine.csproj
@@ -72,6 +72,9 @@
     <Reference Include="System" />
   </ItemGroup>
   <ItemGroup>
+    <Compile Include="..\SharedAssemblyInfo.cs">
+      <Link>Properties\SharedAssemblyInfo.cs</Link>
+    </Compile>
     <Compile Include="Attributes\BaseOptionAttribute.cs" />
     <Compile Include="Attributes\OptionAttribute.cs" />
     <Compile Include="Attributes\OptionArrayAttribute.cs" />
@@ -123,9 +126,6 @@
     <Compile Include="IParserState.cs" />
     <Compile Include="ParserState.cs" />
     <Compile Include="ParsingError.cs" />
-    <Compile Include="..\CommonAssemblyInfo.cs">
-      <Link>Properties\CommonAssemblyInfo.cs</Link>
-    </Compile>
     <Compile Include="Extensions\TargetExtensions.cs" />
   </ItemGroup>
   <Import Project="$(MSBuildBinPath)\Microsoft.CSharp.targets" />
diff --git a/src/libcmdline/CommandLine.sln.DotSettings.user b/src/libcmdline/CommandLine.sln.DotSettings.user
diff --git a/src/libcmdline/Parser.cs b/src/libcmdline/Parser.cs
@@ -319,7 +319,7 @@ private bool DoParseArgumentsVerbs(ParserContext context)
                 verbOption.CreateInstance(context.Target);
             }
             var verbResult = DoParseArgumentsCore(context.ToCoreInstance(verbOption));
-            if (!verbResult)
+            if (!verbResult && helpInfo != null)
             {
                 // Particular verb parsing failed, we try to print its help
                 DisplayHelpVerbText(context.Target, helpInfo, context.FirstArgument);
diff --git a/src/tests/CommandLine.Tests.csproj b/src/tests/CommandLine.Tests.csproj
@@ -47,6 +47,9 @@
     </Reference>
   </ItemGroup>
   <ItemGroup>
+    <Compile Include="..\SharedAssemblyInfo.cs">
+      <Link>Properties\SharedAssemblyInfo.cs</Link>
+    </Compile>
     <Compile Include="Attributes\AttributesFixture.cs" />
     <Compile Include="Attributes\HelpOptionAttributeFixture.cs" />
     <Compile Include="Attributes\ValueListAttributeFixture.cs" />
@@ -101,9 +104,6 @@
     <Compile Include="Mocks\SimpleOptionsForAutoBuid.cs" />
     <Compile Include="Mocks\OptionsForPlugInScenario.cs" />
     <Compile Include="Mocks\OptionsWithUIntArray.cs" />
-    <Compile Include="..\CommonAssemblyInfo.cs">
-      <Link>Properties\CommonAssemblyInfo.cs</Link>
-    </Compile>
     <Compile Include="Text\CopyrightInfoFixture.cs" />
     <Compile Include="Text\HeadingInfoFixture.cs" />
     <Compile Include="Text\HelpTextFixture.cs" />
diff --git a/src/tests/Mocks/OptionsWithVerbs.cs b/src/tests/Mocks/OptionsWithVerbs.cs
@@ -120,4 +120,16 @@ public OptionsWithVerbsNoHelp()
         [VerbOption("clone", HelpText = "Clone a repository into a new directory.")]
         public CloneSubOptions CloneVerb { get; set; }
     }
+
+    class WithRequiredSubOptions
+    {
+        [Option('m', "must", Required = true)]
+        public string RequiredOption { get; set; }
+    }
+
+    class OptionsWithVerbsNoHelp2 : OptionsWithVerbsNoHelp
+    {
+        [VerbOption("with")]
+        public WithRequiredSubOptions WithRequired { get; set; }
+    }
 }
diff --git a/src/tests/Parser/VerbsFixture.cs b/src/tests/Parser/VerbsFixture.cs
@@ -168,6 +168,20 @@ public void Was_verb_option_invoked_returns_false_with_ordinary_options()
             parser.WasVerbOptionInvoked("--amend").Should().BeFalse();
             parser.WasVerbOptionInvoked("-a").Should().BeFalse();
         }
+
+        /// <summary>
+        /// Issue came out when solving https://github.com/gsscoder/commandline/issues/49.
+        /// </summary>
+        [Fact]
+        public void Should_fail_gracefully_when_no_getusage_is_defined()
+        {
+            var options = new OptionsWithVerbsNoHelp2();
+
+            var parser = new Parser();
+            var result = parser.ParseArguments(new[] {"with", "--must"}, options);
+
+            result.Should().BeFalse();
+        }
     }
 }
 

Original file line number	Diff line number	Diff line change
`@@ -1,4 +1,4 @@`
`1`		`-Command Line Parser Library 1.9.4.209 beta for CLR.`
	`1`	`+Command Line Parser Library 1.9.4.215 beta for CLR.`
`2`	`2`	`===`
`3`	`3`	`The Command Line Parser Library offers to CLR applications a clean and concise API for manipulating command line arguments and related tasks defining switches, options and verb commands. It allows you to display an help screen with an high degree of customization and a simple way to report syntax errors to the end user. Everything that is boring and repetitive to be programmed stands up on library shoulders, letting developers concentrate on core logic.`
`4`	`4`	`__The search for the command line parser for your application is over, with this library you got a solid parsing API constantly updated since 2005.__`