Skip to content

Commit 1a3a3dd

Browse files
staakystaaky
committed
Fixed viewport calculation for Firefox on Android
1 parent b77db44 commit 1a3a3dd

5 files changed

Lines changed: 14 additions & 8 deletions

File tree

‎bower.json‎

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,7 +1,7 @@
11
{
22
"name": "strip",
33
"description": "A Less Intrusive Responsive Lightbox",
4-
"version": "1.5.4",
4+
"version": "1.5.5",
55
"homepage": "http://stripjs.com",
66
"keywords": [
77
"lightbox",

‎dist/js/strip.pkgd.js‎

Lines changed: 5 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -176,14 +176,17 @@ Support.mobileTouch = Support.touch &&
176176
var Bounds = {
177177
viewport: function() {
178178
var dimensions = {
179-
height: $(window).height(),
180179
width: $(window).width()
181180
};
182181

183182
// Mobile Safari has a bugged viewport height after scrolling
184-
if (Browser.MobileSafari) {
183+
// Firefox on Android also has problems with height
184+
if (Browser.MobileSafari || (Browser.Android && Browser.Gecko)) {
185185
var zoom = document.documentElement.clientWidth / window.innerWidth;
186186
dimensions.height = window.innerHeight * zoom;
187+
} else {
188+
// default
189+
dimensions.height = $(window).height();
187190
}
188191

189192
return dimensions;

‎dist/js/strip.pkgd.min.js‎

Lines changed: 2 additions & 2 deletions
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

‎package.json‎

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,7 +1,7 @@
11
{
22
"name": "strip",
33
"title": "Strip",
4-
"version": "1.5.4",
4+
"version": "1.5.5",
55
"description": "A Less Intrusive Responsive Lightbox",
66
"homepage": "http://stripjs.com",
77
"author": {

‎src/js/helpers/bounds.js‎

Lines changed: 5 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -1,14 +1,17 @@
11
var Bounds = {
22
viewport: function() {
33
var dimensions = {
4-
height: $(window).height(),
54
width: $(window).width()
65
};
76

87
// Mobile Safari has a bugged viewport height after scrolling
9-
if (Browser.MobileSafari) {
8+
// Firefox on Android also has problems with height
9+
if (Browser.MobileSafari || (Browser.Android && Browser.Gecko)) {
1010
var zoom = document.documentElement.clientWidth / window.innerWidth;
1111
dimensions.height = window.innerHeight * zoom;
12+
} else {
13+
// default
14+
dimensions.height = $(window).height();
1215
}
1316

1417
return dimensions;

0 commit comments

Comments
 (0)