Skip to content

Commit cea3005

Browse files
committed
Fix invalid selector exception with empty class values
After removing :before and :after pseudo selectors, a class name may be empty, causing an invalid selector string when joined. Remove empty elements before calling querySelectorAll.
1 parent 1d4b175 commit cea3005

1 file changed

Lines changed: 4 additions & 1 deletion

File tree

src/Parse.js

Lines changed: 4 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -77,6 +77,9 @@ _html2canvas.Parse = function (images, options, cb) {
7777
for (i = 0, j = classes.length; i < j; i++) {
7878
classes[i] = classes[i].match(/(^[^:]*)/)[1];
7979
}
80+
81+
// remove empty values, if not could cause invalid selectors with querySelectorAll
82+
classes = classes.filter(function (n) { return n });
8083
}
8184

8285
// Using the list of elements we know how pseudo el styles, create fake pseudo elements.
@@ -1273,4 +1276,4 @@ _html2canvas.Parse = function (images, options, cb) {
12731276
}
12741277
}
12751278
}
1276-
};
1279+
};

0 commit comments

Comments
 (0)