Skip to content

Commit c3e9636

Browse files
committed
Moved renderer logic to renderer.js
1 parent 816ff6d commit c3e9636

2 files changed

Lines changed: 18 additions & 18 deletions

File tree

src/Renderer.js

Lines changed: 13 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -1,5 +1,5 @@
11
_html2canvas.Renderer = function(parseQueue, options){
2-
var queue = [];
2+
var queue = [], renderer;
33

44
function sortZ(zStack){
55
var subStacks = [],
@@ -47,11 +47,20 @@ _html2canvas.Renderer = function(parseQueue, options){
4747

4848
}
4949

50-
5150
sortZ(parseQueue.zIndex);
52-
if ( typeof options._renderer._create !== "function" ) {
51+
52+
if (typeof options.renderer === "string" && _html2canvas.Renderer[options.renderer] !== undefined) {
53+
renderer = _html2canvas.Renderer[options.renderer](options);
54+
} else if (typeof options.renderer === "function") {
55+
renderer = options.renderer(options);
56+
} else {
57+
throw new Error("Unknown renderer");
58+
}
59+
60+
if ( typeof renderer._create !== "function" ) {
5361
throw new Error("Invalid renderer defined");
5462
}
55-
return options._renderer._create( parseQueue, options, document, queue, _html2canvas );
63+
64+
return renderer._create( parseQueue, options, document, queue, _html2canvas );
5665

5766
};

src/Util.js

Lines changed: 5 additions & 14 deletions
Original file line numberDiff line numberDiff line change
@@ -1,5 +1,4 @@
1-
html2canvas = function( elements, opts ) {
2-
1+
window.html2canvas = function(elements, opts) {
32
var queue,
43
canvas,
54
options = {
@@ -8,7 +7,7 @@ html2canvas = function( elements, opts ) {
87
elements: elements,
98

109
// preload options
11-
proxy: "http://html2canvas.appspot.com/",
10+
proxy: "",
1211
timeout: 0, // no timeout
1312
useCORS: false, // try to load images as CORS (where available), before falling back to proxy
1413
allowTaint: false, // whether to allow images to taint the canvas, won't need proxy if set to true
@@ -27,18 +26,10 @@ html2canvas = function( elements, opts ) {
2726
height: null,
2827
taintTest: true, // do a taint test with all images before applying to canvas
2928
renderer: "Canvas"
30-
}, renderer;
29+
};
3130

3231
options = _html2canvas.Util.Extend(opts, options);
3332

34-
if (typeof options.renderer === "string" && _html2canvas.Renderer[options.renderer] !== undefined) {
35-
options._renderer = _html2canvas.Renderer[options.renderer]( options );
36-
} else if (typeof options.renderer === "function") {
37-
options._renderer = options.renderer( options );
38-
} else {
39-
throw("Unknown renderer");
40-
}
41-
4233
_html2canvas.logging = options.logging;
4334
options.complete = function( images ) {
4435

@@ -83,7 +74,7 @@ html2canvas = function( elements, opts ) {
8374
};
8475
};
8576

86-
html2canvas.log = h2clog; // for renderers
87-
html2canvas.Renderer = {
77+
window.html2canvas.log = h2clog; // for renderers
78+
window.html2canvas.Renderer = {
8879
Canvas: undefined // We are assuming this will be used
8980
};

0 commit comments

Comments
 (0)