Skip to content

Commit 938e488

Browse files
ritz078ritz078
committed
Merge pull request ritz078#168 from ritz078/fix/string
fix(string): fixed addEventlistener of undefined when input is string
2 parents f0b9844 + 73924ba commit 938e488

7 files changed

Lines changed: 28 additions & 16 deletions

File tree

‎dist/embed.min.js‎

Lines changed: 2 additions & 2 deletions
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

‎src/embed.es2015.js‎

Lines changed: 8 additions & 4 deletions
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

‎src/embed.es2015.js.map‎

Lines changed: 1 addition & 1 deletion
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

‎src/embed.js‎

Lines changed: 8 additions & 4 deletions
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

‎src/embed.js.map‎

Lines changed: 1 addition & 1 deletion
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

‎src/js/modules/code/gist.js‎

Lines changed: 5 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -10,9 +10,11 @@ export default class Gist {
1010
this.regex = regex.gist;
1111
this.service = 'gist';
1212

13-
this.options.input.addEventListener('rendered', () => {
14-
this.load()
15-
})
13+
if(typeof this.options.input !== 'string'){
14+
this.options.input.addEventListener('rendered', () => {
15+
this.load()
16+
})
17+
}
1618
}
1719

1820
template(match) {

‎src/js/modules/twitter/twitter.js‎

Lines changed: 3 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -12,7 +12,9 @@ export default class Twitter {
1212
this.service = 'twitter';
1313

1414
this.load = this.load.bind(this);
15-
this.options.input.addEventListener('rendered', this.load, false);
15+
if(typeof this.options.input !== 'string'){
16+
this.options.input.addEventListener('rendered', this.load, false);
17+
}
1618
}
1719

1820
/**

0 commit comments

Comments
 (0)