Skip to content

Commit 766d3ae

Browse files
ritz078ritz078
committed
fix(destroy): now it works as expected
1 parent acb2e3f commit 766d3ae

6 files changed

Lines changed: 6 additions & 6 deletions

File tree

‎dist/embed.min.js‎

Lines changed: 1 addition & 1 deletion
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

‎src/embed.es2015.js‎

Lines changed: 1 addition & 1 deletion
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

‎src/embed.es2015.js.map‎

Lines changed: 1 addition & 1 deletion
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

‎src/embed.js‎

Lines changed: 1 addition & 1 deletion
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

‎src/embed.js.map‎

Lines changed: 1 addition & 1 deletion
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

‎src/js/main.js‎

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -341,7 +341,7 @@ export default class EmbedJS {
341341
* @return {null}
342342
*/
343343
destroy() {
344-
if (!this.element) throw new Error(`destroy() method only if an element had been passed in the options object`);
344+
if (this.options.input !== 'object') throw new Error(`destroy() method only works if an element had been passed in the options object`);
345345
destroyVideos('ejs-video-thumb');
346346
this.element.removeEventListener('rendered', this.twitter.load(), false);
347347
this.element.innerHTML = this.input

0 commit comments

Comments
 (0)