Skip to content

Commit be85713

Browse files
mbostockmbostock
committed
Fix bug in classed operator.
Need to reset the `lastIndex` attribute of the regular expression to 0.
1 parent 2bdf55c commit be85713

4 files changed

Lines changed: 13 additions & 9 deletions

File tree

‎d3.js‎

Lines changed: 3 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,4 +1,4 @@
1-
d3 = {version: "0.28.0"}; // semver
1+
d3 = {version: "0.28.1"}; // semver
22
if (!Date.now) Date.now = function() {
33
return +new Date();
44
};
@@ -1097,13 +1097,15 @@ function d3_selection(groups) {
10971097
// If no value is specified, return the first value.
10981098
if (arguments.length < 2) {
10991099
return first(function() {
1100+
re.lastIndex = 0;
11001101
return re.test(this.className);
11011102
});
11021103
}
11031104

11041105
/** @this {Element} */
11051106
function classedAdd() {
11061107
var classes = this.className;
1108+
re.lastIndex = 0;
11071109
if (!re.test(classes)) {
11081110
this.className = d3_collapse(classes + " " + name);
11091111
}

‎d3.min.js‎

Lines changed: 7 additions & 7 deletions
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

‎src/core/core.js‎

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1 +1 @@
1-
d3 = {version: "0.28.0"}; // semver
1+
d3 = {version: "0.28.1"}; // semver

‎src/core/selection.js‎

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -298,13 +298,15 @@ function d3_selection(groups) {
298298
// If no value is specified, return the first value.
299299
if (arguments.length < 2) {
300300
return first(function() {
301+
re.lastIndex = 0;
301302
return re.test(this.className);
302303
});
303304
}
304305

305306
/** @this {Element} */
306307
function classedAdd() {
307308
var classes = this.className;
309+
re.lastIndex = 0;
308310
if (!re.test(classes)) {
309311
this.className = d3_collapse(classes + " " + name);
310312
}

0 commit comments

Comments
 (0)