Skip to content

Commit 559394b

Browse files
mbostockmbostock
committed
Better tests for svg.arc.
This also fixes a bug when start and end angle are inverted.
1 parent 97db780 commit 559394b

5 files changed

Lines changed: 135 additions & 16 deletions

File tree

‎d3.geom.min.js‎

Lines changed: 1 addition & 1 deletion
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

‎d3.js‎

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -2678,7 +2678,7 @@ d3.svg.arc = function() {
26782678
r1 = outerRadius.apply(this, arguments),
26792679
a0 = startAngle.apply(this, arguments) + d3_svg_arcOffset,
26802680
a1 = endAngle.apply(this, arguments) + d3_svg_arcOffset,
2681-
da = a1 - a0,
2681+
da = (a1 < a0 && (da = a0, a0 = a1, a1 = da), a1 - a0),
26822682
df = da < Math.PI ? "0" : "1",
26832683
c0 = Math.cos(a0),
26842684
s0 = Math.sin(a0),

‎d3.min.js‎

Lines changed: 2 additions & 2 deletions
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

‎src/svg/arc.js‎

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -9,7 +9,7 @@ d3.svg.arc = function() {
99
r1 = outerRadius.apply(this, arguments),
1010
a0 = startAngle.apply(this, arguments) + d3_svg_arcOffset,
1111
a1 = endAngle.apply(this, arguments) + d3_svg_arcOffset,
12-
da = a1 - a0,
12+
da = (a1 < a0 && (da = a0, a0 = a1, a1 = da), a1 - a0),
1313
df = da < Math.PI ? "0" : "1",
1414
c0 = Math.cos(a0),
1515
s0 = Math.sin(a0),

0 commit comments

Comments
 (0)