Skip to content

Commit b5cdaa0

Browse files
clarketmclarketm
committed
changed MIME to application/csv to work with Excel
1 parent 7f74981 commit b5cdaa0

8 files changed

Lines changed: 33 additions & 36 deletions

File tree

‎dist/css/tableexport.css‎

100644100755
File mode changed.

‎dist/css/tableexport.min.css‎

100644100755
File mode changed.

‎dist/js/tableexport.js‎

Lines changed: 10 additions & 11 deletions
Original file line numberDiff line numberDiff line change
@@ -74,16 +74,15 @@
7474
createObjButton(dataObject, name, myContent, myClass);
7575
},
7676
csv: function (rdel, name) {
77-
rdel = '"' + rdel + '"';
78-
var colD = '"' + $.fn.tableExport.csv.separator + '"',
79-
dataURL = '"' + $rows.map(function (i, val) {
80-
if (!!~ignoreRows.indexOf(i-thAdj)) { return;}
81-
var $cols = $(val).find('th, td');
82-
return $cols.map(function (i, val) {
83-
if (!!~ignoreCols.indexOf(i)) { return;}
84-
return $(val).text().replace(/"/g, '""');
85-
}).get().join(colD);
86-
}).get().join(rdel) + '"',
77+
var colD = $.fn.tableExport.csv.separator,
78+
dataURL = $rows.map(function (i, val) {
79+
if (!!~ignoreRows.indexOf(i-thAdj)) { return;}
80+
var $cols = $(val).find('th, td');
81+
return $cols.map(function (i, val) {
82+
if (!!~ignoreCols.indexOf(i)) { return;}
83+
return $(val).text();
84+
}).get().join(colD);
85+
}).get().join(rdel),
8786
dataObject = escapeHtml(
8887
JSON.stringify({
8988
data: dataURL,
@@ -185,7 +184,7 @@
185184
defaultClass: "csv",
186185
buttonContent: "Export to csv",
187186
separator: ",",
188-
mimeType: "text/csv",
187+
mimeType: "application/csv",
189188
fileExtension: ".csv"
190189
};
191190

‎dist/js/tableexport.min.js‎

Lines changed: 1 addition & 1 deletion
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

‎src/stable/js/tableexport.js‎

Lines changed: 10 additions & 11 deletions
Original file line numberDiff line numberDiff line change
@@ -74,16 +74,15 @@
7474
createObjButton(dataObject, name, myContent, myClass);
7575
},
7676
csv: function (rdel, name) {
77-
rdel = '"' + rdel + '"';
78-
var colD = '"' + $.fn.tableExport.csv.separator + '"',
79-
dataURL = '"' + $rows.map(function (i, val) {
80-
if (!!~ignoreRows.indexOf(i-thAdj)) { return;}
81-
var $cols = $(val).find('th, td');
82-
return $cols.map(function (i, val) {
83-
if (!!~ignoreCols.indexOf(i)) { return;}
84-
return $(val).text().replace(/"/g, '""');
85-
}).get().join(colD);
86-
}).get().join(rdel) + '"',
77+
var colD = $.fn.tableExport.csv.separator,
78+
dataURL = $rows.map(function (i, val) {
79+
if (!!~ignoreRows.indexOf(i-thAdj)) { return;}
80+
var $cols = $(val).find('th, td');
81+
return $cols.map(function (i, val) {
82+
if (!!~ignoreCols.indexOf(i)) { return;}
83+
return $(val).text();
84+
}).get().join(colD);
85+
}).get().join(rdel),
8786
dataObject = escapeHtml(
8887
JSON.stringify({
8988
data: dataURL,
@@ -185,7 +184,7 @@
185184
defaultClass: "csv",
186185
buttonContent: "Export to csv",
187186
separator: ",",
188-
mimeType: "text/csv",
187+
mimeType: "application/csv",
189188
fileExtension: ".csv"
190189
};
191190

0 commit comments

Comments
 (0)