8209456: [error-prone] ShortCircuitBoolean in java.logging

iignatev · iignatev · commit 65f4c7dee44d · 2018-08-19T22:41:49.000-07:00
Reviewed-by: rriggs
diff --git a/src/java.logging/share/classes/java/util/logging/Formatter.java b/src/java.logging/share/classes/java/util/logging/Formatter.java
@@ -137,7 +137,7 @@ public String formatMessage(LogRecord record) {
             while ((index = format.indexOf('{', index+1)) > -1) {
                 if (index >= fence) break;
                 char digit = format.charAt(index+1);
-                if (digit >= '0' & digit <= '9') {
+                if (digit >= '0' && digit <= '9') {
                    return java.text.MessageFormat.format(format, parameters);
                 }
             }

Original file line number	Diff line number	Diff line change
`@@ -137,7 +137,7 @@ public String formatMessage(LogRecord record) {`
`137`	`137`	`while ((index = format.indexOf('{', index+1)) > -1) {`
`138`	`138`	`if (index >= fence) break;`
`139`	`139`	`char digit = format.charAt(index+1);`
`140`		`- if (digit >= '0' & digit <= '9') {`
	`140`	`+ if (digit >= '0' && digit <= '9') {`
`141`	`141`	`return java.text.MessageFormat.format(format, parameters);`
`142`	`142`	`}`
`143`	`143`	`}`