8249801: Shenandoah: Clear soft-refs on requested GC cycle

rkennke · rkennke · commit 006d0bcec1bf · 2020-07-21T17:27:44.000+02:00
Reviewed-by: shade
diff --git a/src/hotspot/share/gc/shenandoah/shenandoahControlThread.cpp b/src/hotspot/share/gc/shenandoah/shenandoahControlThread.cpp
@@ -174,8 +174,8 @@ void ShenandoahControlThread::run_service() {
     }
 
     // Blow all soft references on this cycle, if handling allocation failure,
-    // or we are requested to do so unconditionally.
-    if (alloc_failure_pending || ShenandoahAlwaysClearSoftRefs) {
+    // either implicit or explicit GC request,  or we are requested to do so unconditionally.
+    if (alloc_failure_pending || implicit_gc_requested || explicit_gc_requested || ShenandoahAlwaysClearSoftRefs) {
       heap->soft_ref_policy()->set_should_clear_all_soft_refs(true);
     }
 

Original file line number	Diff line number	Diff line change
`@@ -174,8 +174,8 @@ void ShenandoahControlThread::run_service() {`
`174`	`174`	`}`
`175`	`175`
`176`	`176`	`// Blow all soft references on this cycle, if handling allocation failure,`
`177`		`- // or we are requested to do so unconditionally.`
`178`		`- if (alloc_failure_pending \|\| ShenandoahAlwaysClearSoftRefs) {`
	`177`	`+ // either implicit or explicit GC request, or we are requested to do so unconditionally.`
	`178`	`+ if (alloc_failure_pending \|\| implicit_gc_requested \|\| explicit_gc_requested \|\| ShenandoahAlwaysClearSoftRefs) {`
`179`	`179`	`heap->soft_ref_policy()->set_should_clear_all_soft_refs(true);`
`180`	`180`	`}`
`181`	`181`