fix parseInt of '0'

kripken · kripken · commit a16fb0dcb7dc · 2012-12-30T12:48:50.000-08:00
diff --git a/src/library.js b/src/library.js
@@ -3852,6 +3852,7 @@ LibraryManager.library = {
     }
 
     // Find base.
+    var ok = false;
     var finalBase = base;
     if (!finalBase) {
       if ({{{ makeGetValue('str', 0, 'i8') }}} == '0'.charCodeAt(0)) {
@@ -3862,21 +3863,21 @@ LibraryManager.library = {
         } else {
           finalBase = 8;
           str++;
+          ok = true; // we saw an initial zero, perhaps the entire thing is just "0"
         }
       }
     }
     if (!finalBase) finalBase = 10;
 
     // Get digits.
     var chr;
-    var ok = false;
     while ((chr = {{{ makeGetValue('str', 0, 'i8') }}}) != 0) {
       var digit = parseInt(String.fromCharCode(chr), finalBase);
       if (isNaN(digit)) {
         break;
       } else {
-        ok = true;
         str++;
+        ok = true;
       }
     }
     if (!ok) {

Original file line number	Diff line number	Diff line change
`@@ -3852,6 +3852,7 @@ LibraryManager.library = {`
`3852`	`3852`	`}`
`3853`	`3853`
`3854`	`3854`	`// Find base.`
	`3855`	`+ var ok = false;`
`3855`	`3856`	`var finalBase = base;`
`3856`	`3857`	`if (!finalBase) {`
`3857`	`3858`	`if ({{{ makeGetValue('str', 0, 'i8') }}} == '0'.charCodeAt(0)) {`
`@@ -3862,21 +3863,21 @@ LibraryManager.library = {`
`3862`	`3863`	`} else {`
`3863`	`3864`	`finalBase = 8;`
`3864`	`3865`	`str++;`
	`3866`	`+ ok = true; // we saw an initial zero, perhaps the entire thing is just "0"`
`3865`	`3867`	`}`
`3866`	`3868`	`}`
`3867`	`3869`	`}`
`3868`	`3870`	`if (!finalBase) finalBase = 10;`
`3869`	`3871`
`3870`	`3872`	`// Get digits.`
`3871`	`3873`	`var chr;`
`3872`		`- var ok = false;`
`3873`	`3874`	`while ((chr = {{{ makeGetValue('str', 0, 'i8') }}}) != 0) {`
`3874`	`3875`	`var digit = parseInt(String.fromCharCode(chr), finalBase);`
`3875`	`3876`	`if (isNaN(digit)) {`
`3876`	`3877`	`break;`
`3877`	`3878`	`} else {`
`3878`		`- ok = true;`
`3879`	`3879`	`str++;`
	`3880`	`+ ok = true;`
`3880`	`3881`	`}`
`3881`	`3882`	`}`
`3882`	`3883`	`if (!ok) {`