Handle -s alias for for --strip-all linker flag (emscripten-core#20875)

sbc100 · web-flow · commit 8ec81326ab88 · 2023-12-07T14:36:39.000-08:00
diff --git a/test/test_other.py b/test/test_other.py
@@ -14224,6 +14224,7 @@ def test_strip_all(self):
     # Test that even with `-Wl,--strip-all` the target features section is generated
     # by wasm-ld so that later phases (e.g. wasm-opt) can read it.
     self.do_runf('hello_world.c', emcc_args=['-Wl,--strip-all', '-pthread'])
+    self.do_runf('hello_world.c', emcc_args=['-Wl,-s', '-pthread'])
 
   def test_embind_no_duplicate_symbols(self):
     # Embind implementation lives almost entirely in headers, which have special rules
diff --git a/tools/building.py b/tools/building.py
@@ -270,8 +270,8 @@ def link_lld(args, target, external_symbols=None):
   if settings.STRICT:
     args.append('--fatal-warnings')
 
-  if '--strip-all' in args:
-    # Tell wasm-ld to always generate a target_features section even if --strip-all
+  if any(a in args for a in ('--strip-all', '-s')):
+    # Tell wasm-ld to always generate a target_features section even if --strip-all/-s
     # is passed.
     args.append('--keep-section=target_features')
 
