fix parseInt64

kripken · kripken · commit 5edd66f9c9d4 · 2012-12-31T12:23:09.000-08:00
diff --git a/src/library.js b/src/library.js
@@ -3885,23 +3885,21 @@ LibraryManager.library = {
     }
     if (!ok) {
       ___setErrNo(ERRNO_CODES.EINVAL);
-      return [0, 0];
-    }
-
-    try {
-      i64Math.fromString(Pointer_stringify(start, str - start), finalBase, min, max, unsign);
-    } catch(e) {
-      ___setErrNo(ERRNO_CODES.ERANGE); // not quite correct
+      {{{ makeStructuralReturn(['0', '0']) }}};
     }
 
     // Set end pointer.
     if (endptr) {
       {{{ makeSetValue('endptr', 0, 'str', '*') }}}
     }
 
-    var ret = i64Math.result.slice(0);
+    try {
+      i64Math.fromString(Pointer_stringify(start, str - start), finalBase, min, max, unsign);
+    } catch(e) {
+      ___setErrNo(ERRNO_CODES.ERANGE); // not quite correct
+    }
 
-    return ret;
+    {{{ makeStructuralReturn([makeGetTempDouble(0), makeGetTempDouble(1)]) }}};
   },
 #endif
   strtoll__deps: ['_parseInt64'],
diff --git a/src/long.js b/src/long.js
@@ -1649,8 +1649,8 @@ var i64Math = (function() { // Emscripten wrapper
         error = true;
       }
       var ret = goog.math.Long.fromString(bignum.toString()); // min-max checks should have clamped this to a range goog.math.Long can handle well
-      Wrapper.result[0] = ret.low_;
-      Wrapper.result[1] = ret.high_;
+      HEAP32[tempDoublePtr>>2] = ret.low_;
+      HEAP32[tempDoublePtr+4>>2] = ret.high_;
       if (error) throw 'range error';
     }
   };
diff --git a/src/parseTools.js b/src/parseTools.js
@@ -1011,7 +1011,7 @@ function asmCoercion(value, type) {
   }
 }
 
-function makeGetTempDouble(i) {
+function makeGetTempDouble(i) { // TODO: Support other than i32
   return makeGetValue('tempDoublePtr', Runtime.getNativeTypeSize('i32')*i, 'i32');
 }
 

Original file line number	Diff line number	Diff line change
`@@ -1649,8 +1649,8 @@ var i64Math = (function() { // Emscripten wrapper`
`1649`	`1649`	`error = true;`
`1650`	`1650`	`}`
`1651`	`1651`	`var ret = goog.math.Long.fromString(bignum.toString()); // min-max checks should have clamped this to a range goog.math.Long can handle well`
`1652`		`- Wrapper.result[0] = ret.low_;`
`1653`		`- Wrapper.result[1] = ret.high_;`
	`1652`	`+ HEAP32[tempDoublePtr>>2] = ret.low_;`
	`1653`	`+ HEAP32[tempDoublePtr+4>>2] = ret.high_;`
`1654`	`1654`	`if (error) throw 'range error';`
`1655`	`1655`	`}`
`1656`	`1656`	`};`
Original file line number	Diff line number	Diff line change
`@@ -1011,7 +1011,7 @@ function asmCoercion(value, type) {`
`1011`	`1011`	`}`
`1012`	`1012`	`}`
`1013`	`1013`
`1014`		`-function makeGetTempDouble(i) {`
	`1014`	`+function makeGetTempDouble(i) { // TODO: Support other than i32`
`1015`	`1015`	`return makeGetValue('tempDoublePtr', Runtime.getNativeTypeSize('i32')*i, 'i32');`
`1016`	`1016`	`}`
`1017`	`1017`