downgrade a few XXX, add a few genuine FIXMEs

svaarala · svaarala · commit f9dc55d4321c · 2014-03-14T22:50:45.000+02:00
diff --git a/examples/eventloop/ecma_eventloop.js b/examples/eventloop/ecma_eventloop.js
@@ -290,7 +290,7 @@ EventLoop.run = function() {
                 if (cb) {
                     data = Socket.read(fd);  // no size control now
                     //print('READ', Duktape.enc('jsonx', data));
-                    if (String(data) === '') {
+                    if (String(data) === '') {  // FIXME
                         //print('zero read for fd ' + fd + ', closing forcibly');
                         rc = Socket.close(fd);  // ignore result
                         delete this.socketListening[fd];
diff --git a/examples/eventloop/main.c b/examples/eventloop/main.c
@@ -36,8 +36,8 @@ static void set_sigint_handler(void) {
 /* Print error to stderr and pop error. */
 static void print_error(duk_context *ctx, FILE *f) {
 	if (duk_is_object(ctx, -1) && duk_has_prop_string(ctx, -1, "stack")) {
-		/* FIXME: print error objects specially */
-		/* FIXME: pcall the string coercion */
+		/* XXX: print error objects specially */
+		/* XXX: pcall the string coercion */
 		duk_get_prop_string(ctx, -1, "stack");
 		if (duk_is_string(ctx, -1)) {
 			fprintf(f, "%s\n", duk_get_string(ctx, -1));
diff --git a/examples/eventloop/poll.c b/examples/eventloop/poll.c
@@ -61,7 +61,6 @@ static int poll_poll(duk_context *ctx) {
 		/* update revents */
 
 		if (fds[i].revents) {
-			/* FIXME: need an duk_array_push */
 			duk_push_int(ctx, fds[i].fd);  /* -> [... retarr fd] */
 			duk_put_prop_index(ctx, -2, nchanged);
 			nchanged++;
diff --git a/examples/eventloop/server-socket-test.js b/examples/eventloop/server-socket-test.js
@@ -13,6 +13,7 @@ print('listen on ' + HOST + ':' + PORT);
 EventLoop.server(HOST, PORT, function (fd, addr, port) {
     print('new connection on fd ' + fd + ' from ' + addr + ':' + port);
     EventLoop.setReader(fd, function (fd, data) {
+        // FIXME: uppercase as bytes, no decode errors
         print('read data on fd ' + fd + ', length ' + data.length);
         EventLoop.write(fd, String(data).toUpperCase());
     });
