Skip to content

Commit 6d44be2

Browse files
svaaralasvaarala
committed
Resolve FIXMEs in config-options, other cleanups
* Remove DUK_USE_USER_DECLARE which hasn't been necessary since Duktape 2.0. Add release note for removal. * Downgrade or remove FIXMEs in config-options. * Remove config/other-defines YAML files; they were out of date and didn't really have a good use case. * Fix Ecmascript -> ECMAScript spelling in feature and config options. Also a few instances in debugger and cmdline example.
1 parent 712b3b9 commit 6d44be2

61 files changed

Lines changed: 59 additions & 356 deletions

File tree

Some content is hidden

Large Commits have some content hidden by default. Use the searchbox below for content that may be hidden.

‎Makefile‎

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -1124,16 +1124,16 @@ codepolicycheck:
11241124
config/feature-options/*.yaml \
11251125
config/examples/* config/header-snippets/* config/helper-snippets/* \
11261126
config/*.yaml
1127-
# XXX: config files not yet FIXME pure
11281127
@$(PYTHON) util/check_code_policy.py \
11291128
$(CODEPOLICYOPTS) \
11301129
--check-carriage-returns \
1130+
--check-fixme \
11311131
--check-non-ascii \
11321132
--check-trailing-whitespace \
11331133
--check-mixed-indent \
11341134
--check-nonleading-tab \
11351135
--dump-vim-commands \
1136-
config/config-options/*.yaml config/other-defines/*.yaml
1136+
config/config-options/*.yaml
11371137
@$(PYTHON) util/check_code_policy.py \
11381138
$(CODEPOLICYOPTS) \
11391139
--check-carriage-returns \

‎config/config-options/DUK_USE_AUGMENT_ERROR_CREATE.yaml‎

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -4,5 +4,5 @@ default: true
44
tags:
55
- ecmascript
66
description: >
7-
Augment an Ecmascript error object at creation with tracedata or
7+
Augment an ECMAScript error object at creation with tracedata or
88
fileName/lineNumber, or Duktape.errCreate (if enabled).

‎config/config-options/DUK_USE_AUGMENT_ERROR_THROW.yaml‎

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -4,5 +4,5 @@ default: true
44
tags:
55
- ecmascript
66
description: >
7-
Augment an Ecmascript error object at throw time with Duktape.errThrow
7+
Augment an ECMAScript error object at throw time with Duktape.errThrow
88
(if enabled).

‎config/config-options/DUK_USE_BRANCH_HINTS.yaml‎

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -6,4 +6,4 @@ tags:
66
description: >
77
Use branch hints if the compiler supports them.
88
9-
# FIXME: unused now?
9+
# XXX: Unused now, DUK_LIKELY and DUK_UNLIKELY are used instead.

‎config/config-options/DUK_USE_BUFFEROBJECT_SUPPORT.yaml‎

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -8,8 +8,8 @@ description: >
88
99
When disabled, Duktape custom plain buffer type is present and functional
1010
in the C API. Plain buffers have virtual properties and you can read/write
11-
buffer contents in Ecmascript code. Plain buffers will still inherit from
12-
ArrayBuffer.prototype, but none of the Ecmascript buffer related bindings
11+
buffer contents in ECMAScript code. Plain buffers will still inherit from
12+
ArrayBuffer.prototype, but none of the ECMAScript buffer related bindings
1313
will work. This includes all ArrayBuffer, typed array, and Node.js Buffer
1414
methods. Native bindings which produce plain buffer results (like
1515
Duktape.dec()) will still work.

‎config/config-options/DUK_USE_BUILTIN_INITJS.yaml‎

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -7,6 +7,6 @@ tags:
77
description: >
88
Use built-in .js init code when creating a new global context.
99
The .js init code (duk_initjs.js) provides some initialization
10-
code that's nicer to implement in Ecmascript, and is also used
10+
code that's nicer to implement in ECMAScript, and is also used
1111
to provide some backwards compatibility bindings which are easy
1212
to remove later.

‎config/config-options/DUK_USE_COMMONJS_MODULES.yaml‎

Lines changed: 1 addition & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -1,5 +1,6 @@
11
define: DUK_USE_COMMONJS_MODULES
22
introduced: 1.0.0
3+
removed: 2.0.0
34
default: true
45
tags:
56
- ecmascript
@@ -8,5 +9,3 @@ description: >
89
function provides a simple module loader facility which depends on the user
910
providing low level module searching functionality. When disabled, the
1011
global require() function is present but throws an error.
11-
12-
# FIXME: change so that global is missing if disabled?

‎config/config-options/DUK_USE_COMPILER_RECLIMIT.yaml‎

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -5,4 +5,4 @@ tags:
55
- portability
66
- cstackdepth
77
description: >
8-
Ecmascript compiler native call stack recursion limit.
8+
ECMAScript compiler native call stack recursion limit.

‎config/config-options/DUK_USE_COMPUTED_INFINITY.yaml‎

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -11,5 +11,5 @@ description: >
1111
1212
When enabled, define DUK_DOUBLE_INFINITY as duk_computed_infinity.
1313
14-
# FIXME: remove computed infinity from Duktape itself and let user
14+
# XXX: Remove computed infinity from Duktape itself and let user
1515
# provide it instead?

‎config/config-options/DUK_USE_COMPUTED_NAN.yaml‎

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -11,5 +11,5 @@ description: >
1111
1212
When enabled, define DUK_DOUBLE_NAN as duk_computed_nan.
1313
14-
# FIXME: remove computed NaN from Duktape itself and let user provide
14+
# XXX: Remove computed NaN from Duktape itself and let user provide
1515
# it instead?

0 commit comments

Comments
 (0)