Skip to content

Commit fd6f598

Browse files
committed
[webkitcorepy] Fix race condition in TaskPool unittests (follow-up fix)
https://bugs.webkit.org/show_bug.cgi?id=227455 <rdar://problem/79873003> Reviewed by Dewei Zhu. * Scripts/libraries/webkitcorepy/webkitcorepy/tests/task_pool_unittest.py: (TaskPoolUnittest.test_invalid_shutdown): Deleted. Canonical link: https://commits.webkit.org/240052@main git-svn-id: https://svn.webkit.org/repository/webkit/trunk@280412 268f45cc-cd09-0410-ab3c-d52691b4dbfc
1 parent 1d4e314 commit fd6f598

2 files changed

Lines changed: 11 additions & 6 deletions

File tree

Tools/ChangeLog

Lines changed: 11 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -1,3 +1,14 @@
1+
2021-07-28 Jonathan Bedard <jbedard@apple.com>
2+
3+
[webkitcorepy] Fix race condition in TaskPool unittests (follow-up fix)
4+
https://bugs.webkit.org/show_bug.cgi?id=227455
5+
<rdar://problem/79873003>
6+
7+
Reviewed by Dewei Zhu.
8+
9+
* Scripts/libraries/webkitcorepy/webkitcorepy/tests/task_pool_unittest.py:
10+
(TaskPoolUnittest.test_invalid_shutdown): Deleted.
11+
112
2021-07-28 Jonathan Bedard <jbedard@apple.com>
213

314
[ews-build.webkit.org] Verify GitHub integrity in commit queue

Tools/Scripts/libraries/webkitcorepy/webkitcorepy/tests/task_pool_unittest.py

Lines changed: 0 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -168,9 +168,3 @@ def test_teardown_arguments(self):
168168
sorted(captured.webkitcorepy.log.getvalue().splitlines()),
169169
['worker/{} Teardown argument'.format(x) for x in range(4)],
170170
)
171-
172-
def test_invalid_shutdown(self):
173-
with OutputCapture():
174-
with self.assertRaises(TaskPool.Exception):
175-
with TaskPool(workers=1, teardown=teardown, grace_period=1, force_fork=True) as pool:
176-
pool.do(wait, 5)

0 commit comments

Comments
 (0)