Skip to content

Commit fd0ac4f

Browse files
ryanalanwebkit-commit-queue
ryanalan
authored and
webkit-commit-queue
committed
Submission failure with "make: *** No rule to make target `installsrc'. Stop"
https://bugs.webkit.org/show_bug.cgi?id=214696 <rdar://problem/62268104> Patch by Ryan Hostetler <rhost@apple.com> on 2020-10-04 Reviewed by Darin Adler. .: Add installsrc phase to support xbs submitproject for WebKit repository. This change allows internal tools to submit and build in a single step. * Makefile: * Makefile.shared: * Source/Makefile: Source/ThirdParty: Add installsrc phase to support xbs submitproject for WebKit repository. This change allows internal tools to submit and build in a single step. * Makefile: Tools: Add support for XBS single base project build for WebKit repository. This change allows internal tools to submit and build from the repository root in a single step. * Makefile: Tools does not need to be submitted, so we stub out the installsrc phase. WebKitLibraries: Add support for XBS single base project build for WebKit repository. This change allows internal tools to submit and build from the repository root in a single step. * Makefile: WebKitLibraries do not need to be submitted, so we stub out the installsrc phase. Canonical link: https://commits.webkit.org/230058@main git-svn-id: https://svn.webkit.org/repository/webkit/trunk@267949 268f45cc-cd09-0410-ab3c-d52691b4dbfc
1 parent bab74c1 commit fd0ac4f

10 files changed

Lines changed: 74 additions & 0 deletions

File tree

‎ChangeLog‎

Lines changed: 15 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -1,3 +1,18 @@
1+
2020-10-04 Ryan Hostetler <rhost@apple.com>
2+
3+
Submission failure with "make: *** No rule to make target `installsrc'. Stop"
4+
https://bugs.webkit.org/show_bug.cgi?id=214696
5+
<rdar://problem/62268104>
6+
7+
Reviewed by Darin Adler.
8+
9+
Add installsrc phase to support xbs submitproject for WebKit repository.
10+
This change allows internal tools to submit and build in a single step.
11+
12+
* Makefile:
13+
* Makefile.shared:
14+
* Source/Makefile:
15+
116
2020-10-02 Keith Rollin <krollin@apple.com>
217

318
Seeing "usage: basename string [suffix]" spam when using make to build

‎Makefile‎

Lines changed: 3 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -28,3 +28,6 @@ analyze:
2828

2929
clean:
3030
@$(build_target_for_each_module)
31+
32+
installsrc:
33+
$(build_target_for_each_module)

‎Makefile.shared‎

Lines changed: 3 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -139,4 +139,7 @@ endif
139139
clean:
140140
@$(call invoke_xcode,,-alltargets clean)
141141

142+
installsrc:
143+
@$(call invoke_xcode,,-alltargets installsrc SRCROOT="$(SRCROOT)$(PATH_FROM_ROOT)")
144+
142145
force: ;

‎Source/Makefile‎

Lines changed: 3 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -38,3 +38,6 @@ analyze:
3838

3939
clean:
4040
@$(build_target_for_each_module)
41+
42+
installsrc:
43+
@$(build_target_for_each_module)

‎Source/ThirdParty/ChangeLog‎

Lines changed: 13 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -1,3 +1,16 @@
1+
2020-10-04 Ryan Hostetler <rhost@apple.com>
2+
3+
Submission failure with "make: *** No rule to make target `installsrc'. Stop"
4+
https://bugs.webkit.org/show_bug.cgi?id=214696
5+
<rdar://problem/62268104>
6+
7+
Reviewed by Darin Adler.
8+
9+
Add installsrc phase to support xbs submitproject for WebKit repository.
10+
This change allows internal tools to submit and build in a single step.
11+
12+
* Makefile:
13+
114
2020-09-22 Keith Rollin <krollin@apple.com>
215

316
Unify debug and release target aliases

‎Source/ThirdParty/Makefile‎

Lines changed: 3 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -52,3 +52,6 @@ analyze:
5252

5353
clean:
5454
@$(build_target_for_each_module)
55+
56+
installsrc:
57+
@$(build_target_for_each_module)

‎Tools/ChangeLog‎

Lines changed: 14 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -1,3 +1,17 @@
1+
2020-10-04 Ryan Hostetler <rhost@apple.com>
2+
3+
Submission failure with "make: *** No rule to make target `installsrc'. Stop"
4+
https://bugs.webkit.org/show_bug.cgi?id=214696
5+
<rdar://problem/62268104>
6+
7+
Reviewed by Darin Adler.
8+
9+
Add support for XBS single base project build for WebKit repository.
10+
This change allows internal tools to submit and build from the repository root in a single step.
11+
12+
* Makefile:
13+
Tools does not need to be submitted, so we stub out the installsrc phase.
14+
115
2020-10-03 Alex Christensen <achristensen@webkit.org>
216

317
Add extra slash after empty host copied from base URL if path is also empty

‎Tools/Makefile‎

Lines changed: 3 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -48,3 +48,6 @@ analyze:
4848

4949
clean:
5050
@$(build_target_for_each_module)
51+
52+
installsrc:
53+
@true

‎WebKitLibraries/ChangeLog‎

Lines changed: 14 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -1,3 +1,17 @@
1+
2020-10-04 Ryan Hostetler <rhost@apple.com>
2+
3+
Submission failure with "make: *** No rule to make target `installsrc'. Stop"
4+
https://bugs.webkit.org/show_bug.cgi?id=214696
5+
<rdar://problem/62268104>
6+
7+
Reviewed by Darin Adler.
8+
9+
Add support for XBS single base project build for WebKit repository.
10+
This change allows internal tools to submit and build from the repository root in a single step.
11+
12+
* Makefile:
13+
WebKitLibraries do not need to be submitted, so we stub out the installsrc phase.
14+
115
2020-07-26 Wenson Hsieh <wenson_hsieh@apple.com>
216

317
REGRESSION (r264690): [ iOS wk2 ] editing/selection/shift-click-includes-existing-selection.html is a flaky failure

‎WebKitLibraries/Makefile‎

Lines changed: 3 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -36,3 +36,6 @@ analyze:
3636

3737
clean:
3838
@$(MAKE) cleanlibs
39+
40+
installsrc:
41+
@true

0 commit comments

Comments
 (0)