Skip to content

Commit ef99370

Browse files
author
Sam Weinig
committed
Remove unused 'DefaultDefineOwnProperty' extended attribute support
https://bugs.webkit.org/show_bug.cgi?id=224436 Reviewed by Antti Koivisto. The old CSSStyleDeclaration named-getter based implementation was the last user so this can now be removed. * bindings/scripts/CodeGeneratorJS.pm: (InstanceOverridesDefineOwnProperty): * bindings/scripts/IDLAttributes.json: Canonical link: https://commits.webkit.org/236399@main git-svn-id: https://svn.webkit.org/repository/webkit/trunk@275829 268f45cc-cd09-0410-ab3c-d52691b4dbfc
1 parent 00d80bb commit ef99370

3 files changed

Lines changed: 14 additions & 6 deletions

File tree

Source/WebCore/ChangeLog

Lines changed: 14 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -1,3 +1,17 @@
1+
2021-04-12 Sam Weinig <weinig@apple.com>
2+
3+
Remove unused 'DefaultDefineOwnProperty' extended attribute support
4+
https://bugs.webkit.org/show_bug.cgi?id=224436
5+
6+
Reviewed by Antti Koivisto.
7+
8+
The old CSSStyleDeclaration named-getter based implementation was
9+
the last user so this can now be removed.
10+
11+
* bindings/scripts/CodeGeneratorJS.pm:
12+
(InstanceOverridesDefineOwnProperty):
13+
* bindings/scripts/IDLAttributes.json:
14+
115
2021-04-12 Philippe Normand <pnormand@igalia.com>
216

317
[GStreamer][WebRTC] An audio track should be muted when capture is interrupted by the OS.

Source/WebCore/bindings/scripts/CodeGeneratorJS.pm

Lines changed: 0 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -2185,9 +2185,6 @@ sub InstanceOverridesPut
21852185
sub InstanceOverridesDefineOwnProperty
21862186
{
21872187
my $interface = shift;
2188-
2189-
return 0 if $interface->extendedAttributes->{DefaultDefineOwnProperty};
2190-
21912188
return $interface->extendedAttributes->{CustomDefineOwnProperty}
21922189
|| GetIndexedSetterOperation($interface)
21932190
|| GetNamedSetterOperation($interface);

Source/WebCore/bindings/scripts/IDLAttributes.json

Lines changed: 0 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -147,9 +147,6 @@
147147
"Default": {
148148
"contextsAllowed": ["operation"]
149149
},
150-
"DefaultDefineOwnProperty": {
151-
"contextsAllowed": ["interface"]
152-
},
153150
"DelegateToSharedSyntheticAttribute": {
154151
"contextsAllowed": ["attribute"]
155152
},

0 commit comments

Comments
 (0)