2011-04-15 Joseph Pecoraro <joepeck@webkit.org>

JosephPecoraro · JosephPecoraro · commit d9cc34b8e2d4 · 2011-04-15T20:01:50.000Z
Reviewed by Yury Semikhatsky. Frontend Part of Web Inspector: Remote Web Inspector - Cross Platform InspectorServer https://bugs.webkit.org/show_bug.cgi?id=51364 The front end should not use a transparent background when loaded as a web page (remote debugging) but should when loaded regularly in a custom window. This adds a "remote" style class onto the document body when the page is loaded remotely. * inspector/front-end/inspector.css: (body.detached.platform-mac-snowleopard:not(.remote) #toolbar): respect the "remote" class. * inspector/front-end/inspector.js: add a "remote" class on the body when loaded remotely. Canonical link: https://commits.webkit.org/73765@main git-svn-id: https://svn.webkit.org/repository/webkit/trunk@84023 268f45cc-cd09-0410-ab3c-d52691b4dbfc
diff --git a/Source/WebCore/ChangeLog b/Source/WebCore/ChangeLog
@@ -1,3 +1,19 @@
+2011-04-15  Joseph Pecoraro  <joepeck@webkit.org>
+
+        Reviewed by Yury Semikhatsky.
+
+        Frontend Part of Web Inspector: Remote Web Inspector - Cross Platform InspectorServer
+        https://bugs.webkit.org/show_bug.cgi?id=51364
+
+        The front end should not use a transparent background when
+        loaded as a web page (remote debugging) but should when loaded
+        regularly in a custom window. This adds a "remote" style class
+        onto the document body when the page is loaded remotely.
+
+        * inspector/front-end/inspector.css:
+        (body.detached.platform-mac-snowleopard:not(.remote) #toolbar): respect the "remote" class.
+        * inspector/front-end/inspector.js: add a "remote" class on the body when loaded remotely.
+
 2011-04-15  Joseph Pecoraro  <joepeck@webkit.org>
 
         Reviewed by David Kilzer.
diff --git a/Source/WebCore/inspector/front-end/inspector.css b/Source/WebCore/inspector/front-end/inspector.css
@@ -89,8 +89,8 @@ body.inactive #toolbar {
     border-bottom: 1px solid rgb(64%, 64%, 64%);
 }
 
-body.detached.platform-mac-leopard #toolbar,
-body.detached.platform-mac-snowleopard #toolbar {
+body.detached.platform-mac-leopard:not(.remote) #toolbar,
+body.detached.platform-mac-snowleopard:not(.remote) #toolbar {
     background: transparent !important;
 }
 
diff --git a/Source/WebCore/inspector/front-end/inspector.js b/Source/WebCore/inspector/front-end/inspector.js
@@ -416,6 +416,8 @@ WebInspector.doLoadedDone = function()
         document.body.addStyleClass("platform-" + flavor);
     var port = WebInspector.port;
     document.body.addStyleClass("port-" + port);
+    if (WebInspector.socket)
+        document.body.addStyleClass("remote");
 
     WebInspector.settings = new WebInspector.Settings();
 

Original file line number	Diff line number	Diff line change
`@@ -89,8 +89,8 @@ body.inactive #toolbar {`
`89`	`89`	`border-bottom: 1px solid rgb(64%, 64%, 64%);`
`90`	`90`	`}`
`91`	`91`
`92`		`-body.detached.platform-mac-leopard #toolbar,`
`93`		`-body.detached.platform-mac-snowleopard #toolbar {`
	`92`	`+body.detached.platform-mac-leopard:not(.remote) #toolbar,`
	`93`	`+body.detached.platform-mac-snowleopard:not(.remote) #toolbar {`
`94`	`94`	`background: transparent !important;`
`95`	`95`	`}`
`96`	`96`