Skip to content

Commit d357306

Browse files
committed
[MotionMark] Increase the warm-up time for each sub-test from 100ms to 1000ms
https://bugs.webkit.org/show_bug.cgi?id=219984 Reviewed by Jon Lee. Ensure the warm-up time is enough for the system to finish any initialization work which may be triggered by the sub-test before starting the sampling. This should prevent bi-modality in the score of the sub-tests since the initial frame rate is crucial in deciding how much the complexity can grow. * MotionMark/developer.html: * MotionMark/resources/runner/motionmark.js: (this.clear): Canonical link: https://commits.webkit.org/232581@main git-svn-id: https://svn.webkit.org/repository/webkit/trunk@270959 268f45cc-cd09-0410-ab3c-d52691b4dbfc
1 parent c1d5ef7 commit d357306

3 files changed

Lines changed: 18 additions & 2 deletions

File tree

PerformanceTests/ChangeLog

Lines changed: 16 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -1,3 +1,19 @@
1+
2020-12-17 Said Abou-Hallawa <said@apple.com>
2+
3+
[MotionMark] Increase the warm-up time for each sub-test from 100ms to 1000ms
4+
https://bugs.webkit.org/show_bug.cgi?id=219984
5+
6+
Reviewed by Jon Lee.
7+
8+
Ensure the warm-up time is enough for the system to finish any initialization
9+
work which may be triggered by the sub-test before starting the sampling.
10+
This should prevent bi-modality in the score of the sub-tests since the
11+
initial frame rate is crucial in deciding how much the complexity can grow.
12+
13+
* MotionMark/developer.html:
14+
* MotionMark/resources/runner/motionmark.js:
15+
(this.clear):
16+
117
2020-12-14 Antti Koivisto <antti@apple.com>
218

319
Add inline-block line layout microbench

PerformanceTests/MotionMark/developer.html

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -65,7 +65,7 @@ <h2>Options:</h2>
6565
<form name="benchmark-options">
6666
<ul>
6767
<li>
68-
<label>Warmup length: <input type="number" id="warmup-length" value="100"> milliseconds</label>
68+
<label>Warmup length: <input type="number" id="warmup-length" value="1000"> milliseconds</label>
6969
</li>
7070
<li>
7171
<label>Test length: <input type="number" id="test-interval" value="30"> seconds each</label>

PerformanceTests/MotionMark/resources/runner/motionmark.js

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -465,7 +465,7 @@ window.benchmarkController = {
465465
"kalman-process-error": 1,
466466
"kalman-measurement-error": 4,
467467
"time-measurement": "performance",
468-
"warmup-length": 100
468+
"warmup-length": 1000
469469
},
470470

471471
initialize: function()

0 commit comments

Comments
 (0)