Skip to content

Commit d01bd73

Browse files
ojanvafaiojanvafai
committed
check-layout.js should always dumpAsText
https://bugs.webkit.org/show_bug.cgi?id=98959 Reviewed by Tony Chang. Every checkLayout test was already dumpAsText except for css3/flexbox/flex-item-child-overflow.html, which is a reftest and really doesn't need to be a checkLayout test. * css3/flexbox/auto-height-dynamic.html: * css3/flexbox/box-sizing-min-max-sizes.html: * css3/flexbox/box-sizing.html: * css3/flexbox/columns-auto-size.html: * css3/flexbox/columns-height-set-via-top-bottom.html: * css3/flexbox/flex-algorithm-min-max.html: * css3/flexbox/flex-algorithm-with-margins.html: * css3/flexbox/flex-algorithm.html: * css3/flexbox/flex-align-column.html: * css3/flexbox/flex-align-end.html: * css3/flexbox/flex-align-max.html: * css3/flexbox/flex-align-percent-height.html: * css3/flexbox/flex-align-stretch.html: * css3/flexbox/flex-align-vertical-writing-mode.html: * css3/flexbox/flex-align.html: * css3/flexbox/flex-flow-auto-margins.html: * css3/flexbox/flex-flow-border.html: * css3/flexbox/flex-flow-margins-auto-size.html: * css3/flexbox/flex-flow-margins.html: * css3/flexbox/flex-flow-orientations.html: * css3/flexbox/flex-flow-overflow.html: * css3/flexbox/flex-flow-padding.html: * css3/flexbox/flex-flow.html: * css3/flexbox/flex-item-child-overflow-expected.html: * css3/flexbox/flex-item-child-overflow.html: * css3/flexbox/flex-item-min-size.html: * css3/flexbox/flex-justify-content.html: * css3/flexbox/flex-no-flex.html: * css3/flexbox/flex-rounding.html: * css3/flexbox/flexitem-stretch-image.html: * css3/flexbox/flexitem.html: * css3/flexbox/floated-flexbox.html: * css3/flexbox/inline-flex.html: * css3/flexbox/line-wrapping.html: * css3/flexbox/multiline-align-content-horizontal-column.html: * css3/flexbox/multiline-align-content.html: * css3/flexbox/multiline-align-self.html: * css3/flexbox/multiline-column-auto.html: * css3/flexbox/multiline-justify-content.html: * css3/flexbox/multiline-reverse-wrap-overflow.html: * css3/flexbox/multiline.html: * css3/flexbox/nested-stretch.html: * css3/flexbox/orthogonal-flex-directions.html: * css3/flexbox/percent-margins.html: * css3/flexbox/percentage-heights.html: * css3/flexbox/percentage-sizes-quirks.html: * css3/flexbox/percentage-sizes.html: * css3/flexbox/perpendicular-writing-modes-inside-flex-item.html: * css3/flexbox/position-absolute-child.html: * css3/flexbox/position-absolute-children.html: * css3/flexbox/preferred-widths-orthogonal.html: * css3/flexbox/preferred-widths.html: * css3/flexbox/relayout-image-load.html: * css3/flexbox/style-change.html: * css3/flexbox/true-centering.html: * css3/flexbox/writing-modes.html: * fast/block/margins-perpendicular-containing-block.html: * fast/css-grid-layout/place-cell-by-index.html: * fast/css/deprecated-flexbox-auto-min-size.html: * fast/css/nested-percent-height-on-replaced.html: * fast/css/percentage-height-auto-sized-body-quirks.html: * fast/flexbox/flexing-overflow-scroll-item.html: * fast/replaced/vertical-writing-mode-max-logical-width-replaced.html: * fast/table/bad-replaced-sizing-preferred-logical-widths.html: * fast/table/margins-flipped-text-direction.html: * fast/table/margins-perpendicular-containing-block.html: * fast/writing-mode/percentage-height-orthogonal-writing-modes-quirks.html: * fast/writing-mode/percentage-height-orthogonal-writing-modes.html: * resources/check-layout.js: Canonical link: https://commits.webkit.org/116951@main git-svn-id: https://svn.webkit.org/repository/webkit/trunk@130979 268f45cc-cd09-0410-ab3c-d52691b4dbfc
1 parent 882458a commit d01bd73

71 files changed

Lines changed: 90 additions & 271 deletions

File tree

Some content is hidden

Large Commits have some content hidden by default. Use the searchbox below for content that may be hidden.

‎LayoutTests/ChangeLog‎

Lines changed: 81 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -1,3 +1,84 @@
1+
2012-10-10 Ojan Vafai <ojan@chromium.org>
2+
3+
check-layout.js should always dumpAsText
4+
https://bugs.webkit.org/show_bug.cgi?id=98959
5+
6+
Reviewed by Tony Chang.
7+
8+
Every checkLayout test was already dumpAsText except for
9+
css3/flexbox/flex-item-child-overflow.html, which is a reftest
10+
and really doesn't need to be a checkLayout test.
11+
12+
* css3/flexbox/auto-height-dynamic.html:
13+
* css3/flexbox/box-sizing-min-max-sizes.html:
14+
* css3/flexbox/box-sizing.html:
15+
* css3/flexbox/columns-auto-size.html:
16+
* css3/flexbox/columns-height-set-via-top-bottom.html:
17+
* css3/flexbox/flex-algorithm-min-max.html:
18+
* css3/flexbox/flex-algorithm-with-margins.html:
19+
* css3/flexbox/flex-algorithm.html:
20+
* css3/flexbox/flex-align-column.html:
21+
* css3/flexbox/flex-align-end.html:
22+
* css3/flexbox/flex-align-max.html:
23+
* css3/flexbox/flex-align-percent-height.html:
24+
* css3/flexbox/flex-align-stretch.html:
25+
* css3/flexbox/flex-align-vertical-writing-mode.html:
26+
* css3/flexbox/flex-align.html:
27+
* css3/flexbox/flex-flow-auto-margins.html:
28+
* css3/flexbox/flex-flow-border.html:
29+
* css3/flexbox/flex-flow-margins-auto-size.html:
30+
* css3/flexbox/flex-flow-margins.html:
31+
* css3/flexbox/flex-flow-orientations.html:
32+
* css3/flexbox/flex-flow-overflow.html:
33+
* css3/flexbox/flex-flow-padding.html:
34+
* css3/flexbox/flex-flow.html:
35+
* css3/flexbox/flex-item-child-overflow-expected.html:
36+
* css3/flexbox/flex-item-child-overflow.html:
37+
* css3/flexbox/flex-item-min-size.html:
38+
* css3/flexbox/flex-justify-content.html:
39+
* css3/flexbox/flex-no-flex.html:
40+
* css3/flexbox/flex-rounding.html:
41+
* css3/flexbox/flexitem-stretch-image.html:
42+
* css3/flexbox/flexitem.html:
43+
* css3/flexbox/floated-flexbox.html:
44+
* css3/flexbox/inline-flex.html:
45+
* css3/flexbox/line-wrapping.html:
46+
* css3/flexbox/multiline-align-content-horizontal-column.html:
47+
* css3/flexbox/multiline-align-content.html:
48+
* css3/flexbox/multiline-align-self.html:
49+
* css3/flexbox/multiline-column-auto.html:
50+
* css3/flexbox/multiline-justify-content.html:
51+
* css3/flexbox/multiline-reverse-wrap-overflow.html:
52+
* css3/flexbox/multiline.html:
53+
* css3/flexbox/nested-stretch.html:
54+
* css3/flexbox/orthogonal-flex-directions.html:
55+
* css3/flexbox/percent-margins.html:
56+
* css3/flexbox/percentage-heights.html:
57+
* css3/flexbox/percentage-sizes-quirks.html:
58+
* css3/flexbox/percentage-sizes.html:
59+
* css3/flexbox/perpendicular-writing-modes-inside-flex-item.html:
60+
* css3/flexbox/position-absolute-child.html:
61+
* css3/flexbox/position-absolute-children.html:
62+
* css3/flexbox/preferred-widths-orthogonal.html:
63+
* css3/flexbox/preferred-widths.html:
64+
* css3/flexbox/relayout-image-load.html:
65+
* css3/flexbox/style-change.html:
66+
* css3/flexbox/true-centering.html:
67+
* css3/flexbox/writing-modes.html:
68+
* fast/block/margins-perpendicular-containing-block.html:
69+
* fast/css-grid-layout/place-cell-by-index.html:
70+
* fast/css/deprecated-flexbox-auto-min-size.html:
71+
* fast/css/nested-percent-height-on-replaced.html:
72+
* fast/css/percentage-height-auto-sized-body-quirks.html:
73+
* fast/flexbox/flexing-overflow-scroll-item.html:
74+
* fast/replaced/vertical-writing-mode-max-logical-width-replaced.html:
75+
* fast/table/bad-replaced-sizing-preferred-logical-widths.html:
76+
* fast/table/margins-flipped-text-direction.html:
77+
* fast/table/margins-perpendicular-containing-block.html:
78+
* fast/writing-mode/percentage-height-orthogonal-writing-modes-quirks.html:
79+
* fast/writing-mode/percentage-height-orthogonal-writing-modes.html:
80+
* resources/check-layout.js:
81+
182
2012-10-10 Jeffrey Pfau <jpfau@apple.com>
283

384
[Mac][WK2] Unreviewed, skipping fast/parser/document-open-in-unload.html

‎LayoutTests/css3/flexbox/auto-height-dynamic.html‎

Lines changed: 0 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -11,10 +11,6 @@
1111
background-color: blue;
1212
}
1313
</style>
14-
<script>
15-
if (window.testRunner)
16-
testRunner.dumpAsText();
17-
</script>
1814
<script src="../../resources/check-layout.js"></script>
1915
<body onload="checkLayout('.flexbox')">
2016

‎LayoutTests/css3/flexbox/box-sizing-min-max-sizes.html‎

Lines changed: 0 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -8,10 +8,6 @@
88
box-sizing: border-box;
99
}
1010
</style>
11-
<script>
12-
if (window.testRunner)
13-
testRunner.dumpAsText();
14-
</script>
1511
<script src="../../resources/check-layout.js"></script>
1612
<body onload="checkLayout('.flexbox')">
1713

‎LayoutTests/css3/flexbox/box-sizing.html‎

Lines changed: 0 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -92,9 +92,6 @@ <h3>flex-flow: column, flex-box has box-sizing: border-box, flex items have flex
9292
}
9393
[].forEach.call(document.querySelectorAll(".flexbox > div"), addExpectedSizes);
9494
[].forEach.call(document.querySelectorAll(".border-box"), addExpectedSizes);
95-
96-
if (window.testRunner)
97-
testRunner.dumpAsText();
9895
</script>
9996
</body>
10097
</html>

‎LayoutTests/css3/flexbox/columns-auto-size.html‎

Lines changed: 0 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -41,10 +41,6 @@
4141
background-color: yellow;
4242
}
4343
</style>
44-
<script>
45-
if (window.testRunner)
46-
testRunner.dumpAsText();
47-
</script>
4844
<script src="../../resources/check-layout.js"></script>
4945
<body onload="checkLayout('.flexbox')">
5046
<div class="flexbox column horizontal">

‎LayoutTests/css3/flexbox/columns-height-set-via-top-bottom.html‎

Lines changed: 0 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -24,10 +24,6 @@
2424
background-color: lightgreen;
2525
}
2626
</style>
27-
<script>
28-
if (window.testRunner)
29-
testRunner.dumpAsText();
30-
</script>
3127
<script src="../../resources/check-layout.js"></script>
3228
<body onload="checkLayout('.flexbox')">
3329

‎LayoutTests/css3/flexbox/flex-algorithm-min-max.html‎

Lines changed: 0 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -42,10 +42,6 @@
4242
-moz-flex: 1 0 0px;
4343
}
4444
</style>
45-
<script>
46-
if (window.testRunner)
47-
testRunner.dumpAsText();
48-
</script>
4945
<script src="../../resources/check-layout.js"></script>
5046
<body onload="checkLayout('.flexbox')">
5147
<div class="flexbox">

‎LayoutTests/css3/flexbox/flex-algorithm-with-margins.html‎

Lines changed: 0 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -46,10 +46,6 @@
4646
-moz-flex: 2 0 0px;
4747
}
4848
</style>
49-
<script>
50-
if (window.testRunner)
51-
testRunner.dumpAsText();
52-
</script>
5349
<script src="../../resources/check-layout.js"></script>
5450
<body onload="checkLayout('.flexbox')">
5551
<div class="flexbox">

‎LayoutTests/css3/flexbox/flex-algorithm.html‎

Lines changed: 0 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -40,10 +40,6 @@
4040
-moz-flex: 1 0 0px;
4141
}
4242
</style>
43-
<script>
44-
if (window.testRunner)
45-
testRunner.dumpAsText();
46-
</script>
4743
<script src="../../resources/check-layout.js"></script>
4844
<body onload="checkLayout('.flexbox')">
4945

‎LayoutTests/css3/flexbox/flex-align-column.html‎

Lines changed: 0 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -37,10 +37,6 @@
3737
background-color: lime;
3838
}
3939
</style>
40-
<script>
41-
if (window.testRunner)
42-
testRunner.dumpAsText();
43-
</script>
4440
<script src="../../resources/check-layout.js"></script>
4541
<body onload="checkLayout('.flexbox')">
4642

0 commit comments

Comments
 (0)