Skip to content

Commit cb281c2

Browse files
cdumezcdumez
committed
WebAudio tests may give slightly different outputs on different platforms
https://bugs.webkit.org/show_bug.cgi?id=218929 Reviewed by Geoffrey Garen. LayoutTests/imported/w3c: Rebaseline WPT tests now that their output has changed. * web-platform-tests/webaudio/the-audio-api/the-audioparam-interface/k-rate-audiobuffersource-connections-expected.txt: * web-platform-tests/webaudio/the-audio-api/the-audioparam-interface/k-rate-audioworklet-connections.https-expected.txt: * web-platform-tests/webaudio/the-audio-api/the-audioparam-interface/k-rate-biquad-connection-expected.txt: * web-platform-tests/webaudio/the-audio-api/the-audioparam-interface/k-rate-biquad-expected.txt: * web-platform-tests/webaudio/the-audio-api/the-audioparam-interface/k-rate-constant-source-expected.txt: * web-platform-tests/webaudio/the-audio-api/the-audioparam-interface/k-rate-delay-connections-expected.txt: * web-platform-tests/webaudio/the-audio-api/the-audioparam-interface/k-rate-delay-expected.txt: * web-platform-tests/webaudio/the-audio-api/the-audioparam-interface/k-rate-gain-expected.txt: * web-platform-tests/webaudio/the-audio-api/the-audioparam-interface/k-rate-oscillator-expected.txt: * web-platform-tests/webaudio/the-audio-api/the-audioparam-interface/k-rate-panner-connections-expected.txt: * web-platform-tests/webaudio/the-audio-api/the-audioparam-interface/k-rate-panner-expected.txt: * web-platform-tests/webaudio/the-audio-api/the-audioparam-interface/k-rate-stereo-panner-expected.txt: * web-platform-tests/webaudio/the-audio-api/the-convolvernode-interface/convolver-cascade-expected.txt: * web-platform-tests/webaudio/the-audio-api/the-convolvernode-interface/convolver-response-4-chan-expected.txt: * web-platform-tests/webaudio/the-audio-api/the-delaynode-interface/maxdelay-rounding-expected.txt: * web-platform-tests/webaudio/the-audio-api/the-oscillatornode-interface/detune-limiting-expected.txt: * web-platform-tests/webaudio/the-audio-api/the-pannernode-interface/automation-changes-expected.txt: LayoutTests: WebAudio tests may give slightly different outputs on different platforms, causing what looks like flakiness. This is due to the "(contains X different values)" because X may differ from one platform to another (usually +/- 1). * resources/testharnessreport.js: (self.testRunner.add_completion_callback): Strip the "(contains X different values)" strings from output lines. * webaudio/AudioNode/tail-connections-expected.txt: * webaudio/AudioNode/tail-processing-expected.txt: * webaudio/BiquadFilter/biquad-829349-expected.txt: * webaudio/BiquadFilter/tail-time-allpass-expected.txt: * webaudio/BiquadFilter/tail-time-bandpass-expected.txt: * webaudio/BiquadFilter/tail-time-highpass-expected.txt: * webaudio/BiquadFilter/tail-time-highshelf-expected.txt: * webaudio/BiquadFilter/tail-time-lowpass-expected.txt: * webaudio/BiquadFilter/tail-time-lowshelf-expected.txt: * webaudio/BiquadFilter/tail-time-notch-expected.txt: * webaudio/BiquadFilter/tail-time-peaking-expected.txt: * webaudio/IIRFilter/iir-tail-time-expected.txt: Rebaseline tests accordingly. Canonical link: https://commits.webkit.org/231617@main git-svn-id: https://svn.webkit.org/repository/webkit/trunk@269853 268f45cc-cd09-0410-ab3c-d52691b4dbfc
1 parent ecc0b38 commit cb281c2

32 files changed

Lines changed: 1091 additions & 1034 deletions

‎LayoutTests/ChangeLog‎

Lines changed: 29 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -1,3 +1,32 @@
1+
2020-11-16 Chris Dumez <cdumez@apple.com>
2+
3+
WebAudio tests may give slightly different outputs on different platforms
4+
https://bugs.webkit.org/show_bug.cgi?id=218929
5+
6+
Reviewed by Geoffrey Garen.
7+
8+
WebAudio tests may give slightly different outputs on different platforms, causing what looks like flakiness.
9+
This is due to the "(contains X different values)" because X may differ from one platform to another
10+
(usually +/- 1).
11+
12+
* resources/testharnessreport.js:
13+
(self.testRunner.add_completion_callback):
14+
Strip the "(contains X different values)" strings from output lines.
15+
16+
* webaudio/AudioNode/tail-connections-expected.txt:
17+
* webaudio/AudioNode/tail-processing-expected.txt:
18+
* webaudio/BiquadFilter/biquad-829349-expected.txt:
19+
* webaudio/BiquadFilter/tail-time-allpass-expected.txt:
20+
* webaudio/BiquadFilter/tail-time-bandpass-expected.txt:
21+
* webaudio/BiquadFilter/tail-time-highpass-expected.txt:
22+
* webaudio/BiquadFilter/tail-time-highshelf-expected.txt:
23+
* webaudio/BiquadFilter/tail-time-lowpass-expected.txt:
24+
* webaudio/BiquadFilter/tail-time-lowshelf-expected.txt:
25+
* webaudio/BiquadFilter/tail-time-notch-expected.txt:
26+
* webaudio/BiquadFilter/tail-time-peaking-expected.txt:
27+
* webaudio/IIRFilter/iir-tail-time-expected.txt:
28+
Rebaseline tests accordingly.
29+
130
2020-11-16 Youenn Fablet <youenn@apple.com>
231

332
TextEncoderStreamEncoder should not be exposed

‎LayoutTests/imported/w3c/ChangeLog‎

Lines changed: 27 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -1,3 +1,30 @@
1+
2020-11-16 Chris Dumez <cdumez@apple.com>
2+
3+
WebAudio tests may give slightly different outputs on different platforms
4+
https://bugs.webkit.org/show_bug.cgi?id=218929
5+
6+
Reviewed by Geoffrey Garen.
7+
8+
Rebaseline WPT tests now that their output has changed.
9+
10+
* web-platform-tests/webaudio/the-audio-api/the-audioparam-interface/k-rate-audiobuffersource-connections-expected.txt:
11+
* web-platform-tests/webaudio/the-audio-api/the-audioparam-interface/k-rate-audioworklet-connections.https-expected.txt:
12+
* web-platform-tests/webaudio/the-audio-api/the-audioparam-interface/k-rate-biquad-connection-expected.txt:
13+
* web-platform-tests/webaudio/the-audio-api/the-audioparam-interface/k-rate-biquad-expected.txt:
14+
* web-platform-tests/webaudio/the-audio-api/the-audioparam-interface/k-rate-constant-source-expected.txt:
15+
* web-platform-tests/webaudio/the-audio-api/the-audioparam-interface/k-rate-delay-connections-expected.txt:
16+
* web-platform-tests/webaudio/the-audio-api/the-audioparam-interface/k-rate-delay-expected.txt:
17+
* web-platform-tests/webaudio/the-audio-api/the-audioparam-interface/k-rate-gain-expected.txt:
18+
* web-platform-tests/webaudio/the-audio-api/the-audioparam-interface/k-rate-oscillator-expected.txt:
19+
* web-platform-tests/webaudio/the-audio-api/the-audioparam-interface/k-rate-panner-connections-expected.txt:
20+
* web-platform-tests/webaudio/the-audio-api/the-audioparam-interface/k-rate-panner-expected.txt:
21+
* web-platform-tests/webaudio/the-audio-api/the-audioparam-interface/k-rate-stereo-panner-expected.txt:
22+
* web-platform-tests/webaudio/the-audio-api/the-convolvernode-interface/convolver-cascade-expected.txt:
23+
* web-platform-tests/webaudio/the-audio-api/the-convolvernode-interface/convolver-response-4-chan-expected.txt:
24+
* web-platform-tests/webaudio/the-audio-api/the-delaynode-interface/maxdelay-rounding-expected.txt:
25+
* web-platform-tests/webaudio/the-audio-api/the-oscillatornode-interface/detune-limiting-expected.txt:
26+
* web-platform-tests/webaudio/the-audio-api/the-pannernode-interface/automation-changes-expected.txt:
27+
128
2020-11-15 Yusuke Suzuki <ysuzuki@apple.com>
229

330
[JSC] Wasm should get byte length from source typed array

‎LayoutTests/imported/w3c/web-platform-tests/webaudio/the-audio-api/the-audioparam-interface/k-rate-audiobuffersource-connections-expected.txt‎

Lines changed: 4 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -12,8 +12,8 @@ PASS playbackRate: mod = new ConstantSourceNode(context, {offset: 0}) did not
1212
PASS playbackRate: mod.offset.setValueAtTime(0, 0) did not throw an exception.
1313
PASS playbackRate: mod.offset.linearRampToValueAtTime(1, 0.25) did not throw an exception.
1414
PASS playbackRate: mod.connect(tstNode[playbackRate]) did not throw an exception.
15-
PASS Expected k-rate playbackRate AudioParam with input is not constantly 0 (contains 1491 different values).
16-
PASS Actual k-rate playbackRate AudioParam with input is not constantly 0 (contains 1491 different values).
15+
PASS Expected k-rate playbackRate AudioParam with input is not constantly 0.
16+
PASS Actual k-rate playbackRate AudioParam with input is not constantly 0.
1717
PASS k-rate playbackRate AudioParam with input equals [expected array] with an element-wise tolerance of {"absoluteThreshold":0,"relativeThreshold":0}.
1818
PASS < [playbackRate] All assertions passed. (total 11 assertions)
1919
PASS > [detune] AudioBufferSource detune
@@ -25,8 +25,8 @@ PASS detune: mod = new ConstantSourceNode(context, {offset: 0}) did not throw
2525
PASS detune: mod.offset.setValueAtTime(-1200, 0) did not throw an exception.
2626
PASS detune: mod.offset.linearRampToValueAtTime(1200, 0.25) did not throw an exception.
2727
PASS detune: mod.connect(tstNode[detune]) did not throw an exception.
28-
PASS Expected k-rate detune AudioParam with input is not constantly 0 (contains 1961 different values).
29-
PASS Actual k-rate detune AudioParam with input is not constantly 0 (contains 1961 different values).
28+
PASS Expected k-rate detune AudioParam with input is not constantly 0.
29+
PASS Actual k-rate detune AudioParam with input is not constantly 0.
3030
PASS k-rate detune AudioParam with input equals [expected array] with an element-wise tolerance of {"absoluteThreshold":0,"relativeThreshold":0}.
3131
PASS < [detune] All assertions passed. (total 11 assertions)
3232
PASS # AUDIT TASK RUNNER FINISHED: 2 tasks ran successfully.

‎LayoutTests/imported/w3c/web-platform-tests/webaudio/the-audio-api/the-audioparam-interface/k-rate-audioworklet-connections.https-expected.txt‎

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -7,7 +7,7 @@ PASS > [Create Test Worklet]
77
PASS Construction of AudioWorklet resolved correctly.
88
PASS < [Create Test Worklet] All assertions passed. (total 1 assertions)
99
PASS > [AudioWorklet k-rate AudioParam]
10-
PASS output is not constantly 0 (contains 384 different values).
10+
PASS output is not constantly 0.
1111
PASS k-rate output [0: 127] contains only the constant 0.
1212
PASS k-rate output [128: 255] contains only the constant 2.5.
1313
PASS k-rate output [256: 383] contains only the constant 5.

‎LayoutTests/imported/w3c/web-platform-tests/webaudio/the-audio-api/the-audioparam-interface/k-rate-biquad-connection-expected.txt‎

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -14,7 +14,7 @@ PASS refNode.frequency.linearRampToValueAtTime.(0,0.125) did not throw an exce
1414
PASS Test BiquadFilterNode(context, {"type":"lowpass","frequency":0}) did not throw an exception.
1515
PASS frequency: mod.offset.setValueAtTime(880,0) did not throw an exception.
1616
PASS frequency: mod.offset.linearRampToValueAtTime(0,0.125) did not throw an exception.
17-
PASS Expected k-rate frequency with automation output[0:2047] is not constantly 0 (contains 1023 different values).
17+
PASS Expected k-rate frequency with automation output[0:2047] is not constantly 0.
1818
PASS Expected k-rate frequency with automation output[2048:] contains only the constant 0.
1919
PASS k-rate frequency with input: output[0,2048] equals [expected array] with an element-wise tolerance of {"absoluteThreshold":0,"relativeThreshold":0}.
2020
PASS k-rate frequency with input: output[2048:] equals [0,0,0,0,0,0,0,0,0,0,0,0,0,0,0,0...] with an element-wise tolerance of {"absoluteThreshold":0,"relativeThreshold":0}.
@@ -95,7 +95,7 @@ PASS Start: mod[frequency].start() did not throw an exception.
9595
PASS Start: mod[Q].start() did not throw an exception.
9696
PASS Start: mod[gain].start() did not throw an exception.
9797
PASS Start: mod[detune].start() did not throw an exception.
98-
PASS All k-rate AudioParams is not constantly 0 (contains 4094 different values).
98+
PASS All k-rate AudioParams is not constantly 0.
9999
PASS All k-rate AudioParams equals [expected array] with an element-wise tolerance of {"absoluteThreshold":0,"relativeThreshold":0}.
100100
PASS < [All k-rate inputs] All assertions passed. (total 44 assertions)
101101
PASS # AUDIT TASK RUNNER FINISHED: 5 tasks ran successfully.

‎LayoutTests/imported/w3c/web-platform-tests/webaudio/the-audio-api/the-audioparam-interface/k-rate-biquad-expected.txt‎

Lines changed: 5 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -17,7 +17,7 @@ PASS All k-rate params: a-rate node:frequency.setValueAtTime(350,0) did not th
1717
PASS All k-rate params: a-rate node:frequency.linearRampToValueAtTime(0,1) did not throw an exception.
1818
PASS All k-rate params: Output of k-rate BiquadFilterNode is identical to the array [expected array].
1919
PASS All k-rate params: Output of a-rate BiquadFilterNode is identical to the array [expected array].
20-
PASS All k-rate params: Difference between a-rate and k-rate BiquadFilterNode is not constantly 0 (contains 7999 different values).
20+
PASS All k-rate params: Difference between a-rate and k-rate BiquadFilterNode is not constantly 0.
2121
PASS < [Biquad k-rate AudioParams (all)] All assertions passed. (total 11 assertions)
2222
PASS > [Biquad k-rate Q]
2323
PASS k-rate Q: Setting Q.automationRate to "k-rate" is equal to k-rate.
@@ -27,7 +27,7 @@ PASS k-rate Q: a-rate node:Q.setValueAtTime(1,0) did not throw an exception.
2727
PASS k-rate Q: a-rate node:Q.linearRampToValueAtTime(10,1) did not throw an exception.
2828
PASS k-rate Q: Output of k-rate BiquadFilterNode is identical to the array [expected array].
2929
PASS k-rate Q: Output of a-rate BiquadFilterNode is identical to the array [expected array].
30-
PASS k-rate Q: Difference between a-rate and k-rate BiquadFilterNode is not constantly 0 (contains 7999 different values).
30+
PASS k-rate Q: Difference between a-rate and k-rate BiquadFilterNode is not constantly 0.
3131
PASS < [Biquad k-rate Q] All assertions passed. (total 8 assertions)
3232
PASS > [Biquad k-rate detune]
3333
PASS k-rate detune: Setting detune.automationRate to "k-rate" is equal to k-rate.
@@ -37,7 +37,7 @@ PASS k-rate detune: a-rate node:detune.setValueAtTime(0,0) did not throw an ex
3737
PASS k-rate detune: a-rate node:detune.linearRampToValueAtTime(1200,1) did not throw an exception.
3838
PASS k-rate detune: Output of k-rate BiquadFilterNode is identical to the array [expected array].
3939
PASS k-rate detune: Output of a-rate BiquadFilterNode is identical to the array [expected array].
40-
PASS k-rate detune: Difference between a-rate and k-rate BiquadFilterNode is not constantly 0 (contains 7999 different values).
40+
PASS k-rate detune: Difference between a-rate and k-rate BiquadFilterNode is not constantly 0.
4141
PASS < [Biquad k-rate detune] All assertions passed. (total 8 assertions)
4242
PASS > [Biquad k-rate frequency]
4343
PASS k-rate frequency: Setting frequency.automationRate to "k-rate" is equal to k-rate.
@@ -47,7 +47,7 @@ PASS k-rate frequency: a-rate node:frequency.setValueAtTime(350,0) did not thr
4747
PASS k-rate frequency: a-rate node:frequency.linearRampToValueAtTime(0,1) did not throw an exception.
4848
PASS k-rate frequency: Output of k-rate BiquadFilterNode is identical to the array [expected array].
4949
PASS k-rate frequency: Output of a-rate BiquadFilterNode is identical to the array [expected array].
50-
PASS k-rate frequency: Difference between a-rate and k-rate BiquadFilterNode is not constantly 0 (contains 7999 different values).
50+
PASS k-rate frequency: Difference between a-rate and k-rate BiquadFilterNode is not constantly 0.
5151
PASS < [Biquad k-rate frequency] All assertions passed. (total 8 assertions)
5252
PASS > [Biquad k-rate gain]
5353
PASS k-rate gain: Setting gain.automationRate to "k-rate" is equal to k-rate.
@@ -57,7 +57,7 @@ PASS k-rate gain: a-rate node:gain.setValueAtTime(10,0) did not throw an excep
5757
PASS k-rate gain: a-rate node:gain.linearRampToValueAtTime(0,1) did not throw an exception.
5858
PASS k-rate gain: Output of k-rate BiquadFilterNode is identical to the array [expected array].
5959
PASS k-rate gain: Output of a-rate BiquadFilterNode is identical to the array [expected array].
60-
PASS k-rate gain: Difference between a-rate and k-rate BiquadFilterNode is not constantly 0 (contains 7999 different values).
60+
PASS k-rate gain: Difference between a-rate and k-rate BiquadFilterNode is not constantly 0.
6161
PASS < [Biquad k-rate gain] All assertions passed. (total 8 assertions)
6262
PASS # AUDIT TASK RUNNER FINISHED: 5 tasks ran successfully.
6363

‎LayoutTests/imported/w3c/web-platform-tests/webaudio/the-audio-api/the-audioparam-interface/k-rate-constant-source-expected.txt‎

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -12,7 +12,7 @@ PASS k-rate offset: a-rate node:offset.setValueAtTime(0,0) did not throw an ex
1212
PASS k-rate offset: a-rate node:offset.linearRampToValueAtTime(10,0.064) did not throw an exception.
1313
PASS k-rate offset: Output of k-rate ConstantSourceNode is identical to the array [0,0,0,0,0,0,0,0,0,0,0,0,0,0,0,0...].
1414
PASS k-rate offset: Output of a-rate ConstantSourceNode is identical to the array [expected array].
15-
PASS k-rate offset: Difference between a-rate and k-rate ConstantSourceNode is not constantly 0 (contains 508 different values).
15+
PASS k-rate offset: Difference between a-rate and k-rate ConstantSourceNode is not constantly 0.
1616
PASS k-rate offset k-rate output [0: 127] contains only the constant 0.
1717
PASS k-rate offset k-rate output [128: 255] contains only the constant 2.5.
1818
PASS k-rate offset k-rate output [256: 383] contains only the constant 5.

‎LayoutTests/imported/w3c/web-platform-tests/webaudio/the-audio-api/the-audioparam-interface/k-rate-delay-connections-expected.txt‎

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -13,10 +13,10 @@ PASS testMod = new ConstantSourceNode(context) did not throw an exception.
1313
PASS testMod.offset.setValueAtTime(0, 0) did not throw an exception.
1414
PASS testMod.offset.linearRampToValueAtTime(1.125, 1) did not throw an exception.
1515
PASS testMod.connect(testNode.delayTime) did not throw an exception.
16-
PASS Expected k-rate delayTime AudioParam with input is not constantly 0 (contains 4656 different values).
17-
PASS Actual k-rate delayTime AudioParam with input is not constantly 0 (contains 4656 different values).
16+
PASS Expected k-rate delayTime AudioParam with input is not constantly 0.
17+
PASS Actual k-rate delayTime AudioParam with input is not constantly 0.
1818
PASS output[128, 143] contains only the constant 0.
19-
PASS output[144, 255] is not constantly 0 (contains 111 different values).
19+
PASS output[144, 255] is not constantly 0.
2020
PASS k-rate delayTime AudioParam with input equals [expected array] with an element-wise tolerance of {"absoluteThreshold":0,"relativeThreshold":0}.
2121
PASS < [delayTime] All assertions passed. (total 15 assertions)
2222
PASS # AUDIT TASK RUNNER FINISHED: 1 tasks ran successfully.

‎LayoutTests/imported/w3c/web-platform-tests/webaudio/the-audio-api/the-audioparam-interface/k-rate-delay-expected.txt‎

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -10,7 +10,7 @@ PASS DelayNode: a-rate node:delayTime.setValueAtTime(0,0) did not throw an exc
1010
PASS DelayNode: a-rate node:delayTime.linearRampToValueAtTime(0.5,1) did not throw an exception.
1111
PASS DelayNode: Output of k-rate DelayNode is identical to the array [expected array].
1212
PASS DelayNode: Output of a-rate DelayNode is identical to the array [expected array].
13-
PASS DelayNode: Difference between a-rate and k-rate DelayNode is not constantly 0 (contains 7937 different values).
13+
PASS DelayNode: Difference between a-rate and k-rate DelayNode is not constantly 0.
1414
PASS < [Test k-rate DelayNode] All assertions passed. (total 8 assertions)
1515
PASS # AUDIT TASK RUNNER FINISHED: 1 tasks ran successfully.
1616

‎LayoutTests/imported/w3c/web-platform-tests/webaudio/the-audio-api/the-audioparam-interface/k-rate-gain-expected.txt‎

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -10,7 +10,7 @@ PASS GainNode: a-rate node:gain.setValueAtTime(1,0) did not throw an exception
1010
PASS GainNode: a-rate node:gain.linearRampToValueAtTime(0,1) did not throw an exception.
1111
PASS GainNode: Output of k-rate GainNode is identical to the array [expected array].
1212
PASS GainNode: Output of a-rate GainNode is identical to the array [expected array].
13-
PASS GainNode: Difference between a-rate and k-rate GainNode is not constantly 0 (contains 7937 different values).
13+
PASS GainNode: Difference between a-rate and k-rate GainNode is not constantly 0.
1414
PASS < [Test k-rate GainNode] All assertions passed. (total 8 assertions)
1515
PASS # AUDIT TASK RUNNER FINISHED: 1 tasks ran successfully.
1616

0 commit comments

Comments
 (0)