Don't allow position:relative to apply to table sections. Fixes the crash described in

David Hyatt · David Hyatt · commit c2fdcfa44813 · 2005-10-26T22:13:29.000Z
Radar bug 4107882. (http://cityoflakeforest.com/cs/pw/cs_pw2a3.htm) Reviewed by bdakin * khtml/css/cssstyleselector.cpp: (khtml::CSSStyleSelector::adjustRenderStyle): Canonical link: https://commits.webkit.org/9299@main git-svn-id: https://svn.webkit.org/repository/webkit/trunk@10977 268f45cc-cd09-0410-ab3c-d52691b4dbfc
diff --git a/WebCore/ChangeLog-2005-12-19 b/WebCore/ChangeLog-2005-12-19
@@ -1,3 +1,13 @@
+2005-10-26  David Hyatt  <hyatt@apple.com>
+
+	Don't allow position:relative to apply to table sections.  Fixes the crash described in
+	Radar bug 4107882. (http://cityoflakeforest.com/cs/pw/cs_pw2a3.htm)
+	
+        Reviewed by bdakin
+
+        * khtml/css/cssstyleselector.cpp:
+        (khtml::CSSStyleSelector::adjustRenderStyle):
+        
 2005-10-26  Adele Peterson  <adele@apple.com>
 
         Reviewed by John.
diff --git a/WebCore/khtml/css/cssstyleselector.cpp b/WebCore/khtml/css/cssstyleselector.cpp
@@ -955,7 +955,9 @@ void CSSStyleSelector::adjustRenderStyle(RenderStyle* style, ElementImpl *e)
         // After performing the display mutation, check table rows.  We do not honor position:relative on
         // table rows or cells.  This has been established in CSS2.1 (and caused a crash in containingBlock()
         // on some sites).
-        if ((style->display() == TABLE_ROW || style->display() == TABLE_CELL) && style->position() == RELATIVE)
+        if ((style->display() == TABLE_HEADER_GROUP || style->display() == TABLE_ROW_GROUP ||
+             style->display() == TABLE_FOOTER_GROUP || style->display() == TABLE_ROW || style->display() == TABLE_CELL) &&
+             style->position() == RELATIVE)
             style->setPosition(STATIC);
     }
 
