Skip to content

Commit c0ec9ed

Browse files
donny-dontdonny-dont
committed
Remove quota module
https://bugs.webkit.org/show_bug.cgi?id=219206 Reviewed by Anders Carlsson. .: Remove the ability to set ENABLE_QUOTA. The Storage Quota API is deprecated and no WebKit port is enabling it. * Source/cmake/OptionsFTW.cmake: * Source/cmake/OptionsWin.cmake: * Source/cmake/WebKitFeatures.cmake: * Source/cmake/tools/vsprops/FeatureDefines.props: * Source/cmake/tools/vsprops/FeatureDefinesCairo.props: Source/WebCore: Remove the files and any reference to the quota module. * CMakeLists.txt: * DerivedSources-input.xcfilelist: * DerivedSources-output.xcfilelist: * DerivedSources.make: * Modules/quota/DOMWindow+Quota.idl: Removed. * Modules/quota/DOMWindowQuota.cpp: Removed. * Modules/quota/DOMWindowQuota.h: Removed. * Modules/quota/Navigator+StorageQuota.idl: Removed. * Modules/quota/NavigatorStorageQuota.cpp: Removed. * Modules/quota/NavigatorStorageQuota.h: Removed. * Modules/quota/StorageErrorCallback.cpp: Removed. * Modules/quota/StorageErrorCallback.h: Removed. * Modules/quota/StorageErrorCallback.idl: Removed. * Modules/quota/StorageInfo.cpp: Removed. * Modules/quota/StorageInfo.h: Removed. * Modules/quota/StorageInfo.idl: Removed. * Modules/quota/StorageQuota.cpp: Removed. * Modules/quota/StorageQuota.h: Removed. * Modules/quota/StorageQuota.idl: Removed. * Modules/quota/StorageQuotaCallback.h: Removed. * Modules/quota/StorageQuotaCallback.idl: Removed. * Modules/quota/StorageUsageCallback.h: Removed. * Modules/quota/StorageUsageCallback.idl: Removed. * Modules/quota/WorkerNavigator+StorageQuota.idl: Removed. * Modules/quota/WorkerNavigatorStorageQuota.cpp: Removed. * Modules/quota/WorkerNavigatorStorageQuota.h: Removed. * Sources.txt: * WebCore.xcodeproj/project.pbxproj: Source/WTF: Remove the ENABLE_QUOTA macro. * wtf/PlatformEnable.h: Tools: Remove the option to ENABLE_QUOTA. * Scripts/webkitperl/FeatureList.pm: Canonical link: https://commits.webkit.org/231829@main git-svn-id: https://svn.webkit.org/repository/webkit/trunk@270120 268f45cc-cd09-0410-ab3c-d52691b4dbfc
1 parent 62c9227 commit c0ec9ed

39 files changed

Lines changed: 78 additions & 1350 deletions

‎ChangeLog‎

Lines changed: 16 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -1,3 +1,19 @@
1+
2020-11-20 Don Olmstead <don.olmstead@sony.com>
2+
3+
Remove quota module
4+
https://bugs.webkit.org/show_bug.cgi?id=219206
5+
6+
Reviewed by Anders Carlsson.
7+
8+
Remove the ability to set ENABLE_QUOTA. The Storage Quota API is deprecated and no
9+
WebKit port is enabling it.
10+
11+
* Source/cmake/OptionsFTW.cmake:
12+
* Source/cmake/OptionsWin.cmake:
13+
* Source/cmake/WebKitFeatures.cmake:
14+
* Source/cmake/tools/vsprops/FeatureDefines.props:
15+
* Source/cmake/tools/vsprops/FeatureDefinesCairo.props:
16+
117
2020-11-09 Michael Catanzaro <mcatanzaro@gnome.org>
218

319
Enable llint asm on aarch64 when USE(64KB_PAGE_BLOCK) is enabled

‎Source/WTF/ChangeLog‎

Lines changed: 11 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -1,3 +1,14 @@
1+
2020-11-20 Don Olmstead <don.olmstead@sony.com>
2+
3+
Remove quota module
4+
https://bugs.webkit.org/show_bug.cgi?id=219206
5+
6+
Reviewed by Anders Carlsson.
7+
8+
Remove the ENABLE_QUOTA macro.
9+
10+
* wtf/PlatformEnable.h:
11+
112
2020-11-20 Philippe Normand <pnormand@igalia.com>
213

314
[MSE] Infinite loop in sample eviction when duration is NaN

‎Source/WTF/wtf/PlatformEnable.h‎

Lines changed: 0 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -426,10 +426,6 @@
426426
#define ENABLE_POINTER_LOCK 1
427427
#endif
428428

429-
#if !defined(ENABLE_QUOTA)
430-
#define ENABLE_QUOTA 0
431-
#endif
432-
433429
#if !defined(ENABLE_REMOTE_INSPECTOR)
434430
#define ENABLE_REMOTE_INSPECTOR 0
435431
#endif

‎Source/WebCore/CMakeLists.txt‎

Lines changed: 0 additions & 24 deletions
Original file line numberDiff line numberDiff line change
@@ -54,7 +54,6 @@ set(WebCore_PRIVATE_INCLUDE_DIRECTORIES
5454
"${WEBCORE_DIR}/Modules/paymentrequest"
5555
"${WEBCORE_DIR}/Modules/pictureinpicture"
5656
"${WEBCORE_DIR}/Modules/plugins"
57-
"${WEBCORE_DIR}/Modules/quota"
5857
"${WEBCORE_DIR}/Modules/remoteplayback"
5958
"${WEBCORE_DIR}/Modules/speech"
6059
"${WEBCORE_DIR}/Modules/streams"
@@ -202,7 +201,6 @@ set(WebCore_IDL_INCLUDES
202201
Modules/model-element
203202
Modules/notifications
204203
Modules/paymentrequest
205-
Modules/quota
206204
Modules/speech
207205
Modules/streams
208206
Modules/webaudio
@@ -1619,28 +1617,6 @@ list(APPEND WebCore_IDL_FILES
16191617
html/canvas/WebGLVertexArrayObjectOES.idl
16201618
)
16211619

1622-
if (ENABLE_QUOTA)
1623-
list(APPEND WebCore_SOURCES
1624-
Modules/quota/DOMWindowQuota.cpp
1625-
Modules/quota/NavigatorStorageQuota.cpp
1626-
Modules/quota/StorageErrorCallback.cpp
1627-
Modules/quota/StorageInfo.cpp
1628-
Modules/quota/StorageQuota.cpp
1629-
Modules/quota/WorkerNavigatorStorageQuota.cpp
1630-
)
1631-
endif ()
1632-
1633-
list(APPEND WebCore_IDL_FILES
1634-
Modules/quota/DOMWindow+Quota.idl
1635-
Modules/quota/Navigator+StorageQuota.idl
1636-
Modules/quota/StorageErrorCallback.idl
1637-
Modules/quota/StorageInfo.idl
1638-
Modules/quota/StorageQuota.idl
1639-
Modules/quota/StorageQuotaCallback.idl
1640-
Modules/quota/StorageUsageCallback.idl
1641-
Modules/quota/WorkerNavigator+StorageQuota.idl
1642-
)
1643-
16441620
if (ENABLE_GRAPHICS_CONTEXT_GL)
16451621
list(APPEND WebCore_SOURCES
16461622
platform/graphics/ANGLEWebKitBridge.cpp

‎Source/WebCore/ChangeLog‎

Lines changed: 38 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -1,3 +1,41 @@
1+
2020-11-20 Don Olmstead <don.olmstead@sony.com>
2+
3+
Remove quota module
4+
https://bugs.webkit.org/show_bug.cgi?id=219206
5+
6+
Reviewed by Anders Carlsson.
7+
8+
Remove the files and any reference to the quota module.
9+
10+
* CMakeLists.txt:
11+
* DerivedSources-input.xcfilelist:
12+
* DerivedSources-output.xcfilelist:
13+
* DerivedSources.make:
14+
* Modules/quota/DOMWindow+Quota.idl: Removed.
15+
* Modules/quota/DOMWindowQuota.cpp: Removed.
16+
* Modules/quota/DOMWindowQuota.h: Removed.
17+
* Modules/quota/Navigator+StorageQuota.idl: Removed.
18+
* Modules/quota/NavigatorStorageQuota.cpp: Removed.
19+
* Modules/quota/NavigatorStorageQuota.h: Removed.
20+
* Modules/quota/StorageErrorCallback.cpp: Removed.
21+
* Modules/quota/StorageErrorCallback.h: Removed.
22+
* Modules/quota/StorageErrorCallback.idl: Removed.
23+
* Modules/quota/StorageInfo.cpp: Removed.
24+
* Modules/quota/StorageInfo.h: Removed.
25+
* Modules/quota/StorageInfo.idl: Removed.
26+
* Modules/quota/StorageQuota.cpp: Removed.
27+
* Modules/quota/StorageQuota.h: Removed.
28+
* Modules/quota/StorageQuota.idl: Removed.
29+
* Modules/quota/StorageQuotaCallback.h: Removed.
30+
* Modules/quota/StorageQuotaCallback.idl: Removed.
31+
* Modules/quota/StorageUsageCallback.h: Removed.
32+
* Modules/quota/StorageUsageCallback.idl: Removed.
33+
* Modules/quota/WorkerNavigator+StorageQuota.idl: Removed.
34+
* Modules/quota/WorkerNavigatorStorageQuota.cpp: Removed.
35+
* Modules/quota/WorkerNavigatorStorageQuota.h: Removed.
36+
* Sources.txt:
37+
* WebCore.xcodeproj/project.pbxproj:
38+
139
2020-11-20 Antti Koivisto <antti@apple.com>
240

341
[LFC][Integration] Hit test runs in reverse order

‎Source/WebCore/DerivedSources-input.xcfilelist‎

Lines changed: 0 additions & 8 deletions
Original file line numberDiff line numberDiff line change
@@ -290,14 +290,6 @@ $(PROJECT_DIR)/Modules/pictureinpicture/PictureInPictureWindow.idl
290290
$(PROJECT_DIR)/Modules/plugins/QuickTimePluginReplacement.css
291291
$(PROJECT_DIR)/Modules/plugins/QuickTimePluginReplacement.idl
292292
$(PROJECT_DIR)/Modules/plugins/QuickTimePluginReplacement.js
293-
$(PROJECT_DIR)/Modules/quota/DOMWindow+Quota.idl
294-
$(PROJECT_DIR)/Modules/quota/Navigator+StorageQuota.idl
295-
$(PROJECT_DIR)/Modules/quota/StorageErrorCallback.idl
296-
$(PROJECT_DIR)/Modules/quota/StorageInfo.idl
297-
$(PROJECT_DIR)/Modules/quota/StorageQuota.idl
298-
$(PROJECT_DIR)/Modules/quota/StorageQuotaCallback.idl
299-
$(PROJECT_DIR)/Modules/quota/StorageUsageCallback.idl
300-
$(PROJECT_DIR)/Modules/quota/WorkerNavigator+StorageQuota.idl
301293
$(PROJECT_DIR)/Modules/remoteplayback/HTMLMediaElement+RemotePlayback.idl
302294
$(PROJECT_DIR)/Modules/remoteplayback/RemotePlayback.idl
303295
$(PROJECT_DIR)/Modules/remoteplayback/RemotePlaybackAvailabilityCallback.idl

‎Source/WebCore/DerivedSources-output.xcfilelist‎

Lines changed: 0 additions & 22 deletions
Original file line numberDiff line numberDiff line change
@@ -541,8 +541,6 @@ $(BUILT_PRODUCTS_DIR)/DerivedSources/WebCore/JSDOMWindow+DeviceOrientation.cpp
541541
$(BUILT_PRODUCTS_DIR)/DerivedSources/WebCore/JSDOMWindow+DeviceOrientation.h
542542
$(BUILT_PRODUCTS_DIR)/DerivedSources/WebCore/JSDOMWindow+IndexedDatabase.cpp
543543
$(BUILT_PRODUCTS_DIR)/DerivedSources/WebCore/JSDOMWindow+IndexedDatabase.h
544-
$(BUILT_PRODUCTS_DIR)/DerivedSources/WebCore/JSDOMWindow+Quota.cpp
545-
$(BUILT_PRODUCTS_DIR)/DerivedSources/WebCore/JSDOMWindow+Quota.h
546544
$(BUILT_PRODUCTS_DIR)/DerivedSources/WebCore/JSDOMWindow+RequestIdleCallback.cpp
547545
$(BUILT_PRODUCTS_DIR)/DerivedSources/WebCore/JSDOMWindow+RequestIdleCallback.h
548546
$(BUILT_PRODUCTS_DIR)/DerivedSources/WebCore/JSDOMWindow+Selection.cpp
@@ -559,8 +557,6 @@ $(BUILT_PRODUCTS_DIR)/DerivedSources/WebCore/JSDOMWindowCaches.cpp
559557
$(BUILT_PRODUCTS_DIR)/DerivedSources/WebCore/JSDOMWindowCaches.h
560558
$(BUILT_PRODUCTS_DIR)/DerivedSources/WebCore/JSDOMWindowIndexedDatabase.cpp
561559
$(BUILT_PRODUCTS_DIR)/DerivedSources/WebCore/JSDOMWindowIndexedDatabase.h
562-
$(BUILT_PRODUCTS_DIR)/DerivedSources/WebCore/JSDOMWindowQuota.cpp
563-
$(BUILT_PRODUCTS_DIR)/DerivedSources/WebCore/JSDOMWindowQuota.h
564560
$(BUILT_PRODUCTS_DIR)/DerivedSources/WebCore/JSDOMWindowSpeechSynthesis.cpp
565561
$(BUILT_PRODUCTS_DIR)/DerivedSources/WebCore/JSDOMWindowSpeechSynthesis.h
566562
$(BUILT_PRODUCTS_DIR)/DerivedSources/WebCore/JSDOMWindowWebDatabase.cpp
@@ -1385,8 +1381,6 @@ $(BUILT_PRODUCTS_DIR)/DerivedSources/WebCore/JSNavigator+MediaDevices.cpp
13851381
$(BUILT_PRODUCTS_DIR)/DerivedSources/WebCore/JSNavigator+MediaDevices.h
13861382
$(BUILT_PRODUCTS_DIR)/DerivedSources/WebCore/JSNavigator+MediaSession.cpp
13871383
$(BUILT_PRODUCTS_DIR)/DerivedSources/WebCore/JSNavigator+MediaSession.h
1388-
$(BUILT_PRODUCTS_DIR)/DerivedSources/WebCore/JSNavigator+StorageQuota.cpp
1389-
$(BUILT_PRODUCTS_DIR)/DerivedSources/WebCore/JSNavigator+StorageQuota.h
13901384
$(BUILT_PRODUCTS_DIR)/DerivedSources/WebCore/JSNavigator+WebDriver.cpp
13911385
$(BUILT_PRODUCTS_DIR)/DerivedSources/WebCore/JSNavigator+WebDriver.h
13921386
$(BUILT_PRODUCTS_DIR)/DerivedSources/WebCore/JSNavigator+WebXR.cpp
@@ -1429,8 +1423,6 @@ $(BUILT_PRODUCTS_DIR)/DerivedSources/WebCore/JSNavigatorServiceWorker.cpp
14291423
$(BUILT_PRODUCTS_DIR)/DerivedSources/WebCore/JSNavigatorServiceWorker.h
14301424
$(BUILT_PRODUCTS_DIR)/DerivedSources/WebCore/JSNavigatorShare.cpp
14311425
$(BUILT_PRODUCTS_DIR)/DerivedSources/WebCore/JSNavigatorShare.h
1432-
$(BUILT_PRODUCTS_DIR)/DerivedSources/WebCore/JSNavigatorStorageQuota.cpp
1433-
$(BUILT_PRODUCTS_DIR)/DerivedSources/WebCore/JSNavigatorStorageQuota.h
14341426
$(BUILT_PRODUCTS_DIR)/DerivedSources/WebCore/JSNavigatorWebDriver.cpp
14351427
$(BUILT_PRODUCTS_DIR)/DerivedSources/WebCore/JSNavigatorWebDriver.h
14361428
$(BUILT_PRODUCTS_DIR)/DerivedSources/WebCore/JSNavigatorWebXR.cpp
@@ -2183,18 +2175,8 @@ $(BUILT_PRODUCTS_DIR)/DerivedSources/WebCore/JSStereoPannerOptions.cpp
21832175
$(BUILT_PRODUCTS_DIR)/DerivedSources/WebCore/JSStereoPannerOptions.h
21842176
$(BUILT_PRODUCTS_DIR)/DerivedSources/WebCore/JSStorage.cpp
21852177
$(BUILT_PRODUCTS_DIR)/DerivedSources/WebCore/JSStorage.h
2186-
$(BUILT_PRODUCTS_DIR)/DerivedSources/WebCore/JSStorageErrorCallback.cpp
2187-
$(BUILT_PRODUCTS_DIR)/DerivedSources/WebCore/JSStorageErrorCallback.h
21882178
$(BUILT_PRODUCTS_DIR)/DerivedSources/WebCore/JSStorageEvent.cpp
21892179
$(BUILT_PRODUCTS_DIR)/DerivedSources/WebCore/JSStorageEvent.h
2190-
$(BUILT_PRODUCTS_DIR)/DerivedSources/WebCore/JSStorageInfo.cpp
2191-
$(BUILT_PRODUCTS_DIR)/DerivedSources/WebCore/JSStorageInfo.h
2192-
$(BUILT_PRODUCTS_DIR)/DerivedSources/WebCore/JSStorageQuota.cpp
2193-
$(BUILT_PRODUCTS_DIR)/DerivedSources/WebCore/JSStorageQuota.h
2194-
$(BUILT_PRODUCTS_DIR)/DerivedSources/WebCore/JSStorageQuotaCallback.cpp
2195-
$(BUILT_PRODUCTS_DIR)/DerivedSources/WebCore/JSStorageQuotaCallback.h
2196-
$(BUILT_PRODUCTS_DIR)/DerivedSources/WebCore/JSStorageUsageCallback.cpp
2197-
$(BUILT_PRODUCTS_DIR)/DerivedSources/WebCore/JSStorageUsageCallback.h
21982180
$(BUILT_PRODUCTS_DIR)/DerivedSources/WebCore/JSStringCallback.cpp
21992181
$(BUILT_PRODUCTS_DIR)/DerivedSources/WebCore/JSStringCallback.h
22002182
$(BUILT_PRODUCTS_DIR)/DerivedSources/WebCore/JSStyleMedia.cpp
@@ -2563,14 +2545,10 @@ $(BUILT_PRODUCTS_DIR)/DerivedSources/WebCore/JSWorkerLocation.cpp
25632545
$(BUILT_PRODUCTS_DIR)/DerivedSources/WebCore/JSWorkerLocation.h
25642546
$(BUILT_PRODUCTS_DIR)/DerivedSources/WebCore/JSWorkerNavigator+GPU.cpp
25652547
$(BUILT_PRODUCTS_DIR)/DerivedSources/WebCore/JSWorkerNavigator+GPU.h
2566-
$(BUILT_PRODUCTS_DIR)/DerivedSources/WebCore/JSWorkerNavigator+StorageQuota.cpp
2567-
$(BUILT_PRODUCTS_DIR)/DerivedSources/WebCore/JSWorkerNavigator+StorageQuota.h
25682548
$(BUILT_PRODUCTS_DIR)/DerivedSources/WebCore/JSWorkerNavigator.cpp
25692549
$(BUILT_PRODUCTS_DIR)/DerivedSources/WebCore/JSWorkerNavigator.h
25702550
$(BUILT_PRODUCTS_DIR)/DerivedSources/WebCore/JSWorkerNavigatorGPU.cpp
25712551
$(BUILT_PRODUCTS_DIR)/DerivedSources/WebCore/JSWorkerNavigatorGPU.h
2572-
$(BUILT_PRODUCTS_DIR)/DerivedSources/WebCore/JSWorkerNavigatorStorageQuota.cpp
2573-
$(BUILT_PRODUCTS_DIR)/DerivedSources/WebCore/JSWorkerNavigatorStorageQuota.h
25742552
$(BUILT_PRODUCTS_DIR)/DerivedSources/WebCore/JSWorkerType.cpp
25752553
$(BUILT_PRODUCTS_DIR)/DerivedSources/WebCore/JSWorkerType.h
25762554
$(BUILT_PRODUCTS_DIR)/DerivedSources/WebCore/JSWorklet.cpp

‎Source/WebCore/DerivedSources.make‎

Lines changed: 0 additions & 8 deletions
Original file line numberDiff line numberDiff line change
@@ -311,14 +311,6 @@ JS_BINDING_IDLS := \
311311
$(WebCore)/Modules/pictureinpicture/HTMLVideoElement+PictureInPicture.idl \
312312
$(WebCore)/Modules/pictureinpicture/PictureInPictureWindow.idl \
313313
$(WebCore)/Modules/plugins/QuickTimePluginReplacement.idl \
314-
$(WebCore)/Modules/quota/DOMWindow+Quota.idl \
315-
$(WebCore)/Modules/quota/Navigator+StorageQuota.idl \
316-
$(WebCore)/Modules/quota/StorageErrorCallback.idl \
317-
$(WebCore)/Modules/quota/StorageInfo.idl \
318-
$(WebCore)/Modules/quota/StorageQuota.idl \
319-
$(WebCore)/Modules/quota/StorageQuotaCallback.idl \
320-
$(WebCore)/Modules/quota/StorageUsageCallback.idl \
321-
$(WebCore)/Modules/quota/WorkerNavigator+StorageQuota.idl \
322314
$(WebCore)/Modules/remoteplayback/HTMLMediaElement+RemotePlayback.idl \
323315
$(WebCore)/Modules/remoteplayback/RemotePlayback.idl \
324316
$(WebCore)/Modules/remoteplayback/RemotePlaybackAvailabilityCallback.idl \

‎Source/WebCore/Modules/quota/DOMWindow+Quota.idl‎

Lines changed: 0 additions & 32 deletions
This file was deleted.

‎Source/WebCore/Modules/quota/DOMWindowQuota.cpp‎

Lines changed: 0 additions & 84 deletions
This file was deleted.

0 commit comments

Comments
 (0)