Skip to content

Commit bb751b0

Browse files
ConstellationConstellation
committed
[JSC] Remove already-shipped JS feature flags
https://bugs.webkit.org/show_bug.cgi?id=229387 Reviewed by Ross Kirsling. JSTests: * microbenchmarks/class-fields-private/get-private-name.js: * microbenchmarks/class-fields-private/monomorphic-get-private-field.js: * microbenchmarks/class-fields-private/polymorphic-get-private-field.js: * microbenchmarks/class-fields-private/polymorphic-put-private-field.js: * microbenchmarks/class-fields-private/put-private-field.js: * stress/class-fields-private-as-function.js: * stress/class-fields-private-cached-bytecode.js: * stress/class-fields-private-freeze-out-of-line.js: * stress/class-fields-private-freeze.js: * stress/class-fields-private-harmony.js: * stress/class-fields-private-on-proxy.js: * stress/class-fields-private-out-of-line.js: * stress/class-fields-private-prevent-extensions-out-of-line.js: * stress/class-fields-private-prevent-extensions.js: * stress/class-fields-private-seal-out-of-line.js: * stress/class-fields-private-seal.js: * stress/class-fields-private-use-eval.js: * stress/class-fields-static-harmony.js: * stress/class-fields-static-private-harmony.js: * stress/class-fields-stress-instance.js: * stress/class-private-method-access.js: * stress/dfg-get-private-name-by-id-generic.js: * stress/dfg-get-private-name-by-id-osr-bad-identifier.js: * stress/dfg-get-private-name-by-id.js: * stress/dfg-get-private-name-by-offset-osr-bad-identifier.js: * stress/dfg-get-private-name-by-offset-osr-bad-structure.js: * stress/dfg-get-private-name-by-offset.js: * stress/dfg-get-private-name-by-val-generic.js: * stress/dfg-put-private-name-check-barrier-insertion.js: * stress/dfg-put-private-name-compiled-as-put-by-id-direct.js: * stress/dfg-put-private-name-compiled-as-put-private-name-by-id.js: * stress/ftl-get-private-name-by-id.js: * stress/ftl-get-private-name-by-offset-multi.js: * stress/get-private-name-cache-failure.js: * stress/get-private-name-with-constant-ident.js: * stress/get-private-name-with-constant-symbol.js: * stress/get-private-name-with-different-symbol.js: * stress/get-private-name-with-primitive.js: * stress/get-private-name.js: * stress/optional-chaining-and-private-fields.js: * stress/private-accesor-duplicate-name-early-errors.js: * stress/private-accessor-static-non-static.js: * stress/private-brand-installed-after-super-call-from-arrow-function.js: * stress/private-brand-installed-after-super-call-from-eval.js: * stress/private-getter-brand-check.js: * stress/private-getter-inner-class.js: * stress/private-in-error.js: * stress/private-in.js: * stress/private-members-get-and-set.js: * stress/private-method-and-field-named-constructor.js: * stress/private-method-brand-check.js: * stress/private-method-change-attribute-from-branded-structure.js: * stress/private-method-change-prototype-from-branded-structure.js: * stress/private-method-check-private-brand-ic.js: * stress/private-method-check-structure-miss.js: * stress/private-method-comparison.js: * stress/private-method-delete-property-from-branded-structure.js: * stress/private-method-extends-brand-check.js: * stress/private-method-get-and-call.js: * stress/private-method-invalid-multiple-brand-installation.js: * stress/private-method-invalidate-compiled-with-constant-symbol.js: * stress/private-method-nested-class.js: * stress/private-method-on-sealed-objects.js: * stress/private-method-on-uncacheable-dictionary.js: * stress/private-method-polymorphic-with-constant-symbol.js: * stress/private-method-set-brand-should-have-write-barrier.js: * stress/private-method-untyped-use.js: * stress/private-method-with-uncacheable-dictionary-transition.js: * stress/private-methods-and-accessors-postfix-node.js: * stress/private-methods-and-accessors-prefix-node.js: * stress/private-methods-inline-cache.js: * stress/private-methods-megamorphic-ic.js: * stress/private-methods-on-proxy.js: * stress/private-methods-poly-ic-multiple-classes.js: * stress/private-methods-poly-ic-single-class.js: * stress/private-name-access-in-computed-property.js: * stress/private-names-available-on-direct-eval.js: * stress/private-names-available-on-eval-during-field-initialization.js: * stress/private-setter-brand-check.js: * stress/private-setter-inner-class.js: * stress/put-by-val-direct-addprivate.js: * stress/put-by-val-direct-putprivate.js: * stress/put-private-name-by-id-set-do-not-add-structure-trasition.js: * stress/put-private-name-check-structure-miss.js: * stress/put-private-name-constant-folding-to-mult-put-by-offset.js: * stress/put-private-name-constant-folding-to-put-by-offset.js: * stress/put-private-name-generic.js: * stress/put-private-name-invalid-define.js: * stress/put-private-name-invalid-store.js: * stress/put-private-name-invalidate-compiled-with-constant-symbol.js: * stress/put-private-name-polymorphic-with-constant-symbol.js: * stress/put-private-name-untyped-use.js: * stress/put-private-name-with-constant-symbol.js: * stress/put-private-name-with-different-identifier.js: * stress/put-private-name-with-primitive.js: * stress/static-private-methods-and-accessor-inner-class.js: * stress/static-private-methods-and-accessor-multiple-evaluation.js: * stress/static-private-methods-and-accessors-postfix-node.js: * stress/static-private-methods-and-accessors-prefix-node.js: * stress/v8-cleanup-from-different-realm.js: * stress/v8-cleanup-proxy-from-different-realm.js: * stress/v8-finalization-registry-basics.js: * stress/v8-finalizationregistry-and-weakref.js: * stress/v8-finalizationregistry-keeps-holdings-alive.js: * stress/v8-finalizationregistry-scheduled-for-cleanup-multiple-times.js: * stress/v8-multiple-dirty-finalization-registries.js: * stress/v8-reentrant-gc-from-cleanup.js: * stress/v8-stress-finalizationregistry-dirty-enqueue.js: * stress/v8-undefined-holdings.js: * stress/v8-unregister-after-cleanup.js: * stress/v8-unregister-before-cleanup.js: * stress/v8-unregister-called-twice.js: * stress/v8-unregister-inside-cleanup2.js: * stress/v8-unregister-inside-cleanup3.js: * stress/v8-unregister-many.js: * stress/v8-weak-unregistertoken.js: * test262/config.yaml: Source/JavaScriptCore: These features are already shipped. So removing these runtime flags to clean up source code and remove untested path. * API/JSObjectRef.cpp: (JSObjectMakeError): * bytecompiler/BytecodeGenerator.cpp: (JSC::BytecodeGenerator::BytecodeGenerator): * bytecompiler/NodesCodegen.cpp: (JSC::FunctionCallValueNode::emitBytecode): * parser/Lexer.cpp: (JSC::Lexer<T>::lexWithoutClearingLineTerminator): * parser/Parser.cpp: (JSC::Parser<LexerType>::parseInner): (JSC::Parser<LexerType>::parseForStatement): (JSC::Parser<LexerType>::parseClass): (JSC::Parser<LexerType>::parseBinaryExpression): (JSC::Parser<LexerType>::parseGetterSetter): (JSC::Parser<LexerType>::parsePrimaryExpression): (JSC::Parser<LexerType>::parseUnaryExpression): * runtime/AggregateErrorConstructor.cpp: (JSC::JSC_DEFINE_HOST_FUNCTION): * runtime/ErrorConstructor.cpp: (JSC::JSC_DEFINE_HOST_FUNCTION): * runtime/JSGlobalObject.h: * runtime/NativeErrorConstructor.cpp: (JSC::NativeErrorConstructor<errorType>::constructImpl): (JSC::NativeErrorConstructor<errorType>::callImpl): * runtime/Options.cpp: (JSC::Options::recomputeDependentOptions): * runtime/OptionsList.h: * wasm/js/WebAssemblyCompileErrorConstructor.cpp: (JSC::JSC_DEFINE_HOST_FUNCTION): * wasm/js/WebAssemblyLinkErrorConstructor.cpp: (JSC::JSC_DEFINE_HOST_FUNCTION): * wasm/js/WebAssemblyRuntimeErrorConstructor.cpp: (JSC::JSC_DEFINE_HOST_FUNCTION): Tools: * Scripts/run-jsc-benchmarks: LayoutTests: * js/script-tests/weakref-async-is-collected.js: * js/script-tests/weakref-eventually-collects-values.js: * js/script-tests/weakref-finalizationregistry.js: * js/script-tests/weakref-microtasks-dont-collect.js: * js/script-tests/weakref-weakset-consistency.js: * js/weakref-async-is-collected.html: * js/weakref-eventually-collects-values.html: * js/weakref-finalizationregistry.html: * js/weakref-microtasks-dont-collect.html: * js/weakref-weakset-consistency.html: * webaudio/finished-audio-buffer-source-nodes-should-be-collectable.html: Canonical link: https://commits.webkit.org/240816@main git-svn-id: https://svn.webkit.org/repository/webkit/trunk@281429 268f45cc-cd09-0410-ab3c-d52691b4dbfc
1 parent efb30b6 commit bb751b0

147 files changed

Lines changed: 242 additions & 289 deletions

File tree

Some content is hidden

Large Commits have some content hidden by default. Use the searchbox below for content that may be hidden.

‎JSTests/ChangeLog‎

Lines changed: 125 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -1,3 +1,128 @@
1+
2021-08-22 Yusuke Suzuki <ysuzuki@apple.com>
2+
3+
[JSC] Remove already-shipped JS feature flags
4+
https://bugs.webkit.org/show_bug.cgi?id=229387
5+
6+
Reviewed by Ross Kirsling.
7+
8+
* microbenchmarks/class-fields-private/get-private-name.js:
9+
* microbenchmarks/class-fields-private/monomorphic-get-private-field.js:
10+
* microbenchmarks/class-fields-private/polymorphic-get-private-field.js:
11+
* microbenchmarks/class-fields-private/polymorphic-put-private-field.js:
12+
* microbenchmarks/class-fields-private/put-private-field.js:
13+
* stress/class-fields-private-as-function.js:
14+
* stress/class-fields-private-cached-bytecode.js:
15+
* stress/class-fields-private-freeze-out-of-line.js:
16+
* stress/class-fields-private-freeze.js:
17+
* stress/class-fields-private-harmony.js:
18+
* stress/class-fields-private-on-proxy.js:
19+
* stress/class-fields-private-out-of-line.js:
20+
* stress/class-fields-private-prevent-extensions-out-of-line.js:
21+
* stress/class-fields-private-prevent-extensions.js:
22+
* stress/class-fields-private-seal-out-of-line.js:
23+
* stress/class-fields-private-seal.js:
24+
* stress/class-fields-private-use-eval.js:
25+
* stress/class-fields-static-harmony.js:
26+
* stress/class-fields-static-private-harmony.js:
27+
* stress/class-fields-stress-instance.js:
28+
* stress/class-private-method-access.js:
29+
* stress/dfg-get-private-name-by-id-generic.js:
30+
* stress/dfg-get-private-name-by-id-osr-bad-identifier.js:
31+
* stress/dfg-get-private-name-by-id.js:
32+
* stress/dfg-get-private-name-by-offset-osr-bad-identifier.js:
33+
* stress/dfg-get-private-name-by-offset-osr-bad-structure.js:
34+
* stress/dfg-get-private-name-by-offset.js:
35+
* stress/dfg-get-private-name-by-val-generic.js:
36+
* stress/dfg-put-private-name-check-barrier-insertion.js:
37+
* stress/dfg-put-private-name-compiled-as-put-by-id-direct.js:
38+
* stress/dfg-put-private-name-compiled-as-put-private-name-by-id.js:
39+
* stress/ftl-get-private-name-by-id.js:
40+
* stress/ftl-get-private-name-by-offset-multi.js:
41+
* stress/get-private-name-cache-failure.js:
42+
* stress/get-private-name-with-constant-ident.js:
43+
* stress/get-private-name-with-constant-symbol.js:
44+
* stress/get-private-name-with-different-symbol.js:
45+
* stress/get-private-name-with-primitive.js:
46+
* stress/get-private-name.js:
47+
* stress/optional-chaining-and-private-fields.js:
48+
* stress/private-accesor-duplicate-name-early-errors.js:
49+
* stress/private-accessor-static-non-static.js:
50+
* stress/private-brand-installed-after-super-call-from-arrow-function.js:
51+
* stress/private-brand-installed-after-super-call-from-eval.js:
52+
* stress/private-getter-brand-check.js:
53+
* stress/private-getter-inner-class.js:
54+
* stress/private-in-error.js:
55+
* stress/private-in.js:
56+
* stress/private-members-get-and-set.js:
57+
* stress/private-method-and-field-named-constructor.js:
58+
* stress/private-method-brand-check.js:
59+
* stress/private-method-change-attribute-from-branded-structure.js:
60+
* stress/private-method-change-prototype-from-branded-structure.js:
61+
* stress/private-method-check-private-brand-ic.js:
62+
* stress/private-method-check-structure-miss.js:
63+
* stress/private-method-comparison.js:
64+
* stress/private-method-delete-property-from-branded-structure.js:
65+
* stress/private-method-extends-brand-check.js:
66+
* stress/private-method-get-and-call.js:
67+
* stress/private-method-invalid-multiple-brand-installation.js:
68+
* stress/private-method-invalidate-compiled-with-constant-symbol.js:
69+
* stress/private-method-nested-class.js:
70+
* stress/private-method-on-sealed-objects.js:
71+
* stress/private-method-on-uncacheable-dictionary.js:
72+
* stress/private-method-polymorphic-with-constant-symbol.js:
73+
* stress/private-method-set-brand-should-have-write-barrier.js:
74+
* stress/private-method-untyped-use.js:
75+
* stress/private-method-with-uncacheable-dictionary-transition.js:
76+
* stress/private-methods-and-accessors-postfix-node.js:
77+
* stress/private-methods-and-accessors-prefix-node.js:
78+
* stress/private-methods-inline-cache.js:
79+
* stress/private-methods-megamorphic-ic.js:
80+
* stress/private-methods-on-proxy.js:
81+
* stress/private-methods-poly-ic-multiple-classes.js:
82+
* stress/private-methods-poly-ic-single-class.js:
83+
* stress/private-name-access-in-computed-property.js:
84+
* stress/private-names-available-on-direct-eval.js:
85+
* stress/private-names-available-on-eval-during-field-initialization.js:
86+
* stress/private-setter-brand-check.js:
87+
* stress/private-setter-inner-class.js:
88+
* stress/put-by-val-direct-addprivate.js:
89+
* stress/put-by-val-direct-putprivate.js:
90+
* stress/put-private-name-by-id-set-do-not-add-structure-trasition.js:
91+
* stress/put-private-name-check-structure-miss.js:
92+
* stress/put-private-name-constant-folding-to-mult-put-by-offset.js:
93+
* stress/put-private-name-constant-folding-to-put-by-offset.js:
94+
* stress/put-private-name-generic.js:
95+
* stress/put-private-name-invalid-define.js:
96+
* stress/put-private-name-invalid-store.js:
97+
* stress/put-private-name-invalidate-compiled-with-constant-symbol.js:
98+
* stress/put-private-name-polymorphic-with-constant-symbol.js:
99+
* stress/put-private-name-untyped-use.js:
100+
* stress/put-private-name-with-constant-symbol.js:
101+
* stress/put-private-name-with-different-identifier.js:
102+
* stress/put-private-name-with-primitive.js:
103+
* stress/static-private-methods-and-accessor-inner-class.js:
104+
* stress/static-private-methods-and-accessor-multiple-evaluation.js:
105+
* stress/static-private-methods-and-accessors-postfix-node.js:
106+
* stress/static-private-methods-and-accessors-prefix-node.js:
107+
* stress/v8-cleanup-from-different-realm.js:
108+
* stress/v8-cleanup-proxy-from-different-realm.js:
109+
* stress/v8-finalization-registry-basics.js:
110+
* stress/v8-finalizationregistry-and-weakref.js:
111+
* stress/v8-finalizationregistry-keeps-holdings-alive.js:
112+
* stress/v8-finalizationregistry-scheduled-for-cleanup-multiple-times.js:
113+
* stress/v8-multiple-dirty-finalization-registries.js:
114+
* stress/v8-reentrant-gc-from-cleanup.js:
115+
* stress/v8-stress-finalizationregistry-dirty-enqueue.js:
116+
* stress/v8-undefined-holdings.js:
117+
* stress/v8-unregister-after-cleanup.js:
118+
* stress/v8-unregister-before-cleanup.js:
119+
* stress/v8-unregister-called-twice.js:
120+
* stress/v8-unregister-inside-cleanup2.js:
121+
* stress/v8-unregister-inside-cleanup3.js:
122+
* stress/v8-unregister-many.js:
123+
* stress/v8-weak-unregistertoken.js:
124+
* test262/config.yaml:
125+
1126
2021-08-22 Yusuke Suzuki <ysuzuki@apple.com>
2127

3128
Unreviewed, speculative fix for old ICU

‎JSTests/microbenchmarks/class-fields-private/get-private-name.js‎

Lines changed: 0 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -1,5 +1,3 @@
1-
//@ requireOptions("--usePrivateClassFields=true")
2-
31
function assert(b, m = "Assertion failed") {
42
if (!b)
53
throw new Error(m);

‎JSTests/microbenchmarks/class-fields-private/monomorphic-get-private-field.js‎

Lines changed: 0 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -1,5 +1,3 @@
1-
//@ requireOptions("--usePrivateClassFields=true")
2-
31
class C {
42
#field;
53

‎JSTests/microbenchmarks/class-fields-private/polymorphic-get-private-field.js‎

Lines changed: 0 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -1,5 +1,3 @@
1-
//@ requireOptions("--usePrivateClassFields=true")
2-
31
class C {
42
#field;
53

‎JSTests/microbenchmarks/class-fields-private/polymorphic-put-private-field.js‎

Lines changed: 0 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -1,5 +1,3 @@
1-
//@ requireOptions("--allowUnsupportedTiers=true", "--usePrivateClassFields=true")
2-
31
class C {
42
#field;
53

‎JSTests/microbenchmarks/class-fields-private/put-private-field.js‎

Lines changed: 0 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -1,5 +1,3 @@
1-
//@ requireOptions("--allowUnsupportedTiers=true", "--usePrivateClassFields=true")
2-
31
class C {
42
#field;
53

‎JSTests/stress/class-fields-private-as-function.js‎

Lines changed: 0 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -1,5 +1,3 @@
1-
//@ requireOptions("--usePrivateClassFields=1")
2-
31
function assert(a, e) {
42
if (a !== e)
53
throw new Error("Expected: " + e + " but got: " + a);

‎JSTests/stress/class-fields-private-cached-bytecode.js‎

Lines changed: 0 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -1,5 +1,3 @@
1-
//@ runBytecodeCache("--usePrivateClassFields=true")
2-
31
function assert(a, e) {
42
if (a !== e)
53
throw new Error("Expected: " + e + " but got: " + a);

‎JSTests/stress/class-fields-private-freeze-out-of-line.js‎

Lines changed: 0 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -1,5 +1,3 @@
1-
//@ requireOptions("--usePrivateClassFields=1")
2-
31
let assert = Object.assign(
42
function assert(expr, message = "") {
53
if (expr == false)

‎JSTests/stress/class-fields-private-freeze.js‎

Lines changed: 0 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -1,5 +1,3 @@
1-
//@ requireOptions("--usePrivateClassFields=1")
2-
31
let assert = Object.assign(
42
function assert(expr, message = "") {
53
if (expr == false)

0 commit comments

Comments
 (0)