Enable mid-layout render tree dump with floating boxes

alanbaradlay · alanbaradlay · commit 99f888fb65ce · 2021-04-21T17:57:23.000Z
https://bugs.webkit.org/show_bug.cgi?id=224878 Reviewed by Simon Fraser. Floating box geometry dump requires the box to be placed first (see assert(isPlaced()) in FloatingObject::frameRect()). * rendering/FloatingObjects.cpp: (WebCore::operator<<): Canonical link: https://commits.webkit.org/236850@main git-svn-id: https://svn.webkit.org/repository/webkit/trunk@276373 268f45cc-cd09-0410-ab3c-d52691b4dbfc
diff --git a/Source/WebCore/ChangeLog b/Source/WebCore/ChangeLog
@@ -1,3 +1,15 @@
+2021-04-21  Zalan Bujtas  <zalan@apple.com>
+
+        Enable mid-layout render tree dump with floating boxes
+        https://bugs.webkit.org/show_bug.cgi?id=224878
+
+        Reviewed by Simon Fraser.
+
+        Floating box geometry dump requires the box to be placed first (see assert(isPlaced()) in FloatingObject::frameRect()).
+
+        * rendering/FloatingObjects.cpp:
+        (WebCore::operator<<):
+
 2021-04-21  Chris Lord  <clord@igalia.com>
 
         DOMException should be Serializable
diff --git a/Source/WebCore/rendering/FloatingObjects.cpp b/Source/WebCore/rendering/FloatingObjects.cpp
@@ -116,7 +116,12 @@ LayoutSize FloatingObject::translationOffsetToAncestor() const
 
 TextStream& operator<<(TextStream& stream, const FloatingObject& object)
 {
-    return stream << &object << " renderer " << &object.renderer() << " " << object.frameRect() << " paintsFloat " << object.paintsFloat() << " shouldPaint " << object.shouldPaint();
+    stream << &object << " renderer " << &object.renderer();
+    if (object.isPlaced())
+        stream << " " << object.frameRect();
+    else
+        stream << " (not placed yet)";
+    return stream << " paintsFloat " << object.paintsFloat() << " shouldPaint " << object.shouldPaint();
 }
 
 #endif

Original file line number	Diff line number	Diff line change
`@@ -116,7 +116,12 @@ LayoutSize FloatingObject::translationOffsetToAncestor() const`
`116`	`116`
`117`	`117`	`TextStream& operator<<(TextStream& stream, const FloatingObject& object)`
`118`	`118`	`{`
`119`		`- return stream << &object << " renderer " << &object.renderer() << " " << object.frameRect() << " paintsFloat " << object.paintsFloat() << " shouldPaint " << object.shouldPaint();`
	`119`	`+ stream << &object << " renderer " << &object.renderer();`
	`120`	`+ if (object.isPlaced())`
	`121`	`+ stream << " " << object.frameRect();`
	`122`	`+ else`
	`123`	`+ stream << " (not placed yet)";`
	`124`	`+ return stream << " paintsFloat " << object.paintsFloat() << " shouldPaint " << object.shouldPaint();`
`120`	`125`	`}`
`121`	`126`
`122`	`127`	`#endif`