Skip to content

Commit 95c3b8e

Browse files
committed
2011-04-15 MORITA Hajime <morrita@google.com>
Reviewed by Dimitri Glazkov. RenderDetailsMarker should belong to shadow element. https://bugs.webkit.org/show_bug.cgi?id=58591 * Render tree structure has changed. * Changed style rule on details-writing-mode.html to avoid to hit shadow CSS leak bug. * fast/html/details-writing-mode.html: * platform/chromium/test_expectations.txt: * platform/mac/fast/html/details-add-summary-1-and-click-expected.checksum: * platform/mac/fast/html/details-add-summary-1-and-click-expected.png: * platform/mac/fast/html/details-add-summary-1-and-click-expected.txt: * platform/mac/fast/html/details-add-summary-1-expected.checksum: * platform/mac/fast/html/details-add-summary-1-expected.png: * platform/mac/fast/html/details-add-summary-1-expected.txt: * platform/mac/fast/html/details-add-summary-10-and-click-expected.checksum: * platform/mac/fast/html/details-add-summary-10-and-click-expected.png: * platform/mac/fast/html/details-add-summary-10-and-click-expected.txt: * platform/mac/fast/html/details-add-summary-10-expected.checksum: * platform/mac/fast/html/details-add-summary-10-expected.png: * platform/mac/fast/html/details-add-summary-10-expected.txt: * platform/mac/fast/html/details-add-summary-2-and-click-expected.checksum: * platform/mac/fast/html/details-add-summary-2-and-click-expected.png: * platform/mac/fast/html/details-add-summary-2-and-click-expected.txt: * platform/mac/fast/html/details-add-summary-2-expected.checksum: * platform/mac/fast/html/details-add-summary-2-expected.png: * platform/mac/fast/html/details-add-summary-2-expected.txt: * platform/mac/fast/html/details-add-summary-3-and-click-expected.checksum: * platform/mac/fast/html/details-add-summary-3-and-click-expected.png: * platform/mac/fast/html/details-add-summary-3-and-click-expected.txt: * platform/mac/fast/html/details-add-summary-3-expected.checksum: * platform/mac/fast/html/details-add-summary-3-expected.png: * platform/mac/fast/html/details-add-summary-3-expected.txt: * platform/mac/fast/html/details-add-summary-4-and-click-expected.checksum: * platform/mac/fast/html/details-add-summary-4-and-click-expected.png: * platform/mac/fast/html/details-add-summary-4-and-click-expected.txt: * platform/mac/fast/html/details-add-summary-4-expected.checksum: * platform/mac/fast/html/details-add-summary-4-expected.png: * platform/mac/fast/html/details-add-summary-4-expected.txt: * platform/mac/fast/html/details-add-summary-5-and-click-expected.checksum: * platform/mac/fast/html/details-add-summary-5-and-click-expected.png: * platform/mac/fast/html/details-add-summary-5-and-click-expected.txt: * platform/mac/fast/html/details-add-summary-5-expected.checksum: * platform/mac/fast/html/details-add-summary-5-expected.png: * platform/mac/fast/html/details-add-summary-5-expected.txt: * platform/mac/fast/html/details-add-summary-6-and-click-expected.checksum: * platform/mac/fast/html/details-add-summary-6-and-click-expected.png: * platform/mac/fast/html/details-add-summary-6-and-click-expected.txt: * platform/mac/fast/html/details-add-summary-6-expected.checksum: * platform/mac/fast/html/details-add-summary-6-expected.png: * platform/mac/fast/html/details-add-summary-6-expected.txt: * platform/mac/fast/html/details-add-summary-7-and-click-expected.checksum: * platform/mac/fast/html/details-add-summary-7-and-click-expected.png: * platform/mac/fast/html/details-add-summary-7-and-click-expected.txt: * platform/mac/fast/html/details-add-summary-7-expected.checksum: * platform/mac/fast/html/details-add-summary-7-expected.png: * platform/mac/fast/html/details-add-summary-7-expected.txt: * platform/mac/fast/html/details-add-summary-8-and-click-expected.checksum: * platform/mac/fast/html/details-add-summary-8-and-click-expected.png: * platform/mac/fast/html/details-add-summary-8-and-click-expected.txt: * platform/mac/fast/html/details-add-summary-8-expected.checksum: * platform/mac/fast/html/details-add-summary-8-expected.png: * platform/mac/fast/html/details-add-summary-8-expected.txt: * platform/mac/fast/html/details-add-summary-9-and-click-expected.checksum: * platform/mac/fast/html/details-add-summary-9-and-click-expected.png: * platform/mac/fast/html/details-add-summary-9-and-click-expected.txt: * platform/mac/fast/html/details-add-summary-9-expected.checksum: * platform/mac/fast/html/details-add-summary-9-expected.png: * platform/mac/fast/html/details-add-summary-9-expected.txt: * platform/mac/fast/html/details-no-summary1-expected.checksum: * platform/mac/fast/html/details-no-summary1-expected.png: * platform/mac/fast/html/details-no-summary1-expected.txt: * platform/mac/fast/html/details-no-summary2-expected.checksum: * platform/mac/fast/html/details-no-summary2-expected.png: * platform/mac/fast/html/details-no-summary2-expected.txt: * platform/mac/fast/html/details-no-summary3-expected.checksum: * platform/mac/fast/html/details-no-summary3-expected.png: * platform/mac/fast/html/details-no-summary3-expected.txt: * platform/mac/fast/html/details-no-summary4-expected.checksum: * platform/mac/fast/html/details-no-summary4-expected.png: * platform/mac/fast/html/details-no-summary4-expected.txt: * platform/mac/fast/html/details-open-javascript-expected.checksum: * platform/mac/fast/html/details-open-javascript-expected.png: * platform/mac/fast/html/details-open-javascript-expected.txt: * platform/mac/fast/html/details-open1-expected.checksum: * platform/mac/fast/html/details-open1-expected.png: * platform/mac/fast/html/details-open1-expected.txt: * platform/mac/fast/html/details-open2-expected.checksum: * platform/mac/fast/html/details-open2-expected.png: * platform/mac/fast/html/details-open2-expected.txt: * platform/mac/fast/html/details-open3-expected.checksum: * platform/mac/fast/html/details-open3-expected.png: * platform/mac/fast/html/details-open3-expected.txt: * platform/mac/fast/html/details-open4-expected.checksum: * platform/mac/fast/html/details-open4-expected.png: * platform/mac/fast/html/details-open4-expected.txt: * platform/mac/fast/html/details-open5-expected.checksum: * platform/mac/fast/html/details-open5-expected.png: * platform/mac/fast/html/details-open5-expected.txt: * platform/mac/fast/html/details-open6-expected.checksum: * platform/mac/fast/html/details-open6-expected.png: * platform/mac/fast/html/details-open6-expected.txt: * platform/mac/fast/html/details-position-expected.checksum: * platform/mac/fast/html/details-position-expected.png: * platform/mac/fast/html/details-position-expected.txt: * platform/mac/fast/html/details-remove-summary-1-and-click-expected.checksum: * platform/mac/fast/html/details-remove-summary-1-and-click-expected.png: * platform/mac/fast/html/details-remove-summary-1-and-click-expected.txt: * platform/mac/fast/html/details-remove-summary-1-expected.checksum: * platform/mac/fast/html/details-remove-summary-1-expected.png: * platform/mac/fast/html/details-remove-summary-1-expected.txt: * platform/mac/fast/html/details-remove-summary-2-and-click-expected.checksum: * platform/mac/fast/html/details-remove-summary-2-and-click-expected.png: * platform/mac/fast/html/details-remove-summary-2-and-click-expected.txt: * platform/mac/fast/html/details-remove-summary-2-expected.checksum: * platform/mac/fast/html/details-remove-summary-2-expected.png: * platform/mac/fast/html/details-remove-summary-2-expected.txt: * platform/mac/fast/html/details-remove-summary-3-and-click-expected.checksum: * platform/mac/fast/html/details-remove-summary-3-and-click-expected.png: * platform/mac/fast/html/details-remove-summary-3-and-click-expected.txt: * platform/mac/fast/html/details-remove-summary-3-expected.checksum: * platform/mac/fast/html/details-remove-summary-3-expected.png: * platform/mac/fast/html/details-remove-summary-3-expected.txt: * platform/mac/fast/html/details-remove-summary-4-and-click-expected.checksum: * platform/mac/fast/html/details-remove-summary-4-and-click-expected.png: * platform/mac/fast/html/details-remove-summary-4-and-click-expected.txt: * platform/mac/fast/html/details-remove-summary-4-expected.checksum: * platform/mac/fast/html/details-remove-summary-4-expected.png: * platform/mac/fast/html/details-remove-summary-4-expected.txt: * platform/mac/fast/html/details-remove-summary-5-and-click-expected.checksum: * platform/mac/fast/html/details-remove-summary-5-and-click-expected.png: * platform/mac/fast/html/details-remove-summary-5-and-click-expected.txt: * platform/mac/fast/html/details-remove-summary-5-expected.checksum: * platform/mac/fast/html/details-remove-summary-5-expected.png: * platform/mac/fast/html/details-remove-summary-5-expected.txt: * platform/mac/fast/html/details-remove-summary-6-and-click-expected.checksum: * platform/mac/fast/html/details-remove-summary-6-and-click-expected.png: * platform/mac/fast/html/details-remove-summary-6-and-click-expected.txt: * platform/mac/fast/html/details-remove-summary-6-expected.checksum: * platform/mac/fast/html/details-remove-summary-6-expected.png: * platform/mac/fast/html/details-remove-summary-6-expected.txt: * platform/mac/fast/html/details-writing-mode-expected.checksum: * platform/mac/fast/html/details-writing-mode-expected.png: * platform/mac/fast/html/details-writing-mode-expected.txt: 2011-04-15 MORITA Hajime <morrita@google.com> Reviewed by Dimitri Glazkov. RenderDetailsMarker should belong to shadow element. https://bugs.webkit.org/show_bug.cgi?id=58591 - Introduced DetailsMarkerControl element, which is a shadow element of <summary>, creates RenderDetailsMarker. - Removed custom layout code from RenderDetails, RenderDetailsMarker, which is now done by usual CSS layout. Note that marker size is given via style for -webkit-details-marker pseudo class. - Converted default summary implementation from pure-renderer style to shadow of HTMLDetailsElement. Now RenderDetails knows nothing about default summary. - Moved event handling code from HTMLDetailsElement to HTMLSummaryElement because now the marker is always child of <summary>, and the clickable area is now <summary> itself. - Note that the rendering result is changed due to the conversion from custom layout code to usual CSS styling. * Android.mk: * CMakeLists.txt: * GNUmakefile.list.am: * WebCore.gypi: * WebCore.pro: * WebCore.vcproj/WebCore.vcproj: * WebCore.xcodeproj/project.pbxproj: * css/html.css: (summary::-webkit-details-marker): * dom/Element.cpp: (WebCore::Element::attach): * dom/Node.cpp: (WebCore::shouldCreateRendererFor): * dom/Node.h: (WebCore::Node::canHaveLightChildRendererWithShadow): * html/HTMLDetailsElement.cpp: (WebCore::HTMLDetailsElement::findSummaryFor): (WebCore::HTMLDetailsElement::findMainSummary): (WebCore::HTMLDetailsElement::refreshMainSummary): (WebCore::HTMLDetailsElement::createShadowSubtree): (WebCore::HTMLDetailsElement::childrenChanged): (WebCore::HTMLDetailsElement::finishParsingChildren): (WebCore::HTMLDetailsElement::toggleOpen): * html/HTMLDetailsElement.h: (WebCore::HTMLDetailsElement::canHaveLightChildRendererWithShadow): * html/HTMLSummaryElement.cpp: (WebCore::HTMLSummaryElement::create): (WebCore::HTMLSummaryElement::createShadowSubtree): (WebCore::HTMLSummaryElement::detailsElement): (WebCore::HTMLSummaryElement::isMainSummary): (WebCore::HTMLSummaryElement::defaultEventHandler): * html/HTMLSummaryElement.h: (WebCore::HTMLSummaryElement::canHaveLightChildRendererWithShadow): * html/shadow/DetailsMarkerControl.cpp: Added. (WebCore::DetailsMarkerControl::DetailsMarkerControl): (WebCore::DetailsMarkerControl::createRenderer): (WebCore::DetailsMarkerControl::rendererIsNeeded): (WebCore::DetailsMarkerControl::shadowPseudoId): (WebCore::DetailsMarkerControl::summaryElement): * html/shadow/DetailsMarkerControl.h: Added. (WebCore::DetailsMarkerControl::create): * rendering/RenderDetails.cpp: (WebCore::RenderDetails::RenderDetails): (WebCore::RenderDetails::styleDidChange): (WebCore::RenderDetails::moveSummaryToContents): (WebCore::RenderDetails::checkMainSummary): (WebCore::RenderDetails::layout): * rendering/RenderDetails.h: * rendering/RenderDetailsMarker.cpp: (WebCore::RenderDetailsMarker::RenderDetailsMarker): (WebCore::RenderDetailsMarker::isOpen): (WebCore::RenderDetailsMarker::getPath): (WebCore::RenderDetailsMarker::paint): (WebCore::RenderDetailsMarker::details): * rendering/RenderDetailsMarker.h: Canonical link: https://commits.webkit.org/73780@main git-svn-id: https://svn.webkit.org/repository/webkit/trunk@84039 268f45cc-cd09-0410-ab3c-d52691b4dbfc
1 parent e3a890c commit 95c3b8e

160 files changed

Lines changed: 1110 additions & 875 deletions

File tree

Some content is hidden

Large Commits have some content hidden by default. Use the searchbox below for content that may be hidden.

LayoutTests/ChangeLog

Lines changed: 148 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -1,3 +1,151 @@
1+
2011-04-15 MORITA Hajime <morrita@google.com>
2+
3+
Reviewed by Dimitri Glazkov.
4+
5+
RenderDetailsMarker should belong to shadow element.
6+
https://bugs.webkit.org/show_bug.cgi?id=58591
7+
8+
* Render tree structure has changed.
9+
* Changed style rule on details-writing-mode.html to avoid to hit shadow CSS leak bug.
10+
11+
* fast/html/details-writing-mode.html:
12+
* platform/chromium/test_expectations.txt:
13+
* platform/mac/fast/html/details-add-summary-1-and-click-expected.checksum:
14+
* platform/mac/fast/html/details-add-summary-1-and-click-expected.png:
15+
* platform/mac/fast/html/details-add-summary-1-and-click-expected.txt:
16+
* platform/mac/fast/html/details-add-summary-1-expected.checksum:
17+
* platform/mac/fast/html/details-add-summary-1-expected.png:
18+
* platform/mac/fast/html/details-add-summary-1-expected.txt:
19+
* platform/mac/fast/html/details-add-summary-10-and-click-expected.checksum:
20+
* platform/mac/fast/html/details-add-summary-10-and-click-expected.png:
21+
* platform/mac/fast/html/details-add-summary-10-and-click-expected.txt:
22+
* platform/mac/fast/html/details-add-summary-10-expected.checksum:
23+
* platform/mac/fast/html/details-add-summary-10-expected.png:
24+
* platform/mac/fast/html/details-add-summary-10-expected.txt:
25+
* platform/mac/fast/html/details-add-summary-2-and-click-expected.checksum:
26+
* platform/mac/fast/html/details-add-summary-2-and-click-expected.png:
27+
* platform/mac/fast/html/details-add-summary-2-and-click-expected.txt:
28+
* platform/mac/fast/html/details-add-summary-2-expected.checksum:
29+
* platform/mac/fast/html/details-add-summary-2-expected.png:
30+
* platform/mac/fast/html/details-add-summary-2-expected.txt:
31+
* platform/mac/fast/html/details-add-summary-3-and-click-expected.checksum:
32+
* platform/mac/fast/html/details-add-summary-3-and-click-expected.png:
33+
* platform/mac/fast/html/details-add-summary-3-and-click-expected.txt:
34+
* platform/mac/fast/html/details-add-summary-3-expected.checksum:
35+
* platform/mac/fast/html/details-add-summary-3-expected.png:
36+
* platform/mac/fast/html/details-add-summary-3-expected.txt:
37+
* platform/mac/fast/html/details-add-summary-4-and-click-expected.checksum:
38+
* platform/mac/fast/html/details-add-summary-4-and-click-expected.png:
39+
* platform/mac/fast/html/details-add-summary-4-and-click-expected.txt:
40+
* platform/mac/fast/html/details-add-summary-4-expected.checksum:
41+
* platform/mac/fast/html/details-add-summary-4-expected.png:
42+
* platform/mac/fast/html/details-add-summary-4-expected.txt:
43+
* platform/mac/fast/html/details-add-summary-5-and-click-expected.checksum:
44+
* platform/mac/fast/html/details-add-summary-5-and-click-expected.png:
45+
* platform/mac/fast/html/details-add-summary-5-and-click-expected.txt:
46+
* platform/mac/fast/html/details-add-summary-5-expected.checksum:
47+
* platform/mac/fast/html/details-add-summary-5-expected.png:
48+
* platform/mac/fast/html/details-add-summary-5-expected.txt:
49+
* platform/mac/fast/html/details-add-summary-6-and-click-expected.checksum:
50+
* platform/mac/fast/html/details-add-summary-6-and-click-expected.png:
51+
* platform/mac/fast/html/details-add-summary-6-and-click-expected.txt:
52+
* platform/mac/fast/html/details-add-summary-6-expected.checksum:
53+
* platform/mac/fast/html/details-add-summary-6-expected.png:
54+
* platform/mac/fast/html/details-add-summary-6-expected.txt:
55+
* platform/mac/fast/html/details-add-summary-7-and-click-expected.checksum:
56+
* platform/mac/fast/html/details-add-summary-7-and-click-expected.png:
57+
* platform/mac/fast/html/details-add-summary-7-and-click-expected.txt:
58+
* platform/mac/fast/html/details-add-summary-7-expected.checksum:
59+
* platform/mac/fast/html/details-add-summary-7-expected.png:
60+
* platform/mac/fast/html/details-add-summary-7-expected.txt:
61+
* platform/mac/fast/html/details-add-summary-8-and-click-expected.checksum:
62+
* platform/mac/fast/html/details-add-summary-8-and-click-expected.png:
63+
* platform/mac/fast/html/details-add-summary-8-and-click-expected.txt:
64+
* platform/mac/fast/html/details-add-summary-8-expected.checksum:
65+
* platform/mac/fast/html/details-add-summary-8-expected.png:
66+
* platform/mac/fast/html/details-add-summary-8-expected.txt:
67+
* platform/mac/fast/html/details-add-summary-9-and-click-expected.checksum:
68+
* platform/mac/fast/html/details-add-summary-9-and-click-expected.png:
69+
* platform/mac/fast/html/details-add-summary-9-and-click-expected.txt:
70+
* platform/mac/fast/html/details-add-summary-9-expected.checksum:
71+
* platform/mac/fast/html/details-add-summary-9-expected.png:
72+
* platform/mac/fast/html/details-add-summary-9-expected.txt:
73+
* platform/mac/fast/html/details-no-summary1-expected.checksum:
74+
* platform/mac/fast/html/details-no-summary1-expected.png:
75+
* platform/mac/fast/html/details-no-summary1-expected.txt:
76+
* platform/mac/fast/html/details-no-summary2-expected.checksum:
77+
* platform/mac/fast/html/details-no-summary2-expected.png:
78+
* platform/mac/fast/html/details-no-summary2-expected.txt:
79+
* platform/mac/fast/html/details-no-summary3-expected.checksum:
80+
* platform/mac/fast/html/details-no-summary3-expected.png:
81+
* platform/mac/fast/html/details-no-summary3-expected.txt:
82+
* platform/mac/fast/html/details-no-summary4-expected.checksum:
83+
* platform/mac/fast/html/details-no-summary4-expected.png:
84+
* platform/mac/fast/html/details-no-summary4-expected.txt:
85+
* platform/mac/fast/html/details-open-javascript-expected.checksum:
86+
* platform/mac/fast/html/details-open-javascript-expected.png:
87+
* platform/mac/fast/html/details-open-javascript-expected.txt:
88+
* platform/mac/fast/html/details-open1-expected.checksum:
89+
* platform/mac/fast/html/details-open1-expected.png:
90+
* platform/mac/fast/html/details-open1-expected.txt:
91+
* platform/mac/fast/html/details-open2-expected.checksum:
92+
* platform/mac/fast/html/details-open2-expected.png:
93+
* platform/mac/fast/html/details-open2-expected.txt:
94+
* platform/mac/fast/html/details-open3-expected.checksum:
95+
* platform/mac/fast/html/details-open3-expected.png:
96+
* platform/mac/fast/html/details-open3-expected.txt:
97+
* platform/mac/fast/html/details-open4-expected.checksum:
98+
* platform/mac/fast/html/details-open4-expected.png:
99+
* platform/mac/fast/html/details-open4-expected.txt:
100+
* platform/mac/fast/html/details-open5-expected.checksum:
101+
* platform/mac/fast/html/details-open5-expected.png:
102+
* platform/mac/fast/html/details-open5-expected.txt:
103+
* platform/mac/fast/html/details-open6-expected.checksum:
104+
* platform/mac/fast/html/details-open6-expected.png:
105+
* platform/mac/fast/html/details-open6-expected.txt:
106+
* platform/mac/fast/html/details-position-expected.checksum:
107+
* platform/mac/fast/html/details-position-expected.png:
108+
* platform/mac/fast/html/details-position-expected.txt:
109+
* platform/mac/fast/html/details-remove-summary-1-and-click-expected.checksum:
110+
* platform/mac/fast/html/details-remove-summary-1-and-click-expected.png:
111+
* platform/mac/fast/html/details-remove-summary-1-and-click-expected.txt:
112+
* platform/mac/fast/html/details-remove-summary-1-expected.checksum:
113+
* platform/mac/fast/html/details-remove-summary-1-expected.png:
114+
* platform/mac/fast/html/details-remove-summary-1-expected.txt:
115+
* platform/mac/fast/html/details-remove-summary-2-and-click-expected.checksum:
116+
* platform/mac/fast/html/details-remove-summary-2-and-click-expected.png:
117+
* platform/mac/fast/html/details-remove-summary-2-and-click-expected.txt:
118+
* platform/mac/fast/html/details-remove-summary-2-expected.checksum:
119+
* platform/mac/fast/html/details-remove-summary-2-expected.png:
120+
* platform/mac/fast/html/details-remove-summary-2-expected.txt:
121+
* platform/mac/fast/html/details-remove-summary-3-and-click-expected.checksum:
122+
* platform/mac/fast/html/details-remove-summary-3-and-click-expected.png:
123+
* platform/mac/fast/html/details-remove-summary-3-and-click-expected.txt:
124+
* platform/mac/fast/html/details-remove-summary-3-expected.checksum:
125+
* platform/mac/fast/html/details-remove-summary-3-expected.png:
126+
* platform/mac/fast/html/details-remove-summary-3-expected.txt:
127+
* platform/mac/fast/html/details-remove-summary-4-and-click-expected.checksum:
128+
* platform/mac/fast/html/details-remove-summary-4-and-click-expected.png:
129+
* platform/mac/fast/html/details-remove-summary-4-and-click-expected.txt:
130+
* platform/mac/fast/html/details-remove-summary-4-expected.checksum:
131+
* platform/mac/fast/html/details-remove-summary-4-expected.png:
132+
* platform/mac/fast/html/details-remove-summary-4-expected.txt:
133+
* platform/mac/fast/html/details-remove-summary-5-and-click-expected.checksum:
134+
* platform/mac/fast/html/details-remove-summary-5-and-click-expected.png:
135+
* platform/mac/fast/html/details-remove-summary-5-and-click-expected.txt:
136+
* platform/mac/fast/html/details-remove-summary-5-expected.checksum:
137+
* platform/mac/fast/html/details-remove-summary-5-expected.png:
138+
* platform/mac/fast/html/details-remove-summary-5-expected.txt:
139+
* platform/mac/fast/html/details-remove-summary-6-and-click-expected.checksum:
140+
* platform/mac/fast/html/details-remove-summary-6-and-click-expected.png:
141+
* platform/mac/fast/html/details-remove-summary-6-and-click-expected.txt:
142+
* platform/mac/fast/html/details-remove-summary-6-expected.checksum:
143+
* platform/mac/fast/html/details-remove-summary-6-expected.png:
144+
* platform/mac/fast/html/details-remove-summary-6-expected.txt:
145+
* platform/mac/fast/html/details-writing-mode-expected.checksum:
146+
* platform/mac/fast/html/details-writing-mode-expected.png:
147+
* platform/mac/fast/html/details-writing-mode-expected.txt:
148+
1149
2011-04-15 Adrienne Walker <enne@google.com>
2150

3151
[chromium] Unreviewed, update baselines for compositing changes.

LayoutTests/fast/html/details-writing-mode.html

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -4,7 +4,7 @@
44
width: 120px;
55
height: 120px;
66
}
7-
div {
7+
td div {
88
height: 100%;
99
width: 100%;
1010
}

LayoutTests/platform/chromium/test_expectations.txt

Lines changed: 47 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -3487,4 +3487,51 @@ BUGCROGERS WIN LINUX : fast/text/zero-font-size.html = IMAGE+TEXT
34873487
// Flaky due to this webkit bug
34883488
BUGWK58632 GPU LINUX DEBUG : compositing/direct-image-compositing.html = IMAGE
34893489

3490+
3491+
// Temporarily marked failing for rebaselining.
3492+
BUGMORRITA : fast/html/details-add-summary-1-and-click.html = FAIL
3493+
BUGMORRITA : fast/html/details-add-summary-10-and-click.html = FAIL
3494+
BUGMORRITA : fast/html/details-add-summary-10.html = FAIL
3495+
BUGMORRITA : fast/html/details-add-summary-2-and-click.html = FAIL
3496+
BUGMORRITA : fast/html/details-add-summary-2.html = FAIL
3497+
BUGMORRITA : fast/html/details-add-summary-3-and-click.html = FAIL
3498+
BUGMORRITA : fast/html/details-add-summary-3.html = FAIL
3499+
BUGMORRITA : fast/html/details-add-summary-4-and-click.html = FAIL
3500+
BUGMORRITA : fast/html/details-add-summary-4.html = FAIL
3501+
BUGMORRITA : fast/html/details-add-summary-5-and-click.html = FAIL
3502+
BUGMORRITA : fast/html/details-add-summary-5.html = FAIL
3503+
BUGMORRITA : fast/html/details-add-summary-6-and-click.html = FAIL
3504+
BUGMORRITA : fast/html/details-add-summary-6.html = FAIL
3505+
BUGMORRITA : fast/html/details-add-summary-7-and-click.html = FAIL
3506+
BUGMORRITA : fast/html/details-add-summary-7.html = FAIL
3507+
BUGMORRITA : fast/html/details-add-summary-8-and-click.html = FAIL
3508+
BUGMORRITA : fast/html/details-add-summary-8.html = FAIL
3509+
BUGMORRITA : fast/html/details-add-summary-9-and-click.html = FAIL
3510+
BUGMORRITA : fast/html/details-add-summary-9.html = FAIL
3511+
BUGMORRITA : fast/html/details-no-summary1.html = FAIL
3512+
BUGMORRITA : fast/html/details-no-summary2.html = FAIL
3513+
BUGMORRITA : fast/html/details-no-summary3.html = FAIL
3514+
BUGMORRITA : fast/html/details-no-summary4.html = FAIL
3515+
BUGMORRITA : fast/html/details-open-javascript.html = FAIL
3516+
BUGMORRITA : fast/html/details-open1.html = FAIL
3517+
BUGMORRITA : fast/html/details-open2.html = FAIL
3518+
BUGMORRITA : fast/html/details-open3.html = FAIL
3519+
BUGMORRITA : fast/html/details-open4.html = FAIL
3520+
BUGMORRITA : fast/html/details-open5.html = FAIL
3521+
BUGMORRITA : fast/html/details-open6.html = FAIL
3522+
BUGMORRITA : fast/html/details-position.html = FAIL
3523+
BUGMORRITA : fast/html/details-remove-summary-1-and-click.html = FAIL
3524+
BUGMORRITA : fast/html/details-remove-summary-1.html = FAIL
3525+
BUGMORRITA : fast/html/details-remove-summary-2-and-click.html = FAIL
3526+
BUGMORRITA : fast/html/details-remove-summary-2.html = FAIL
3527+
BUGMORRITA : fast/html/details-remove-summary-3-and-click.html = FAIL
3528+
BUGMORRITA : fast/html/details-remove-summary-3.html = FAIL
3529+
BUGMORRITA : fast/html/details-remove-summary-4-and-click.html = FAIL
3530+
BUGMORRITA : fast/html/details-remove-summary-4.html = FAIL
3531+
BUGMORRITA : fast/html/details-remove-summary-5-and-click.html = FAIL
3532+
BUGMORRITA : fast/html/details-remove-summary-5.html = FAIL
3533+
BUGMORRITA : fast/html/details-remove-summary-6-and-click.html = FAIL
3534+
BUGMORRITA : fast/html/details-remove-summary-6.html = FAIL
3535+
BUGMORRITA : fast/html/details-writing-mode.html = FAIL
3536+
34903537
BUGWK58619 GPU LINUX WIN : media/video-volume-slider.html = IMAGE
Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1 +1 @@
1-
37d5597b89998628cee1ea0bd9c8d01a
1+
491d366caa06a108e40b80616ab92cea
171 Bytes
Loading

LayoutTests/platform/mac/fast/html/details-add-summary-1-and-click-expected.txt

Lines changed: 4 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -6,8 +6,8 @@ layer at (0,0) size 800x600
66
RenderDetails {DETAILS} at (0,0) size 800x18
77
RenderBlock (anonymous) at (0,0) size 800x18
88
RenderSummary {SUMMARY} at (0,0) size 800x18
9-
RenderDetailsMarker at (0,0) size 9x18: down
10-
RenderText {#text} at (15,0) size 39x18
11-
text run at (15,0) width 39: "new 1"
9+
RenderDetailsMarker {DIV} at (0,4) size 10x10: down
10+
RenderText {#text} at (16,0) size 39x18
11+
text run at (16,0) width 39: "new 1"
1212
RenderBlock (anonymous) at (0,18) size 800x0
13-
caret: position 0 of child 0 {#text} of child 0 {SUMMARY} of child 1 {DETAILS} of body
13+
caret: position 0 of child 0 {DIV} of {#shadow-root} of child 0 {SUMMARY} of child 1 {DETAILS} of body
Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1 +1 @@
1-
5f7f34c4d7bf0f9a7a6030d44a084b80
1+
ae2387fbc8de068bc166dfe95a26f477
58 Bytes
Loading

LayoutTests/platform/mac/fast/html/details-add-summary-1-expected.txt

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -6,7 +6,7 @@ layer at (0,0) size 800x600
66
RenderDetails {DETAILS} at (0,0) size 784x18
77
RenderBlock (anonymous) at (0,0) size 784x18
88
RenderSummary {SUMMARY} at (0,0) size 784x18
9-
RenderDetailsMarker at (0,0) size 9x18: right
10-
RenderText {#text} at (15,0) size 39x18
11-
text run at (15,0) width 39: "new 1"
9+
RenderDetailsMarker {DIV} at (0,4) size 10x10: right
10+
RenderText {#text} at (16,0) size 39x18
11+
text run at (16,0) width 39: "new 1"
1212
RenderBlock (anonymous) at (0,18) size 784x0

LayoutTests/platform/mac/fast/html/details-add-summary-10-and-click-expected.checksum

Lines changed: 0 additions & 1 deletion
This file was deleted.

0 commit comments

Comments
 (0)